Patchwork [Precise] UBUNTU: Remove headers asm symlink entirely

login
register
mail settings
Submitter Tim Gardner
Date April 10, 2012, 2:36 p.m.
Message ID <1334068582-20272-1-git-send-email-tim.gardner@canonical.com>
Download mbox | patch
Permalink /patch/151602/
State New
Headers show

Comments

Tim Gardner - April 10, 2012, 2:36 p.m.
BugLink: http://bugs.launchpad.net/bugs/974403

"UBUNTU: [Config] Fix invalid linux-headers link" moved the erroneous
symlink from asm-$ARCH to asm-generic. As it turns out, the asm symlink
is superfluous, so just remove it entirely.

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 debian/rules.d/2-binary-arch.mk |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
Leann Ogasawara - April 10, 2012, 3:09 p.m.
On Tue, 2012-04-10 at 08:36 -0600, Tim Gardner wrote:
> BugLink: http://bugs.launchpad.net/bugs/974403
> 
> "UBUNTU: [Config] Fix invalid linux-headers link" moved the erroneous
> symlink from asm-$ARCH to asm-generic. As it turns out, the asm symlink
> is superfluous, so just remove it entirely.
> 
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>

Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com>

> ---
>  debian/rules.d/2-binary-arch.mk |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> index 8308925..66b4e51 100644
> --- a/debian/rules.d/2-binary-arch.mk
> +++ b/debian/rules.d/2-binary-arch.mk
> @@ -189,9 +189,6 @@ ifeq ($(arch),powerpc)
>  endif
>  	# Script to symlink everything up
>  	$(SHELL) $(DROOT)/scripts/link-headers "$(hdrdir)" "$(basepkg)" "$*"
> -	# Setup the proper asm symlink
> -	rm -f $(hdrdir)/include/asm
> -	(cd $(hdrdir)/include; ln -s asm-generic asm)
>  	# The build symlink
>  	install -d debian/$(basepkg)-$*/lib/modules/$(abi_release)-$*
>  	ln -s /usr/src/$(basepkg)-$* \
> -- 
> 1.7.9.1
> 
>
Andy Whitcroft - April 10, 2012, 5:37 p.m.
On Tue, Apr 10, 2012 at 08:09:17AM -0700, Leann Ogasawara wrote:
> On Tue, 2012-04-10 at 08:36 -0600, Tim Gardner wrote:
> > BugLink: http://bugs.launchpad.net/bugs/974403
> > 
> > "UBUNTU: [Config] Fix invalid linux-headers link" moved the erroneous
> > symlink from asm-$ARCH to asm-generic. As it turns out, the asm symlink
> > is superfluous, so just remove it entirely.
> > 
> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> 
> Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com>
> 
> > ---
> >  debian/rules.d/2-binary-arch.mk |    3 ---
> >  1 files changed, 0 insertions(+), 3 deletions(-)
> > 
> > diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> > index 8308925..66b4e51 100644
> > --- a/debian/rules.d/2-binary-arch.mk
> > +++ b/debian/rules.d/2-binary-arch.mk
> > @@ -189,9 +189,6 @@ ifeq ($(arch),powerpc)
> >  endif
> >  	# Script to symlink everything up
> >  	$(SHELL) $(DROOT)/scripts/link-headers "$(hdrdir)" "$(basepkg)" "$*"
> > -	# Setup the proper asm symlink
> > -	rm -f $(hdrdir)/include/asm
> > -	(cd $(hdrdir)/include; ln -s asm-generic asm)
> >  	# The build symlink
> >  	install -d debian/$(basepkg)-$*/lib/modules/$(abi_release)-$*
> >  	ln -s /usr/src/$(basepkg)-$* \
> > -- 
> > 1.7.9.1
> > 
> > 
> 

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw

Patch

diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
index 8308925..66b4e51 100644
--- a/debian/rules.d/2-binary-arch.mk
+++ b/debian/rules.d/2-binary-arch.mk
@@ -189,9 +189,6 @@  ifeq ($(arch),powerpc)
 endif
 	# Script to symlink everything up
 	$(SHELL) $(DROOT)/scripts/link-headers "$(hdrdir)" "$(basepkg)" "$*"
-	# Setup the proper asm symlink
-	rm -f $(hdrdir)/include/asm
-	(cd $(hdrdir)/include; ln -s asm-generic asm)
 	# The build symlink
 	install -d debian/$(basepkg)-$*/lib/modules/$(abi_release)-$*
 	ln -s /usr/src/$(basepkg)-$* \