Message ID | Pine.LNX.4.64.0812211638550.9555@pc-004.diku.dk |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Julia Lawall <julia@diku.dk> writes: > arg is checked not to be NULL a few lines before. > > A simplified version of the semantic patch that makes this change is as > follows: (http://www.emn.fr/x-info/coccinelle/) > --- > drivers/net/wan/pc300_drv.c | 5 ++--- Impressive. Thanks.
From: Julia Lawall <julia@diku.dk> Date: Sun, 21 Dec 2008 16:39:15 +0100 (CET) > arg is checked not to be NULL a few lines before. Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wan/pc300_drv.c b/drivers/net/wan/pc300_drv.c index d67957a..c23fde0 100644 --- a/drivers/net/wan/pc300_drv.c +++ b/drivers/net/wan/pc300_drv.c @@ -2718,9 +2718,8 @@ static int cpc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) } pc300patrntst.num_errors = falc_pattern_test_error(card, ch); - if (!arg - || copy_to_user(arg, &pc300patrntst, - sizeof (pc300patterntst_t))) + if (copy_to_user(arg, &pc300patrntst, + sizeof(pc300patterntst_t))) return -EINVAL; } else { falc_pattern_test(card, ch, pc300patrntst.patrntst_on);