Patchwork Add generic __builtin_bswap16 support

login
register
mail settings
Submitter Eric Botcazou
Date April 9, 2012, 9:43 p.m.
Message ID <201204092343.07387.ebotcazou@adacore.com>
Download mbox | patch
Permalink /patch/151480/
State New
Headers show

Comments

Eric Botcazou - April 9, 2012, 9:43 p.m.
Hi,

this adds generic support for __builtin_bswap16 (only PowerPC has it for now).  
It is mapped to the bswap optab in HImode, whose implementation is as follows:
 - if a bswaphi2 pattern is present (PowerPC), it is directly used; or else
 - if a rotlhi2/rotrhi2 pattern is present (x86), it is directly used, or else
 - if ashlxx2 & lshrxx2 are present (SPARC), they are used to open-code the 
operation, or else,
 - if a bswapsi2 pattern is present, it is used (with a final shift), otherwise
 - the bswapsi2 libcall is used (with a final shift).

Since it is expected that most architectures will fall into one of the first 3 
cases, no __bswaphi2 symbol is added to libgcc.  And pass_optimize_bswap isn't 
modified to recognize the builtin either, as this seems overkill to me.

Tested on x86, x86-64 and PowerPC Linux, OK for the mainline?


2012-04-09  Eric Botcazou  <ebotcazou@adacore.com>

	PR target/52624
	* doc/extend.texi (Other Builtins): Document __builtin_bswap16.
	(PowerPC AltiVec/VSX Built-in Functions): Remove it.
	* builtin-types.def (BT_UINT16): New primitive type.
	(BT_FN_UINT16_UINT16): New function type.
	* builtins.def (BUILT_IN_BSWAP16): New.
	* builtins.c (expand_builtin_bswap): Add TARGET_MODE argument.
	(expand_builtin) <BUILT_IN_BSWAP16>: New case.  Pass TARGET_MODE to
	expand_builtin_bswap.
	* optabs.c (expand_unop): Deal with bswap in HImode specially.  Add
	missing bits for bswap to libcall code.
	* tree.c (build_common_tree_nodes): Build uint16_type_node.
	* tree.h (enum tree_index): Add TI_UINT16_TYPE.
	(uint16_type_node): New define.
	* config/rs6000/rs6000-builtin.def (RS6000_BUILTIN_BSWAP_HI): Delete.
	* config/rs6000/rs6000.c (rs6000_expand_builtin): Remove handling of
	above builtin.
	(rs6000_init_builtins): Likewise.
	* config/rs6000/rs6000.md (bswaphi2): Add TARGET_POWERPC predicate.


2012-04-09  Eric Botcazou  <ebotcazou@adacore.com>

c-family/
	* c-common.h (uint16_type_node): Rename into...
	(c_uint16_type_node): ...this.
	* c-common.c (c_common_nodes_and_builtins): Adjust for above renaming.
	* c-cppbuiltin.c (builtin_define_stdint_macros): Likewise.


2012-04-09  Eric Botcazou  <ebotcazou@adacore.com>

testsuite/
	* gcc.dg/builtin-bswap-1.c: Test __builtin_bswap16 & __builtin_bswap64.
	* gcc.dg/builtin-bswap-4.c: Test __builtin_bswap16.
	* gcc.dg/builtin-bswap-5.c: Likewise.
	* gcc.target/i386/builtin-bswap-4.c: New test.
Richard Guenther - April 10, 2012, 10:54 a.m.
On Mon, Apr 9, 2012 at 11:43 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
> Hi,
>
> this adds generic support for __builtin_bswap16 (only PowerPC has it for now).
> It is mapped to the bswap optab in HImode, whose implementation is as follows:
>  - if a bswaphi2 pattern is present (PowerPC), it is directly used; or else
>  - if a rotlhi2/rotrhi2 pattern is present (x86), it is directly used, or else
>  - if ashlxx2 & lshrxx2 are present (SPARC), they are used to open-code the
> operation, or else,
>  - if a bswapsi2 pattern is present, it is used (with a final shift), otherwise
>  - the bswapsi2 libcall is used (with a final shift).
>
> Since it is expected that most architectures will fall into one of the first 3
> cases, no __bswaphi2 symbol is added to libgcc.  And pass_optimize_bswap isn't
> modified to recognize the builtin either, as this seems overkill to me.
>
> Tested on x86, x86-64 and PowerPC Linux, OK for the mainline?

Ok.

Thanks,
Richard.

>
> 2012-04-09  Eric Botcazou  <ebotcazou@adacore.com>
>
>        PR target/52624
>        * doc/extend.texi (Other Builtins): Document __builtin_bswap16.
>        (PowerPC AltiVec/VSX Built-in Functions): Remove it.
>        * builtin-types.def (BT_UINT16): New primitive type.
>        (BT_FN_UINT16_UINT16): New function type.
>        * builtins.def (BUILT_IN_BSWAP16): New.
>        * builtins.c (expand_builtin_bswap): Add TARGET_MODE argument.
>        (expand_builtin) <BUILT_IN_BSWAP16>: New case.  Pass TARGET_MODE to
>        expand_builtin_bswap.
>        * optabs.c (expand_unop): Deal with bswap in HImode specially.  Add
>        missing bits for bswap to libcall code.
>        * tree.c (build_common_tree_nodes): Build uint16_type_node.
>        * tree.h (enum tree_index): Add TI_UINT16_TYPE.
>        (uint16_type_node): New define.
>        * config/rs6000/rs6000-builtin.def (RS6000_BUILTIN_BSWAP_HI): Delete.
>        * config/rs6000/rs6000.c (rs6000_expand_builtin): Remove handling of
>        above builtin.
>        (rs6000_init_builtins): Likewise.
>        * config/rs6000/rs6000.md (bswaphi2): Add TARGET_POWERPC predicate.
>
>
> 2012-04-09  Eric Botcazou  <ebotcazou@adacore.com>
>
> c-family/
>        * c-common.h (uint16_type_node): Rename into...
>        (c_uint16_type_node): ...this.
>        * c-common.c (c_common_nodes_and_builtins): Adjust for above renaming.
>        * c-cppbuiltin.c (builtin_define_stdint_macros): Likewise.
>
>
> 2012-04-09  Eric Botcazou  <ebotcazou@adacore.com>
>
> testsuite/
>        * gcc.dg/builtin-bswap-1.c: Test __builtin_bswap16 & __builtin_bswap64.
>        * gcc.dg/builtin-bswap-4.c: Test __builtin_bswap16.
>        * gcc.dg/builtin-bswap-5.c: Likewise.
>        * gcc.target/i386/builtin-bswap-4.c: New test.
>
>
> --
> Eric Botcazou

Patch

Index: doc/extend.texi
===================================================================
--- doc/extend.texi	(revision 186176)
+++ doc/extend.texi	(working copy)
@@ -8535,12 +8535,17 @@  Similar to @code{__builtin_powi}, except
 are @code{long double}.
 @end deftypefn
 
-@deftypefn {Built-in Function} int32_t __builtin_bswap32 (int32_t x)
+@deftypefn {Built-in Function} int16_t __builtin_bswap16 (int16_t x)
 Returns @var{x} with the order of the bytes reversed; for example,
-@code{0xaabbccdd} becomes @code{0xddccbbaa}.  Byte here always means
+@code{0xaabb} becomes @code{0xbbaa}.  Byte here always means
 exactly 8 bits.
 @end deftypefn
 
+@deftypefn {Built-in Function} int32_t __builtin_bswap32 (int32_t x)
+Similar to @code{__builtin_bswap16}, except the argument and return types
+are 32-bit.
+@end deftypefn
+
 @deftypefn {Built-in Function} int64_t __builtin_bswap64 (int64_t x)
 Similar to @code{__builtin_bswap32}, except the argument and return types
 are 64-bit.
@@ -13426,7 +13431,6 @@  float __builtin_rsqrtf (float);
 double __builtin_recipdiv (double, double);
 double __builtin_rsqrt (double);
 long __builtin_bpermd (long, long);
-int __builtin_bswap16 (int);
 @end smallexample
 
 The @code{vec_rsqrt}, @code{__builtin_rsqrt}, and
Index: c-family/c-common.c
===================================================================
--- c-family/c-common.c	(revision 186176)
+++ c-family/c-common.c	(working copy)
@@ -4991,7 +4991,7 @@  c_common_nodes_and_builtins (void)
     uint8_type_node =
       TREE_TYPE (identifier_global_value (c_get_ident (UINT8_TYPE)));
   if (UINT16_TYPE)
-    uint16_type_node =
+    c_uint16_type_node =
       TREE_TYPE (identifier_global_value (c_get_ident (UINT16_TYPE)));
   if (UINT32_TYPE)
     c_uint32_type_node =
Index: c-family/c-common.h
===================================================================
--- c-family/c-common.h	(revision 186176)
+++ c-family/c-common.h	(working copy)
@@ -390,7 +390,7 @@  extern const unsigned int num_c_common_r
 #define int32_type_node			c_global_trees[CTI_INT32_TYPE]
 #define int64_type_node			c_global_trees[CTI_INT64_TYPE]
 #define uint8_type_node			c_global_trees[CTI_UINT8_TYPE]
-#define uint16_type_node		c_global_trees[CTI_UINT16_TYPE]
+#define c_uint16_type_node		c_global_trees[CTI_UINT16_TYPE]
 #define c_uint32_type_node		c_global_trees[CTI_UINT32_TYPE]
 #define c_uint64_type_node		c_global_trees[CTI_UINT64_TYPE]
 #define int_least8_type_node		c_global_trees[CTI_INT_LEAST8_TYPE]
Index: c-family/c-cppbuiltin.c
===================================================================
--- c-family/c-cppbuiltin.c	(revision 186176)
+++ c-family/c-cppbuiltin.c	(working copy)
@@ -448,8 +448,8 @@  builtin_define_stdint_macros (void)
     builtin_define_type_max ("__INT64_MAX__", int64_type_node);
   if (uint8_type_node)
     builtin_define_type_max ("__UINT8_MAX__", uint8_type_node);
-  if (uint16_type_node)
-    builtin_define_type_max ("__UINT16_MAX__", uint16_type_node);
+  if (c_uint16_type_node)
+    builtin_define_type_max ("__UINT16_MAX__", c_uint16_type_node);
   if (c_uint32_type_node)
     builtin_define_type_max ("__UINT32_MAX__", c_uint32_type_node);
   if (c_uint64_type_node)
Index: optabs.c
===================================================================
--- optabs.c	(revision 186176)
+++ optabs.c	(working copy)
@@ -3030,6 +3030,47 @@  expand_unop (enum machine_mode mode, opt
   /* Widening (or narrowing) bswap needs special treatment.  */
   if (unoptab == bswap_optab)
     {
+      /* HImode is special because in this mode BSWAP is equivalent to ROTATE
+	 or ROTATERT.  First try these directly; if this fails, then try the
+	 obvious pair of shifts with allowed widening, as this will probably
+	 be always more efficient than the other fallback methods.  */
+      if (mode == HImode)
+	{
+	  rtx last, temp1, temp2;
+
+	  if (optab_handler (rotl_optab, mode) != CODE_FOR_nothing)
+	    {
+	      temp = expand_binop (mode, rotl_optab, op0, GEN_INT (8), target,
+				   unsignedp, OPTAB_DIRECT);
+	      if (temp)
+		return temp;
+	     }
+
+	  if (optab_handler (rotr_optab, mode) != CODE_FOR_nothing)
+	    {
+	      temp = expand_binop (mode, rotr_optab, op0, GEN_INT (8), target,
+				   unsignedp, OPTAB_DIRECT);
+	      if (temp)
+		return temp;
+	    }
+
+	  last = get_last_insn ();
+
+	  temp1 = expand_binop (mode, ashl_optab, op0, GEN_INT (8), NULL_RTX,
+			        unsignedp, OPTAB_WIDEN);
+	  temp2 = expand_binop (mode, lshr_optab, op0, GEN_INT (8), NULL_RTX,
+			        unsignedp, OPTAB_WIDEN);
+	  if (temp1 && temp2)
+	    {
+	      temp = expand_binop (mode, ior_optab, temp1, temp2, target,
+				   unsignedp, OPTAB_WIDEN);
+	      if (temp)
+		return temp;
+	    }
+
+	  delete_insns_since (last);
+	}
+
       temp = widen_bswap (mode, op0, target);
       if (temp)
 	return temp;
@@ -3222,10 +3263,10 @@  expand_unop (enum machine_mode mode, opt
 	      /* For certain operations, we need not actually extend
 		 the narrow operand, as long as we will truncate the
 		 results to the same narrowness.  */
-
 	      xop0 = widen_operand (xop0, wider_mode, mode, unsignedp,
 				    (unoptab == neg_optab
-				     || unoptab == one_cmpl_optab)
+				     || unoptab == one_cmpl_optab
+				     || unoptab == bswap_optab)
 				    && mclass == MODE_INT);
 
 	      temp = expand_unop (wider_mode, unoptab, xop0, NULL_RTX,
@@ -3240,6 +3281,20 @@  expand_unop (enum machine_mode mode, opt
 					      - GET_MODE_PRECISION (mode)),
 				     target, true, OPTAB_DIRECT);
 
+	      /* Likewise for bswap.  */
+	      if (unoptab == bswap_optab && temp != 0)
+		{
+		  gcc_assert (GET_MODE_PRECISION (wider_mode)
+			      == GET_MODE_BITSIZE (wider_mode)
+			      && GET_MODE_PRECISION (mode)
+				 == GET_MODE_BITSIZE (mode));
+
+		  temp = expand_shift (RSHIFT_EXPR, wider_mode, temp,
+				       GET_MODE_BITSIZE (wider_mode)
+				       - GET_MODE_BITSIZE (mode),
+				       NULL_RTX, true);
+		}
+
 	      if (temp)
 		{
 		  if (mclass != MODE_INT)
Index: tree.c
===================================================================
--- tree.c	(revision 186176)
+++ tree.c	(working copy)
@@ -9388,6 +9388,7 @@  build_common_tree_nodes (bool signed_cha
   integer_ptr_type_node = build_pointer_type (integer_type_node);
 
   /* Fixed size integer types.  */
+  uint16_type_node = build_nonstandard_integer_type (16, true);
   uint32_type_node = build_nonstandard_integer_type (32, true);
   uint64_type_node = build_nonstandard_integer_type (64, true);
 
Index: tree.h
===================================================================
--- tree.h	(revision 186176)
+++ tree.h	(working copy)
@@ -3747,6 +3747,7 @@  enum tree_index
   TI_UINTDI_TYPE,
   TI_UINTTI_TYPE,
 
+  TI_UINT16_TYPE,
   TI_UINT32_TYPE,
   TI_UINT64_TYPE,
 
@@ -3902,6 +3903,7 @@  extern GTY(()) tree global_trees[TI_MAX]
 #define unsigned_intDI_type_node	global_trees[TI_UINTDI_TYPE]
 #define unsigned_intTI_type_node	global_trees[TI_UINTTI_TYPE]
 
+#define uint16_type_node		global_trees[TI_UINT16_TYPE]
 #define uint32_type_node		global_trees[TI_UINT32_TYPE]
 #define uint64_type_node		global_trees[TI_UINT64_TYPE]
 
Index: builtins.c
===================================================================
--- builtins.c	(revision 186176)
+++ builtins.c	(working copy)
@@ -4626,13 +4626,15 @@  expand_builtin_alloca (tree exp, bool ca
   return result;
 }
 
-/* Expand a call to a bswap builtin with argument ARG0.  MODE
-   is the mode to expand with.  */
+/* Expand a call to bswap builtin in EXP.
+   Return NULL_RTX if a normal call should be emitted rather than expanding the
+   function in-line.  If convenient, the result should be placed in TARGET.
+   SUBTARGET may be used as the target for computing one of EXP's operands.  */
 
 static rtx
-expand_builtin_bswap (tree exp, rtx target, rtx subtarget)
+expand_builtin_bswap (enum machine_mode target_mode, tree exp, rtx target,
+		      rtx subtarget)
 {
-  enum machine_mode mode;
   tree arg;
   rtx op0;
 
@@ -4640,14 +4642,18 @@  expand_builtin_bswap (tree exp, rtx targ
     return NULL_RTX;
 
   arg = CALL_EXPR_ARG (exp, 0);
-  mode = TYPE_MODE (TREE_TYPE (arg));
-  op0 = expand_expr (arg, subtarget, VOIDmode, EXPAND_NORMAL);
+  op0 = expand_expr (arg,
+		     subtarget && GET_MODE (subtarget) == target_mode
+		     ? subtarget : NULL_RTX,
+		     target_mode, EXPAND_NORMAL);
+  if (GET_MODE (op0) != target_mode)
+    op0 = convert_to_mode (target_mode, op0, 1);
 
-  target = expand_unop (mode, bswap_optab, op0, target, 1);
+  target = expand_unop (target_mode, bswap_optab, op0, target, 1);
 
   gcc_assert (target);
 
-  return convert_to_mode (mode, target, 0);
+  return convert_to_mode (target_mode, target, 1);
 }
 
 /* Expand a call to a unary builtin in EXP.
@@ -6077,10 +6083,10 @@  expand_builtin (tree exp, rtx target, rt
       expand_stack_restore (CALL_EXPR_ARG (exp, 0));
       return const0_rtx;
 
+    case BUILT_IN_BSWAP16:
     case BUILT_IN_BSWAP32:
     case BUILT_IN_BSWAP64:
-      target = expand_builtin_bswap (exp, target, subtarget);
-
+      target = expand_builtin_bswap (target_mode, exp, target, subtarget);
       if (target)
 	return target;
       break;
Index: testsuite/gcc.target/i386/builtin-bswap-4.c
===================================================================
--- testsuite/gcc.target/i386/builtin-bswap-4.c	(revision 0)
+++ testsuite/gcc.target/i386/builtin-bswap-4.c	(revision 0)
@@ -0,0 +1,8 @@ 
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+/* { dg-final { scan-assembler-not "bswap\[ \t\]" } } */
+
+short foo (short x)
+{
+  return __builtin_bswap16 (x);
+}
Index: testsuite/gcc.dg/builtin-bswap-4.c
===================================================================
--- testsuite/gcc.dg/builtin-bswap-4.c	(revision 186176)
+++ testsuite/gcc.dg/builtin-bswap-4.c	(working copy)
@@ -16,11 +16,19 @@ 
     return result;							\
   }									\
 
+MAKE_FUN(16, uint16_t);
 MAKE_FUN(32, uint32_t);
 MAKE_FUN(64, uint64_t);
 
 extern void abort (void);
 
+#define NUMS16					\
+  {						\
+    0x0000,					\
+    0x1122,					\
+    0xffff,					\
+  }
+
 #define NUMS32					\
   {						\
     0x00000000UL,				\
@@ -35,6 +43,9 @@  extern void abort (void);
     0xffffffffffffffffULL,			\
   }
 
+uint16_t uint16_ts[] =
+  NUMS16;
+
 uint32_t uint32_ts[] =
   NUMS32;
 
@@ -48,6 +59,10 @@  main (void)
 {
   int i;
 
+  for (i = 0; i < N(uint16_ts); i++)
+    if (__builtin_bswap16 (uint16_ts[i]) != my_bswap16 (uint16_ts[i]))
+      abort ();
+
   for (i = 0; i < N(uint32_ts); i++)
     if (__builtin_bswap32 (uint32_ts[i]) != my_bswap32 (uint32_ts[i]))
       abort ();
Index: testsuite/gcc.dg/builtin-bswap-1.c
===================================================================
--- testsuite/gcc.dg/builtin-bswap-1.c	(revision 186176)
+++ testsuite/gcc.dg/builtin-bswap-1.c	(working copy)
@@ -5,11 +5,29 @@ 
 
 #include <stdint.h>
 
-uint32_t foo (uint32_t a)
+uint16_t foo16 (uint16_t a)
 {
-  int b;
+  uint16_t b;
+
+  b = __builtin_bswap16 (a);
+
+  return b;
+}
+
+uint32_t foo32 (uint32_t a)
+{
+  uint32_t b;
 
   b = __builtin_bswap32 (a);
 
   return b;
 }
+
+uint64_t foo64 (uint64_t a)
+{
+  uint64_t b;
+
+  b = __builtin_bswap64 (a);
+
+  return b;
+}
Index: testsuite/gcc.dg/builtin-bswap-5.c
===================================================================
--- testsuite/gcc.dg/builtin-bswap-5.c	(revision 186176)
+++ testsuite/gcc.dg/builtin-bswap-5.c	(working copy)
@@ -6,6 +6,9 @@  main (void)
   /* Test constant folding.  */
   extern void link_error (void);
 
+  if (__builtin_bswap16(0xaabb) != 0xbbaa)
+    link_error ();
+
   if (__builtin_bswap32(0xaabbccdd) != 0xddccbbaa)
     link_error ();
 
Index: builtin-types.def
===================================================================
--- builtin-types.def	(revision 186176)
+++ builtin-types.def	(working copy)
@@ -76,6 +76,7 @@  DEF_PRIMITIVE_TYPE (BT_INT128, int128_in
 DEF_PRIMITIVE_TYPE (BT_UINT128, int128_unsigned_type_node)
 DEF_PRIMITIVE_TYPE (BT_INTMAX, intmax_type_node)
 DEF_PRIMITIVE_TYPE (BT_UINTMAX, uintmax_type_node)
+DEF_PRIMITIVE_TYPE (BT_UINT16, uint16_type_node)
 DEF_PRIMITIVE_TYPE (BT_UINT32, uint32_type_node)
 DEF_PRIMITIVE_TYPE (BT_UINT64, uint64_type_node)
 DEF_PRIMITIVE_TYPE (BT_WORD, (*lang_hooks.types.type_for_mode) (word_mode, 1))
@@ -226,6 +227,7 @@  DEF_FUNCTION_TYPE_1 (BT_FN_VOID_PTRPTR,
 DEF_FUNCTION_TYPE_1 (BT_FN_UINT_UINT, BT_UINT, BT_UINT)
 DEF_FUNCTION_TYPE_1 (BT_FN_ULONG_ULONG, BT_ULONG, BT_ULONG)
 DEF_FUNCTION_TYPE_1 (BT_FN_ULONGLONG_ULONGLONG, BT_ULONGLONG, BT_ULONGLONG)
+DEF_FUNCTION_TYPE_1 (BT_FN_UINT16_UINT16, BT_UINT16, BT_UINT16)
 DEF_FUNCTION_TYPE_1 (BT_FN_UINT32_UINT32, BT_UINT32, BT_UINT32)
 DEF_FUNCTION_TYPE_1 (BT_FN_UINT64_UINT64, BT_UINT64, BT_UINT64)
 
Index: builtins.def
===================================================================
--- builtins.def	(revision 186176)
+++ builtins.def	(working copy)
@@ -628,6 +628,7 @@  DEF_GCC_BUILTIN        (BUILT_IN_AGGREGA
 DEF_EXT_LIB_BUILTIN    (BUILT_IN_ALLOCA, "alloca", BT_FN_PTR_SIZE, ATTR_MALLOC_NOTHROW_LEAF_LIST)
 DEF_GCC_BUILTIN        (BUILT_IN_APPLY, "apply", BT_FN_PTR_PTR_FN_VOID_VAR_PTR_SIZE, ATTR_NULL)
 DEF_GCC_BUILTIN        (BUILT_IN_APPLY_ARGS, "apply_args", BT_FN_PTR_VAR, ATTR_LEAF_LIST)
+DEF_GCC_BUILTIN        (BUILT_IN_BSWAP16, "bswap16", BT_FN_UINT16_UINT16, ATTR_CONST_NOTHROW_LEAF_LIST)
 DEF_GCC_BUILTIN        (BUILT_IN_BSWAP32, "bswap32", BT_FN_UINT32_UINT32, ATTR_CONST_NOTHROW_LEAF_LIST)
 DEF_GCC_BUILTIN        (BUILT_IN_BSWAP64, "bswap64", BT_FN_UINT64_UINT64, ATTR_CONST_NOTHROW_LEAF_LIST)
 DEF_EXT_LIB_BUILTIN    (BUILT_IN_CLEAR_CACHE, "__clear_cache", BT_FN_VOID_PTR_PTR, ATTR_NOTHROW_LEAF_LIST)
Index: config/rs6000/rs6000-builtin.def
===================================================================
--- config/rs6000/rs6000-builtin.def	(revision 186176)
+++ config/rs6000/rs6000-builtin.def	(working copy)
@@ -1430,9 +1430,6 @@  BU_SPECIAL_X (RS6000_BUILTIN_RSQRT, "__b
 BU_SPECIAL_X (RS6000_BUILTIN_RSQRTF, "__builtin_rsqrtf", RS6000_BTM_FRSQRTES,
 	      RS6000_BTC_FP)
 
-BU_SPECIAL_X (RS6000_BUILTIN_BSWAP_HI, "__builtin_bswap16", RS6000_BTM_POWERPC,
-	      RS6000_BTC_MEM)
-
 /* Darwin CfString builtin.  */
 BU_SPECIAL_X (RS6000_BUILTIN_CFSTRING, "__builtin_cfstring", RS6000_BTM_POWERPC,
 	      RS6000_BTC_MISC)
Index: config/rs6000/rs6000.c
===================================================================
--- config/rs6000/rs6000.c	(revision 186176)
+++ config/rs6000/rs6000.c	(working copy)
@@ -11381,9 +11381,6 @@  rs6000_expand_builtin (tree exp, rtx tar
     case RS6000_BUILTIN_RSQRT:
       return rs6000_expand_unop_builtin (CODE_FOR_rsqrtdf2, exp, target);
 
-    case RS6000_BUILTIN_BSWAP_HI:
-      return rs6000_expand_unop_builtin (CODE_FOR_bswaphi2, exp, target);
-
     case POWER7_BUILTIN_BPERMD:
       return rs6000_expand_binop_builtin (((TARGET_64BIT)
 					   ? CODE_FOR_bpermd_di
@@ -11673,12 +11670,6 @@  rs6000_init_builtins (void)
 				 POWER7_BUILTIN_BPERMD, "__builtin_bpermd");
   def_builtin ("__builtin_bpermd", ftype, POWER7_BUILTIN_BPERMD);
 
-      /* Don't use builtin_function_type here, as it maps HI/QI to SI.  */
-  ftype = build_function_type_list (unsigned_intHI_type_node,
-				    unsigned_intHI_type_node,
-				    NULL_TREE);
-  def_builtin ("__builtin_bswap16", ftype, RS6000_BUILTIN_BSWAP_HI);
-
 #if TARGET_XCOFF
   /* AIX libm provides clog as __clog.  */
   if ((tdecl = builtin_decl_explicit (BUILT_IN_CLOG)) != NULL_TREE)
Index: config/rs6000/rs6000.md
===================================================================
--- config/rs6000/rs6000.md	(revision 186176)
+++ config/rs6000/rs6000.md	(working copy)
@@ -2386,7 +2386,7 @@  (define_expand "bswaphi2"
 		   (bswap:HI
 		    (match_operand:HI 1 "reg_or_mem_operand" "")))
 	      (clobber (match_scratch:SI 2 ""))])]
-  ""
+  "TARGET_POWERPC"
 {
   if (!REG_P (operands[0]) && !REG_P (operands[1]))
     operands[1] = force_reg (HImode, operands[1]);