Patchwork qlge: ql_adapter_down() typo

login
register
mail settings
Submitter roel kluin
Date Dec. 21, 2008, 3:28 p.m.
Message ID <494E609E.3090808@gmail.com>
Download mbox | patch
Permalink /patch/15146/
State Accepted
Delegated to: David Miller
Headers show

Comments

roel kluin - Dec. 21, 2008, 3:28 p.m.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ron Mercer - Dec. 22, 2008, 4:55 p.m.
Thanks Roel

Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>

On Sun, Dec 21, 2008 at 07:28:30AM -0800, Roel Kluin wrote:
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
> index b83a9c9..4a66aa5 100644
> --- a/drivers/net/qlge/qlge_main.c
> +++ b/drivers/net/qlge/qlge_main.c
> @@ -3156,7 +3156,7 @@ static int ql_adapter_down(struct ql_adapter *qdev)
>  	 * a workqueue only if it's a single interrupt
>  	 * environment (MSI/Legacy).
>  	 */
> -	for (i = 1; i > qdev->rx_ring_count; i++) {
> +	for (i = 1; i < qdev->rx_ring_count; i++) {
>  		rx_ring = &qdev->rx_ring[i];
>  		/* Only the RSS rings use NAPI on multi irq
>  		 * environment.  Outbound completion processing
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Dec. 26, 2008, 1:24 a.m.
From: Ron Mercer <ron.mercer@qlogic.com>
Date: Mon, 22 Dec 2008 08:55:07 -0800

> Thanks Roel
> 
> Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
index b83a9c9..4a66aa5 100644
--- a/drivers/net/qlge/qlge_main.c
+++ b/drivers/net/qlge/qlge_main.c
@@ -3156,7 +3156,7 @@  static int ql_adapter_down(struct ql_adapter *qdev)
 	 * a workqueue only if it's a single interrupt
 	 * environment (MSI/Legacy).
 	 */
-	for (i = 1; i > qdev->rx_ring_count; i++) {
+	for (i = 1; i < qdev->rx_ring_count; i++) {
 		rx_ring = &qdev->rx_ring[i];
 		/* Only the RSS rings use NAPI on multi irq
 		 * environment.  Outbound completion processing