From patchwork Fri Apr 6 16:35:02 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Riku Voipio X-Patchwork-Id: 151268 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6456AB7099 for ; Sat, 7 Apr 2012 06:23:24 +1000 (EST) Received: from localhost ([::1]:33661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SGEUb-0007aC-Jm for incoming@patchwork.ozlabs.org; Fri, 06 Apr 2012 15:06:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SGCGm-00049r-4z for qemu-devel@nongnu.org; Fri, 06 Apr 2012 12:44:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SGCGk-0006fx-Dh for qemu-devel@nongnu.org; Fri, 06 Apr 2012 12:44:15 -0400 Received: from afflict.kos.to ([92.243.29.197]:59826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SGC88-0004wL-Fv for qemu-devel@nongnu.org; Fri, 06 Apr 2012 12:35:20 -0400 Received: by afflict.kos.to (Postfix, from userid 1000) id 7269A2652C; Fri, 6 Apr 2012 16:35:17 +0000 (UTC) From: riku.voipio@linaro.org To: qemu-devel@nongnu.org Date: Fri, 6 Apr 2012 19:35:02 +0300 Message-Id: <84803b87a183bd71963584c3be5ca838d32c55df.1333729958.git.riku.voipio@linaro.org> X-Mailer: git-send-email 1.7.1 In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 92.243.29.197 X-Mailman-Approved-At: Fri, 06 Apr 2012 15:05:48 -0400 Cc: Fabio Erculiani Subject: [Qemu-devel] [PATCH 02/17] linux-user: target_argv is placed on ts->bprm->argv and can't be freed() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Fabio Erculiani TaskState contains linux_bprm struct which encapsulates argv among other things. argv might be used around the code and is expected to contain valid data. Before this patch, ts->bprm->argv was NULL due to it being freed right after loader_exec(). Signed-off-by: Fabio Erculiani Acked-by: Alexander Graf Signed-off-by: Alexander Graf Signed-off-by: Riku Voipio --- linux-user/main.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 962677e..2570140 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -3486,11 +3486,6 @@ int main(int argc, char **argv, char **envp) _exit(1); } - for (i = 0; i < target_argc; i++) { - free(target_argv[i]); - } - free(target_argv); - for (wrk = target_environ; *wrk; wrk++) { free(*wrk); }