Patchwork [v2,1/5] target-ppc: Drop cpu_ppc_close()

login
register
mail settings
Submitter Andreas Färber
Date April 6, 2012, 4:17 p.m.
Message ID <1333729032-24441-3-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/151215/
State New
Headers show

Comments

Andreas Färber - April 6, 2012, 4:17 p.m.
It is unused, so avoid QOM'ifying it unneededly.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 target-ppc/cpu.h    |    1 -
 target-ppc/helper.c |    6 ------
 2 files changed, 0 insertions(+), 7 deletions(-)
David Gibson - April 9, 2012, 10:44 p.m.
On Fri, Apr 06, 2012 at 06:17:08PM +0200, Andreas Färber wrote:
> It is unused, so avoid QOM'ifying it unneededly.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Acked-by: David Gibson <david@gibson.dropbear.id.au>
Andreas Färber - April 13, 2012, 10:14 p.m.
Am 10.04.2012 00:44, schrieb David Gibson:
> On Fri, Apr 06, 2012 at 06:17:08PM +0200, Andreas Färber wrote:
>> It is unused, so avoid QOM'ifying it unneededly.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
> 
> Acked-by: David Gibson <david@gibson.dropbear.id.au>

Thanks, applied to ppc-next:
http://repo.or.cz/w/qemu/agraf.git/shortlog/refs/heads/ppc-next

Andreas

Patch

diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
index ca6f1cb..fc70644 100644
--- a/target-ppc/cpu.h
+++ b/target-ppc/cpu.h
@@ -1100,7 +1100,6 @@  struct mmu_ctx_t {
 CPUPPCState *cpu_ppc_init (const char *cpu_model);
 void ppc_translate_init(void);
 int cpu_ppc_exec (CPUPPCState *s);
-void cpu_ppc_close (CPUPPCState *s);
 /* you can call this signal handler from your SIGBUS and SIGSEGV
    signal handlers to inform the virtual CPU of exceptions. non zero
    is returned if the signal was handled by the virtual CPU.  */
diff --git a/target-ppc/helper.c b/target-ppc/helper.c
index 39dcc27..4cd7b0f 100644
--- a/target-ppc/helper.c
+++ b/target-ppc/helper.c
@@ -3214,9 +3214,3 @@  CPUPPCState *cpu_ppc_init (const char *cpu_model)
 
     return env;
 }
-
-void cpu_ppc_close (CPUPPCState *env)
-{
-    /* Should also remove all opcode tables... */
-    g_free(env);
-}