Patchwork [1/2] qemu/x86: Adapted qemu command line in readme file

login
register
mail settings
Submitter Stephan Hoffmann
Date April 6, 2012, 4:19 p.m.
Message ID <1333729180-18218-1-git-send-email-sho@relinux.de>
Download mbox | patch
Permalink /patch/151208/
State Rejected
Headers show

Comments

Stephan Hoffmann - April 6, 2012, 4:19 p.m.
Signed-off-by: Stephan Hoffmann <sho@reLinux.de>
---
 board/qemu/x86/readme.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Gustavo Zacarias - April 6, 2012, 4:45 p.m.
On 2012-04-06 13:19, Stephan Hoffmann wrote:


> -  qemu-system-i386 -M pc -kernel output/images/bzImage -drive
> file=output/images/rootfs.ext2,if=ide -append root=/dev/sda
> +  qemu-system-i386 -M pc -kernel images/bzImage -drive
> file=images/rootfs.ext2,if=ide -append root=/dev/sda

Why?
I don't think it's common for users to be in the output directory as 
their current working directory.
Regards.
Stephan Hoffmann - April 6, 2012, 5:03 p.m.
Am 06.04.2012 18:45, schrieb Gustavo Zacarias:
> On 2012-04-06 13:19, Stephan Hoffmann wrote:
>
>
>> -  qemu-system-i386 -M pc -kernel output/images/bzImage -drive
>> file=output/images/rootfs.ext2,if=ide -append root=/dev/sda
>> +  qemu-system-i386 -M pc -kernel images/bzImage -drive
>> file=images/rootfs.ext2,if=ide -append root=/dev/sda
>
> Why?
> I don't think it's common for users to be in the output directory as
> their current working directory.
No, of course not. I assume being in the directory where make was called in.
> Regards.
>
O.K., after further investigation I found out that this was caused by my
out-of-tree build taking the working directory as the output directory;-)

Kind regards

Stephan

Patch

diff --git a/board/qemu/x86/readme.txt b/board/qemu/x86/readme.txt
index 4ba6607..ae27428 100644
--- a/board/qemu/x86/readme.txt
+++ b/board/qemu/x86/readme.txt
@@ -1,5 +1,5 @@ 
 Run the emulation with:
 
-  qemu-system-i386 -M pc -kernel output/images/bzImage -drive file=output/images/rootfs.ext2,if=ide -append root=/dev/sda
+  qemu-system-i386 -M pc -kernel images/bzImage -drive file=images/rootfs.ext2,if=ide -append root=/dev/sda
 
 The login prompt will appear in the graphical window.