Patchwork [net-next,1/6] ethtool: Remove exception to the requirement of holding RTNL lock

login
register
mail settings
Submitter Ben Hutchings
Date April 6, 2012, 12:38 a.m.
Message ID <1333672729.2652.23.camel@bwh-desktop.uk.solarflarecom.com>
Download mbox | patch
Permalink /patch/151043/
State Accepted
Delegated to: David Miller
Headers show

Comments

Ben Hutchings - April 6, 2012, 12:38 a.m.
Commit e52ac3398c3d772d372b9b62ab408fd5eec96840 ('net: Use device
model to get driver name in skb_gso_segment()') removed the only
in-tree caller of ethtool ops that doesn't hold the RTNL lock.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
 include/linux/ethtool.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

Patch

diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index 560a247..89d68d8 100644
--- a/include/linux/ethtool.h
+++ b/include/linux/ethtool.h
@@ -923,8 +923,7 @@  static inline u32 ethtool_rxfh_indir_default(u32 index, u32 n_rx_rings)
  *
  * All operations are optional (i.e. the function pointer may be set
  * to %NULL) and callers must take this into account.  Callers must
- * hold the RTNL, except that for @get_drvinfo the caller may or may
- * not hold the RTNL.
+ * hold the RTNL lock.
  *
  * See the structures used by these operations for further documentation.
  *