Patchwork [12.04,no-up] ALSA: HDA: Remove quirk for Gigabyte GA-H61M-S2PV

login
register
mail settings
Submitter David Henningsson
Date April 5, 2012, 8:33 a.m.
Message ID <1333614798-8225-1-git-send-email-david.henningsson@canonical.com>
Download mbox | patch
Permalink /patch/150891/
State New
Headers show

Comments

David Henningsson - April 5, 2012, 8:33 a.m.
This model quirk causes codec parsing to fail for the bug reporter.
As a result, alsamixer cannot even be opened.

Verification: I have tested the changed code in hda-emu and then
the error disappears (and no new errors are appearing), and hda-emu
is a safe way to test/verify these types of errors.

Upstream: has already removed this model completely as part of a
bigger rewrite.

BugLink: https://bugs.launchpad.net/bugs/948360
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 sound/pci/hda/alc882_quirks.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Tim Gardner - April 5, 2012, 12:19 p.m.
I suggest "UBUNTU: SAUCE: (drop after 3.3)" in the subject.
Stefan Bader - April 5, 2012, 1:02 p.m.
On 05.04.2012 10:33, David Henningsson wrote:
> This model quirk causes codec parsing to fail for the bug reporter.
> As a result, alsamixer cannot even be opened.
> 
> Verification: I have tested the changed code in hda-emu and then
> the error disappears (and no new errors are appearing), and hda-emu
> is a safe way to test/verify these types of errors.
> 
> Upstream: has already removed this model completely as part of a
> bigger rewrite.
> 
> BugLink: https://bugs.launchpad.net/bugs/948360
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> ---
>  sound/pci/hda/alc882_quirks.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/pci/hda/alc882_quirks.c b/sound/pci/hda/alc882_quirks.c
> index 50f4cbd..42a0aeb 100644
> --- a/sound/pci/hda/alc882_quirks.c
> +++ b/sound/pci/hda/alc882_quirks.c
> @@ -2901,7 +2901,6 @@ static const struct snd_pci_quirk alc882_cfg_tbl[] = {
>  	SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", ALC883_LAPTOP_EAPD),
>  	SND_PCI_QUIRK(0x10f1, 0x2350, "TYAN-S2350", ALC888_6ST_DELL),
>  	SND_PCI_QUIRK(0x108e, 0x534d, NULL, ALC883_3ST_6ch),
> -	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte P35 DS3R", ALC882_6ST_DIG),
>  
>  	SND_PCI_QUIRK(0x1462, 0x0349, "MSI", ALC883_TARGA_2ch_DIG),
>  	SND_PCI_QUIRK(0x1462, 0x040d, "MSI", ALC883_TARGA_2ch_DIG),

Limited to a verifyable amount of hw and tested.
Leann Ogasawara - April 5, 2012, 1:40 p.m.
Applied to Precise master-next.  I amended the subject of the commit to
contain "UBUNTU: SAUCE: (drop after 3.3)".

Thanks,
Leann

On Thu, 2012-04-05 at 10:33 +0200, David Henningsson wrote:
> This model quirk causes codec parsing to fail for the bug reporter.
> As a result, alsamixer cannot even be opened.
> 
> Verification: I have tested the changed code in hda-emu and then
> the error disappears (and no new errors are appearing), and hda-emu
> is a safe way to test/verify these types of errors.
> 
> Upstream: has already removed this model completely as part of a
> bigger rewrite.
> 
> BugLink: https://bugs.launchpad.net/bugs/948360
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> ---
>  sound/pci/hda/alc882_quirks.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/pci/hda/alc882_quirks.c b/sound/pci/hda/alc882_quirks.c
> index 50f4cbd..42a0aeb 100644
> --- a/sound/pci/hda/alc882_quirks.c
> +++ b/sound/pci/hda/alc882_quirks.c
> @@ -2901,7 +2901,6 @@ static const struct snd_pci_quirk alc882_cfg_tbl[] = {
>  	SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", ALC883_LAPTOP_EAPD),
>  	SND_PCI_QUIRK(0x10f1, 0x2350, "TYAN-S2350", ALC888_6ST_DELL),
>  	SND_PCI_QUIRK(0x108e, 0x534d, NULL, ALC883_3ST_6ch),
> -	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte P35 DS3R", ALC882_6ST_DIG),
>  
>  	SND_PCI_QUIRK(0x1462, 0x0349, "MSI", ALC883_TARGA_2ch_DIG),
>  	SND_PCI_QUIRK(0x1462, 0x040d, "MSI", ALC883_TARGA_2ch_DIG),
> -- 
> 1.7.9.1
> 
>

Patch

diff --git a/sound/pci/hda/alc882_quirks.c b/sound/pci/hda/alc882_quirks.c
index 50f4cbd..42a0aeb 100644
--- a/sound/pci/hda/alc882_quirks.c
+++ b/sound/pci/hda/alc882_quirks.c
@@ -2901,7 +2901,6 @@  static const struct snd_pci_quirk alc882_cfg_tbl[] = {
 	SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", ALC883_LAPTOP_EAPD),
 	SND_PCI_QUIRK(0x10f1, 0x2350, "TYAN-S2350", ALC888_6ST_DELL),
 	SND_PCI_QUIRK(0x108e, 0x534d, NULL, ALC883_3ST_6ch),
-	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte P35 DS3R", ALC882_6ST_DIG),
 
 	SND_PCI_QUIRK(0x1462, 0x0349, "MSI", ALC883_TARGA_2ch_DIG),
 	SND_PCI_QUIRK(0x1462, 0x040d, "MSI", ALC883_TARGA_2ch_DIG),