From patchwork Wed Apr 4 15:30:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 150845 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BA9ECB700A for ; Thu, 5 Apr 2012 13:01:27 +1000 (EST) Received: from localhost ([::1]:42261 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFSBx-00083Q-0v for incoming@patchwork.ozlabs.org; Wed, 04 Apr 2012 11:32:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFSBM-0006eU-Qt for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:31:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFSBF-0005DQ-6N for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:31:35 -0400 Received: from mnementh.archaic.org.uk ([81.2.115.146]:39290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFSBE-00059h-R2 for qemu-devel@nongnu.org; Wed, 04 Apr 2012 11:31:29 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1SFSAo-0003IM-Qm; Wed, 04 Apr 2012 16:31:02 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Wed, 4 Apr 2012 16:30:53 +0100 Message-Id: <1333553462-12633-5-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1333553462-12633-1-git-send-email-peter.maydell@linaro.org> References: <1333553462-12633-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 81.2.115.146 Cc: Paul Brook , Evgeny Voevodin , patches@linaro.org Subject: [Qemu-devel] [PATCH 04/13] arm_gic: Make the GIC its own sysbus device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Compile arm_gic.c as a standalone C file to produce a self contained sysbus GIC device. Support the legacy usage by #include of the .c file by making those users #define LEGACY_INCLUDED_GIC, so we can convert them one by one. Signed-off-by: Peter Maydell Reviewed-by: Evgeny Voevodin --- Makefile.target | 1 + hw/a15mpcore.c | 1 + hw/a9mpcore.c | 1 + hw/arm11mpcore.c | 1 + hw/arm_gic.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++- hw/armv7m_nvic.c | 1 + hw/exynos4210_gic.c | 1 + hw/realview_gic.c | 1 + 8 files changed, 57 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target index cff15f0..0d605d8 100644 --- a/Makefile.target +++ b/Makefile.target @@ -364,6 +364,7 @@ obj-arm-y += cadence_uart.o obj-arm-y += cadence_ttc.o obj-arm-y += cadence_gem.o obj-arm-y += xilinx_zynq.o zynq_slcr.o +obj-arm-y += arm_gic.o obj-arm-y += realview_gic.o realview.o arm_sysctl.o arm11mpcore.o a9mpcore.o obj-arm-y += exynos4210_gic.o exynos4210_combiner.o exynos4210.o obj-arm-y += exynos4_boards.o exynos4210_uart.o exynos4210_pwm.o diff --git a/hw/a15mpcore.c b/hw/a15mpcore.c index 2e2ed42..54c0dbf 100644 --- a/hw/a15mpcore.c +++ b/hw/a15mpcore.c @@ -20,6 +20,7 @@ #include "sysbus.h" +#define LEGACY_INCLUDED_GIC #include "arm_gic.c" /* A15MP private memory region. */ diff --git a/hw/a9mpcore.c b/hw/a9mpcore.c index 1d83c37..164a0d3 100644 --- a/hw/a9mpcore.c +++ b/hw/a9mpcore.c @@ -10,6 +10,7 @@ #include "sysbus.h" +#define LEGACY_INCLUDED_GIC #include "arm_gic.c" /* A9MP private memory region. */ diff --git a/hw/arm11mpcore.c b/hw/arm11mpcore.c index c4829d8..e876a0e 100644 --- a/hw/arm11mpcore.c +++ b/hw/arm11mpcore.c @@ -10,6 +10,7 @@ #include "sysbus.h" #include "qemu-timer.h" +#define LEGACY_INCLUDED_GIC #include "arm_gic.c" /* MPCore private memory region. */ diff --git a/hw/arm_gic.c b/hw/arm_gic.c index fabbcc5..b0b6ec5 100644 --- a/hw/arm_gic.c +++ b/hw/arm_gic.c @@ -11,6 +11,8 @@ controller, MPCore distributed interrupt controller and ARMv7-M Nested Vectored Interrupt Controller. */ +#include "sysbus.h" + /* Maximum number of possible interrupts, determined by the GIC architecture */ #define GIC_MAXIRQ 1020 /* First 32 are private to each CPU (SGIs and PPIs). */ @@ -112,7 +114,7 @@ typedef struct gic_state int current_pending[NCPU]; #if NCPU > 1 - int num_cpu; + uint32_t num_cpu; #endif MemoryRegion iomem; /* Distributor */ @@ -906,3 +908,50 @@ static void gic_init(gic_state *s, int num_irq) gic_reset(s); register_savevm(NULL, "arm_gic", -1, 2, gic_save, gic_load, s); } + +#ifndef LEGACY_INCLUDED_GIC + +static int arm_gic_init(SysBusDevice *dev) +{ + /* Device instance init function for the GIC sysbus device */ + int i; + gic_state *s = FROM_SYSBUS(gic_state, dev); + gic_init(s, s->num_cpu, s->num_irq); + /* Distributor */ + sysbus_init_mmio(dev, &s->iomem); + /* cpu interfaces (one for "current cpu" plus one per cpu) */ + for (i = 0; i <= NUM_CPU(s); i++) { + sysbus_init_mmio(dev, &s->cpuiomem[i]); + } + return 0; +} + +static Property arm_gic_properties[] = { + DEFINE_PROP_UINT32("num-cpu", gic_state, num_cpu, 1), + DEFINE_PROP_UINT32("num-irq", gic_state, num_irq, 32), +}; + +static void arm_gic_class_init(ObjectClass *klass, void *data) +{ + DeviceClass *dc = DEVICE_CLASS(klass); + SysBusDeviceClass *sbc = SYS_BUS_DEVICE_CLASS(klass); + sbc->init = arm_gic_init; + dc->props = arm_gic_properties; + dc->no_user = 1; +} + +static TypeInfo arm_gic_info = { + .name = "arm_gic", + .parent = TYPE_SYS_BUS_DEVICE, + .instance_size = sizeof(gic_state), + .class_init = arm_gic_class_init, +}; + +static void arm_gic_register_types(void) +{ + type_register_static(&arm_gic_info); +} + +type_init(arm_gic_register_types) + +#endif diff --git a/hw/armv7m_nvic.c b/hw/armv7m_nvic.c index 99ed85b..79cf448 100644 --- a/hw/armv7m_nvic.c +++ b/hw/armv7m_nvic.c @@ -16,6 +16,7 @@ #include "exec-memory.h" #define NVIC 1 +#define LEGACY_INCLUDED_GIC static uint32_t nvic_readl(void *opaque, uint32_t offset); static void nvic_writel(void *opaque, uint32_t offset, uint32_t value); diff --git a/hw/exynos4210_gic.c b/hw/exynos4210_gic.c index ff7ab84..a05dab2 100644 --- a/hw/exynos4210_gic.c +++ b/hw/exynos4210_gic.c @@ -262,6 +262,7 @@ uint32_t exynos4210_get_irq(uint32_t grp, uint32_t bit) /********* GIC part *********/ +#define LEGACY_INCLUDED_GIC #include "arm_gic.c" typedef struct { diff --git a/hw/realview_gic.c b/hw/realview_gic.c index aa780fe..a3b5a04 100644 --- a/hw/realview_gic.c +++ b/hw/realview_gic.c @@ -9,6 +9,7 @@ #include "sysbus.h" +#define LEGACY_INCLUDED_GIC #include "arm_gic.c" typedef struct {