| Message ID | 1333555395-12873-1-git-send-email-peter.maydell@linaro.org |
|---|---|
| State | New |
| Headers | show |
Am 04.04.2012 18:03, schrieb Peter Maydell: > Remove some useless uses of ARCH_CFLAGS -- this variable was never set > so will always be empty. The uses were accidental: in commit 0c439cbf8 > Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn > became QEMU_CFLAGS). However in commit be17dc90 a use of it was > reintroduced (apparently accidentally) by Michael S. Tsirkin, and then > I subsequently cut-n-pasted that into a number of other configure > feature tests. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Andreas Färber <afaerber@suse.de> Thanks, /-F
On Wed, Apr 04, 2012 at 05:03:15PM +0100, Peter Maydell wrote: > Remove some useless uses of ARCH_CFLAGS -- this variable was never set > so will always be empty. The uses were accidental: in commit 0c439cbf8 > Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn > became QEMU_CFLAGS). However in commit be17dc90 a use of it was > reintroduced (apparently accidentally) by Michael S. Tsirkin, and then > I subsequently cut-n-pasted that into a number of other configure > feature tests. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > configure | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan
Peter Maydell <peter.maydell@linaro.org> wrote: > Remove some useless uses of ARCH_CFLAGS -- this variable was never set > so will always be empty. The uses were accidental: in commit 0c439cbf8 > Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn > became QEMU_CFLAGS). However in commit be17dc90 a use of it was > reintroduced (apparently accidentally) by Michael S. Tsirkin, and then > I subsequently cut-n-pasted that into a number of other configure > feature tests. Reviewed-by: Juan Quintela <quintela@redhat.com>
diff --git a/configure b/configure index 4b3adc9..80a3e8d 100755 --- a/configure +++ b/configure @@ -2361,7 +2361,7 @@ int main(void) return 0; } EOF -if compile_prog "$ARCH_CFLAGS" "" ; then +if compile_prog "" "" ; then fallocate=yes fi @@ -2376,7 +2376,7 @@ int main(void) return 0; } EOF -if compile_prog "$ARCH_CFLAGS" "" ; then +if compile_prog "" "" ; then sync_file_range=yes fi @@ -2393,7 +2393,7 @@ int main(void) return 0; } EOF -if compile_prog "$ARCH_CFLAGS" "" ; then +if compile_prog "" "" ; then fiemap=yes fi @@ -2423,7 +2423,7 @@ int main(void) return 0; } EOF -if compile_prog "$ARCH_CFLAGS" "" ; then +if compile_prog "" "" ; then epoll=yes fi @@ -2446,7 +2446,7 @@ int main(void) return epoll_create1 == epoll_create1; } EOF -if compile_prog "$ARCH_CFLAGS" "" ; then +if compile_prog "" "" ; then epoll_create1=yes fi @@ -2460,7 +2460,7 @@ int main(void) return 0; } EOF -if compile_prog "$ARCH_CFLAGS" "" ; then +if compile_prog "" "" ; then epoll_pwait=yes fi
Remove some useless uses of ARCH_CFLAGS -- this variable was never set so will always be empty. The uses were accidental: in commit 0c439cbf8 Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn became QEMU_CFLAGS). However in commit be17dc90 a use of it was reintroduced (apparently accidentally) by Michael S. Tsirkin, and then I subsequently cut-n-pasted that into a number of other configure feature tests. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- configure | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)