diff mbox

[2/2] hw/exynos4210_combiner.c: Drop excessive read/write access check.

Message ID 1333521556-31662-3-git-send-email-e.voevodin@samsung.com
State New
Headers show

Commit Message

Evgeny Voevodin April 4, 2012, 6:39 a.m. UTC 
Access to reserved area at offset higher than 0x3c is allowed in
External Combiner. Samsung Galaxy Kernel implements this. So, drop
excessive checks in read/write functions.

Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
---
 hw/exynos4210_combiner.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

Comments

Peter Maydell April 4, 2012, 9:39 a.m. UTC | #1 
On 4 April 2012 07:39, Evgeny Voevodin <e.voevodin@samsung.com> wrote:
> Access to reserved area at offset higher than 0x3c is allowed in
> External Combiner. Samsung Galaxy Kernel implements this. So, drop
> excessive checks in read/write functions.
>
> Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM
diff mbox

Patch

diff --git a/hw/exynos4210_combiner.c b/hw/exynos4210_combiner.c
index 6110c19..80af22c 100644
--- a/hw/exynos4210_combiner.c
+++ b/hw/exynos4210_combiner.c
@@ -184,11 +184,6 @@  exynos4210_combiner_read(void *opaque, target_phys_addr_t offset, unsigned size)
     uint32_t reg_n;              /* Register number inside the quad */
     uint32_t val;
 
-    if (s->external && (offset > 0x3c && offset != 0x100)) {
-        hw_error("exynos4210.combiner: unallowed read access at offset 0x"
-                TARGET_FMT_plx "\n", offset);
-    }
-
     req_quad_base_n = offset >> 4;
     grp_quad_base_n = req_quad_base_n << 2;
     reg_n = (offset - (req_quad_base_n << 4)) >> 2;
@@ -281,11 +276,6 @@  static void exynos4210_combiner_write(void *opaque, target_phys_addr_t offset,
     uint32_t grp_quad_base_n;    /* Base of group quad */
     uint32_t reg_n;              /* Register number inside the quad */
 
-    if (s->external && (offset > 0x3c && offset != 0x100)) {
-        hw_error("exynos4210.combiner: unallowed write access at offset 0x"
-                TARGET_FMT_plx "\n", offset);
-    }
-
     req_quad_base_n = offset >> 4;
     grp_quad_base_n = req_quad_base_n << 2;
     reg_n = (offset - (req_quad_base_n << 4)) >> 2;