From patchwork Tue Apr 3 22:02:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 150557 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B9D98B6FEB for ; Wed, 4 Apr 2012 08:02:21 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755460Ab2DCWCT (ORCPT ); Tue, 3 Apr 2012 18:02:19 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:44646 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755408Ab2DCWCS (ORCPT ); Tue, 3 Apr 2012 18:02:18 -0400 Received: by wibhj6 with SMTP id hj6so4074096wib.1 for ; Tue, 03 Apr 2012 15:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; bh=hUkE10UV9+PujutPyUIZ0LXjHod8499P1ZZpVk7jXoY=; b=nNp9pPjc8ka2oT2107253yIjQdXNxSo7Pk+PNgJV9wCQzF0giqemfIBHW39T/I0hjv q86o/oPhAA6b5724OfRrsoPx2QIBw4uEYH0LdaN46aHhpUXh14vukG0Sf6sRKm7I3d4b Plg9mlnFzikOKX9r2dhaZgH5aW3ZGwoCLyR+qMmpYnDpTl8t/CIADjPsjQDp3eZbl7xK 18sPYQjRy3kj6uOewD+XNc9IsoSFh8+HtWTFqC+HRGfelrUOqto3IovHLSI6dTQaIcyC 2ZiDh9KH0MVcverxBZyMr0i58TxM3Zbs3a9rfHB5Y9D5VFBudOjnY1sSePC+sVYR3Dh0 el6A== Received: by 10.180.100.230 with SMTP id fb6mr18294983wib.3.1333490535074; Tue, 03 Apr 2012 15:02:15 -0700 (PDT) Received: from [172.28.131.171] ([74.125.122.49]) by mx.google.com with ESMTPS id ff9sm46246922wib.2.2012.04.03.15.02.12 (version=SSLv3 cipher=OTHER); Tue, 03 Apr 2012 15:02:13 -0700 (PDT) Subject: [PATCH] net: lpc_eth: no need to reserve 8 extra bytes in rx skb From: Eric Dumazet To: David Miller Cc: netdev , Roland Stigge Date: Wed, 04 Apr 2012 00:02:11 +0200 Message-ID: <1333490531.18626.336.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Probably a leftover from ancient code... Signed-off-by: Eric Dumazet Cc: Roland Stigge --- This was mentioned in one of my review but ignored/lost. drivers/net/ethernet/nxp/lpc_eth.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 6dfc26d..d3469d8 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c @@ -990,10 +990,10 @@ static int __lpc_handle_recv(struct net_device *ndev, int budget) ndev->stats.rx_errors++; } else { /* Packet is good */ - skb = dev_alloc_skb(len + 8); - if (!skb) + skb = dev_alloc_skb(len); + if (!skb) { ndev->stats.rx_dropped++; - else { + } else { prdbuf = skb_put(skb, len); /* Copy packet from buffer */