Patchwork [net-next] vxge: Remove unnecessary ; in do {} while (0) macro

login
register
mail settings
Submitter Joe Perches
Date April 3, 2012, 9:53 p.m.
Message ID <1333489992.2695.17.camel@joe2Laptop>
Download mbox | patch
Permalink /patch/150555/
State Accepted
Delegated to: David Miller
Headers show

Comments

Joe Perches - April 3, 2012, 9:53 p.m.
This macro doesn't need a terminating ; so just remove it.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/ethernet/neterion/vxge/vxge-main.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - April 3, 2012, 9:58 p.m.
From: Joe Perches <joe@perches.com>
Date: Tue, 03 Apr 2012 14:53:12 -0700

> This macro doesn't need a terminating ; so just remove it.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Applied, thanks Joe.

Longer term I'd much rather see this turned into an inline
function with proper type checking etc.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.h b/drivers/net/ethernet/neterion/vxge/vxge-main.h
index f52a42d..372406c 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-main.h
+++ b/drivers/net/ethernet/neterion/vxge/vxge-main.h
@@ -421,7 +421,7 @@  struct vxge_tx_priv {
 		timer.function = handle; \
 		timer.data = (unsigned long) arg; \
 		mod_timer(&timer, (jiffies + exp)); \
-	} while (0);
+	} while (0)
 
 void vxge_initialize_ethtool_ops(struct net_device *ndev);
 enum vxge_hw_status vxge_reset_all_vpaths(struct vxgedev *vdev);