Patchwork [2/3] ARM: mx28: Add SPI resources

login
register
mail settings
Submitter Fabio Estevam
Date April 3, 2012, 7:20 p.m.
Message ID <1333480807-10480-2-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/150532/
State New
Headers show

Comments

Fabio Estevam - April 3, 2012, 7:20 p.m.
Add SPI resources.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/mach-mxs/devices-mx28.h                |    4 +
 arch/arm/mach-mxs/devices/Kconfig               |    3 +
 arch/arm/mach-mxs/devices/Makefile              |    1 +
 arch/arm/mach-mxs/devices/platform-mxs-spi.c    |   74 +++++++++++++++++++++++
 arch/arm/mach-mxs/include/mach/devices-common.h |   11 ++++
 5 files changed, 93 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-mxs/devices/platform-mxs-spi.c
Jean-Paul - May 28, 2012, 7:25 a.m.
Hi Fabio Estevam,
 I have im28 evk board and I fallowed your instructions to add the SPI resources
in my kernel. I'm using the kernel 3.2.15. After rebuilding the kernel, I still
can not see the imx28 spi drivers. Im sorry to ask these beginner questions but
I'm new in using linux spi drivers.

 I checked at these locations:
     /sys/class/spidev   and    /sys/class/spi_master
I could not see any SPI device, it was just empty.

when I do: ls /sys/bus/spi/drivers
I can see:   enc28j60 , mc33880 , mmc_spi , and spidev

How can I create a device spi node since it looks like that i don't have spi
driver for the imx28 evk board?


Thanks for your help,
Jean-Paul
Fabio Estevam - May 28, 2012, 11:39 p.m.
Hi Jean-Paul,

On Mon, May 28, 2012 at 4:25 AM, Jean-Paul <alainsergenagni@yahoo.com> wrote:
>
> Hi Fabio Estevam,
>  I have im28 evk board and I fallowed your instructions to add the SPI resources
> in my kernel. I'm using the kernel 3.2.15. After rebuilding the kernel, I still
> can not see the imx28 spi drivers. Im sorry to ask these beginner questions but
> I'm new in using linux spi drivers.

On patch 3/3 I added the support for a SPI NOR flash.

>  I checked at these locations:
>     /sys/class/spidev   and    /sys/class/spi_master
> I could not see any SPI device, it was just empty.
>
> when I do: ls /sys/bus/spi/drivers
> I can see:   enc28j60 , mc33880 , mmc_spi , and spidev
>
> How can I create a device spi node since it looks like that i don't have spi
> driver for the imx28 evk board?

Make sure you added the mxs spi driver I posted in the spi list and
also that you selected it in .config.

I still need to add dt support for the mxs spi driver.

Regards,

Fabio Estevam

Patch

diff --git a/arch/arm/mach-mxs/devices-mx28.h b/arch/arm/mach-mxs/devices-mx28.h
index 9dbeae1..9b9206d 100644
--- a/arch/arm/mach-mxs/devices-mx28.h
+++ b/arch/arm/mach-mxs/devices-mx28.h
@@ -55,3 +55,7 @@  extern const struct mxs_saif_data mx28_saif_data[] __initconst;
 	mxs_add_saif(&mx28_saif_data[id], pdata)
 
 struct platform_device *__init mx28_add_rtc_stmp3xxx(void);
+
+extern const struct mxs_mxs_spi_data mx28_mxs_spi_data[] __initconst;
+#define mx28_add_mxs_spi(id) \
+		mxs_add_mxs_spi(&mx28_mxs_spi_data[id])
diff --git a/arch/arm/mach-mxs/devices/Kconfig b/arch/arm/mach-mxs/devices/Kconfig
index b8913df..8ba5fca 100644
--- a/arch/arm/mach-mxs/devices/Kconfig
+++ b/arch/arm/mach-mxs/devices/Kconfig
@@ -30,5 +30,8 @@  config MXS_HAVE_PLATFORM_MXSFB
 config MXS_HAVE_PLATFORM_MXS_SAIF
 	bool
 
+config MXS_HAVE_PLATFORM_MXS_SPI
+	bool
+
 config MXS_HAVE_PLATFORM_RTC_STMP3XXX
 	bool
diff --git a/arch/arm/mach-mxs/devices/Makefile b/arch/arm/mach-mxs/devices/Makefile
index c8f5c95..1664049 100644
--- a/arch/arm/mach-mxs/devices/Makefile
+++ b/arch/arm/mach-mxs/devices/Makefile
@@ -11,3 +11,4 @@  obj-y += platform-gpio-mxs.o
 obj-$(CONFIG_MXS_HAVE_PLATFORM_MXSFB) += platform-mxsfb.o
 obj-$(CONFIG_MXS_HAVE_PLATFORM_MXS_SAIF) += platform-mxs-saif.o
 obj-$(CONFIG_MXS_HAVE_PLATFORM_RTC_STMP3XXX) += platform-rtc-stmp3xxx.o
+obj-$(CONFIG_MXS_HAVE_PLATFORM_MXS_SPI) += platform-mxs-spi.o
diff --git a/arch/arm/mach-mxs/devices/platform-mxs-spi.c b/arch/arm/mach-mxs/devices/platform-mxs-spi.c
new file mode 100644
index 0000000..b9e78d3
--- /dev/null
+++ b/arch/arm/mach-mxs/devices/platform-mxs-spi.c
@@ -0,0 +1,74 @@ 
+/*
+ * Copyright (C) 2010 Pengutronix
+ * Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>
+ *
+ * Copyright 2011 Freescale Semiconductor, Inc. All Rights Reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify it under
+ * the terms of the GNU General Public License version 2 as published by the
+ * Free Software Foundation.
+ */
+
+#include <linux/compiler.h>
+#include <linux/err.h>
+#include <linux/init.h>
+
+#include <mach/mx23.h>
+#include <mach/mx28.h>
+#include <mach/devices-common.h>
+
+#define mxs_mxs_spi_data_entry_single(soc, _id, hwid)			\
+	{								\
+		.id = _id,						\
+		.iobase = soc ## _SSP ## hwid ## _BASE_ADDR,		\
+		.dma = soc ## _DMA_SSP ## hwid,				\
+		.irq_err = soc ## _INT_SSP ## hwid ## _ERROR,		\
+		.irq_dma = soc ## _INT_SSP ## hwid ## _DMA,		\
+	}
+
+#define mxs_mxs_spi_data_entry(soc, _id, hwid)				\
+	[_id] = mxs_mxs_spi_data_entry_single(soc, _id, hwid)
+
+
+#ifdef CONFIG_SOC_IMX23
+const struct mxs_mxs_spi_data mx23_mxs_spi_data[] __initconst = {
+	mxs_mxs_spi_data_entry(MX23, 0, 1),
+	mxs_mxs_spi_data_entry(MX23, 1, 2),
+};
+#endif
+
+#ifdef CONFIG_SOC_IMX28
+const struct mxs_mxs_spi_data mx28_mxs_spi_data[] __initconst = {
+	mxs_mxs_spi_data_entry(MX28, 0, 0),
+	mxs_mxs_spi_data_entry(MX28, 1, 1),
+	mxs_mxs_spi_data_entry(MX28, 2, 2),
+	mxs_mxs_spi_data_entry(MX28, 3, 3),
+};
+#endif
+
+struct platform_device *__init mxs_add_mxs_spi(
+		const struct mxs_mxs_spi_data *data)
+{
+	struct resource res[] = {
+		{
+			.start	= data->iobase,
+			.end	= data->iobase + SZ_8K - 1,
+			.flags	= IORESOURCE_MEM,
+		}, {
+			.start	= data->dma,
+			.end	= data->dma,
+			.flags	= IORESOURCE_DMA,
+		}, {
+			.start	= data->irq_err,
+			.end	= data->irq_err,
+			.flags	= IORESOURCE_IRQ,
+		}, {
+			.start	= data->irq_dma,
+			.end	= data->irq_dma,
+			.flags	= IORESOURCE_IRQ,
+		},
+	};
+
+	return mxs_add_platform_device("mxs-spi", data->id,
+			res, ARRAY_SIZE(res), NULL, 0);
+}
diff --git a/arch/arm/mach-mxs/include/mach/devices-common.h b/arch/arm/mach-mxs/include/mach/devices-common.h
index f2e3839..2bb1d9e 100644
--- a/arch/arm/mach-mxs/include/mach/devices-common.h
+++ b/arch/arm/mach-mxs/include/mach/devices-common.h
@@ -116,3 +116,14 @@  struct mxs_saif_data {
 struct platform_device *__init mxs_add_saif(
 		const struct mxs_saif_data *data,
 		const struct mxs_saif_platform_data *pdata);
+
+/* spi */
+struct mxs_mxs_spi_data {
+	int id;
+	resource_size_t iobase;
+	resource_size_t dma;
+	resource_size_t irq_err;
+	resource_size_t irq_dma;
+};
+struct platform_device *__init mxs_add_mxs_spi(
+		const struct mxs_mxs_spi_data *data);