| Message ID | 1333424902.18626.36.camel@edumazet-glaptop |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
diff --git a/net/netfilter/xt_CT.c b/net/netfilter/xt_CT.c index 0c8e438..6d4ca2f 100644 --- a/net/netfilter/xt_CT.c +++ b/net/netfilter/xt_CT.c @@ -269,7 +269,9 @@ static int xt_ct_tg_check_v1(const struct xt_tgchk_param *par) } else { ret = -ENOENT; pr_info("Timeout policy base is empty\n"); - goto err4; +err4: + rcu_read_unlock(); + goto err3; } rcu_read_unlock(); } @@ -281,8 +283,6 @@ out: info->ct = ct; return 0; -err4: - rcu_read_unlock(); err3: nf_conntrack_free(ct); err2:
If CONFIG_NF_CONNTRACK_TIMEOUT=n we have following warning : CC [M] net/netfilter/xt_CT.o net/netfilter/xt_CT.c: In function ‘xt_ct_tg_check_v1’: net/netfilter/xt_CT.c:284: warning: label ‘err4’ defined but not used Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Cc: Pablo Neira Ayuso <pablo@netfilter.org> --- net/netfilter/xt_CT.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html