Patchwork [U-Boot] hawkboard: Add CONFIG_SPL_LIBGENERIC_SUPPORT

login
register
mail settings
Submitter Tom Rini
Date April 2, 2012, 4:33 p.m.
Message ID <1333384423-1204-1-git-send-email-trini@ti.com>
Download mbox | patch
Permalink /patch/150191/
State Accepted
Commit 385488dc1b20e55739cfdecdce20319a60dbad44
Delegated to: Tom Rini
Headers show

Comments

Tom Rini - April 2, 2012, 4:33 p.m.
With older toolchains we need CONFIG_SPL_LIBGENERIC_SUPPORT in order for
CONFIG_SPL_NAND_SUPPORT to link.

Signed-off-by: Tom Rini <trini@ti.com>
---
 include/configs/hawkboard.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Sughosh Ganu - April 2, 2012, 4:40 p.m.
On Mon Apr 02, 2012 at 09:33:43AM -0700, Tom Rini wrote:
> With older toolchains we need CONFIG_SPL_LIBGENERIC_SUPPORT in order for
> CONFIG_SPL_NAND_SUPPORT to link.
> 
> Signed-off-by: Tom Rini <trini@ti.com>
> ---
>  include/configs/hawkboard.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/hawkboard.h b/include/configs/hawkboard.h
> index 50a1c17..0859371 100644
> --- a/include/configs/hawkboard.h
> +++ b/include/configs/hawkboard.h
> @@ -62,6 +62,7 @@
>  #define CONFIG_SPL_NAND_SUPPORT
>  #define CONFIG_SPL_NAND_SIMPLE
>  #define CONFIG_SPL_NAND_LOAD
> +#define CONFIG_SPL_LIBGENERIC_SUPPORT	/* for udelay and __div64_32 for NAND */
>  #define CONFIG_SPL_SERIAL_SUPPORT
>  #define CONFIG_SPL_LDSCRIPT		"board/$(BOARDDIR)/u-boot-spl-hawk.lds"
>  #define CONFIG_SPL_TEXT_BASE		0xc1080000

 Simon is adding this as part of the common relocation support patch
 series. I think he was going to send an updated version.

-sughosh
Tom Rini - April 2, 2012, 4:44 p.m.
On Mon, Apr 02, 2012 at 10:10:57PM +0530, Sughosh Ganu wrote:
> On Mon Apr 02, 2012 at 09:33:43AM -0700, Tom Rini wrote:
> > With older toolchains we need CONFIG_SPL_LIBGENERIC_SUPPORT in order for
> > CONFIG_SPL_NAND_SUPPORT to link.
> > 
> > Signed-off-by: Tom Rini <trini@ti.com>
> > ---
> >  include/configs/hawkboard.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/configs/hawkboard.h b/include/configs/hawkboard.h
> > index 50a1c17..0859371 100644
> > --- a/include/configs/hawkboard.h
> > +++ b/include/configs/hawkboard.h
> > @@ -62,6 +62,7 @@
> >  #define CONFIG_SPL_NAND_SUPPORT
> >  #define CONFIG_SPL_NAND_SIMPLE
> >  #define CONFIG_SPL_NAND_LOAD
> > +#define CONFIG_SPL_LIBGENERIC_SUPPORT	/* for udelay and __div64_32 for NAND */
> >  #define CONFIG_SPL_SERIAL_SUPPORT
> >  #define CONFIG_SPL_LDSCRIPT		"board/$(BOARDDIR)/u-boot-spl-hawk.lds"
> >  #define CONFIG_SPL_TEXT_BASE		0xc1080000
> 
>  Simon is adding this as part of the common relocation support patch
>  series. I think he was going to send an updated version.

Well, this is broken in mainline today so I don't want to wait.
Marek Vasut - April 2, 2012, 5:57 p.m.
Dear Tom Rini,

> On Mon, Apr 02, 2012 at 10:10:57PM +0530, Sughosh Ganu wrote:
> > On Mon Apr 02, 2012 at 09:33:43AM -0700, Tom Rini wrote:
> > > With older toolchains we need CONFIG_SPL_LIBGENERIC_SUPPORT in order
> > > for CONFIG_SPL_NAND_SUPPORT to link.
> > > 
> > > Signed-off-by: Tom Rini <trini@ti.com>
> > > ---
> > > 
> > >  include/configs/hawkboard.h |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/include/configs/hawkboard.h b/include/configs/hawkboard.h
> > > index 50a1c17..0859371 100644
> > > --- a/include/configs/hawkboard.h
> > > +++ b/include/configs/hawkboard.h
> > > @@ -62,6 +62,7 @@
> > > 
> > >  #define CONFIG_SPL_NAND_SUPPORT
> > >  #define CONFIG_SPL_NAND_SIMPLE
> > >  #define CONFIG_SPL_NAND_LOAD
> > > 
> > > +#define CONFIG_SPL_LIBGENERIC_SUPPORT	/* for udelay and __div64_32 for
> > > NAND */
> > > 
> > >  #define CONFIG_SPL_SERIAL_SUPPORT
> > >  #define CONFIG_SPL_LDSCRIPT		"board/$(BOARDDIR)/u-boot-spl-
hawk.lds"
> > >  #define CONFIG_SPL_TEXT_BASE		0xc1080000
> >  
> >  Simon is adding this as part of the common relocation support patch
> >  series. I think he was going to send an updated version.
> 
> Well, this is broken in mainline today so I don't want to wait.

Agreed

Best regards,
Marek Vasut
Tom Rini - April 3, 2012, 4:21 p.m.
On Mon, Apr 02, 2012 at 09:33:43AM -0700, Tom Rini wrote:

> With older toolchains we need CONFIG_SPL_LIBGENERIC_SUPPORT in order for
> CONFIG_SPL_NAND_SUPPORT to link.
> 
> Signed-off-by: Tom Rini <trini@ti.com>

Queued up for u-boot-ti/master (which I intend to PR Friday).

Patch

diff --git a/include/configs/hawkboard.h b/include/configs/hawkboard.h
index 50a1c17..0859371 100644
--- a/include/configs/hawkboard.h
+++ b/include/configs/hawkboard.h
@@ -62,6 +62,7 @@ 
 #define CONFIG_SPL_NAND_SUPPORT
 #define CONFIG_SPL_NAND_SIMPLE
 #define CONFIG_SPL_NAND_LOAD
+#define CONFIG_SPL_LIBGENERIC_SUPPORT	/* for udelay and __div64_32 for NAND */
 #define CONFIG_SPL_SERIAL_SUPPORT
 #define CONFIG_SPL_LDSCRIPT		"board/$(BOARDDIR)/u-boot-spl-hawk.lds"
 #define CONFIG_SPL_TEXT_BASE		0xc1080000