Message ID | 4F7948B2.4090100@cn.fujitsu.com |
---|---|
State | New |
Headers | show |
Am 02.04.2012 08:35, schrieb Lai Jiangshan: > > use & instead of the wrong && > > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> Patch looks okay but the subject should probably be fixed to say "usb:" when applying. :) Andreas > --- > diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c > index 73b0c7f..89c2406 100644 > --- a/hw/usb/hcd-xhci.c > +++ b/hw/usb/hcd-xhci.c > @@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci) > int level = 0; > > if (xhci->iman & IMAN_IP && xhci->iman & IMAN_IE && > - xhci->usbcmd && USBCMD_INTE) { > + xhci->usbcmd & USBCMD_INTE) { > level = 1; > } >
On 04/02/2012 05:50 PM, Andreas Färber wrote: > Am 02.04.2012 08:35, schrieb Lai Jiangshan: >> >> use & instead of the wrong && >> >> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> > > Patch looks okay but the subject should probably be fixed to say "usb:" > when applying. :) > Thank you!! Hi, Gerd, Does this patch have any problem? could you merge it with "use:"->"usb:" in the title. (I think it is not good to send another patch for this) Thanks Lai > >> --- >> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c >> index 73b0c7f..89c2406 100644 >> --- a/hw/usb/hcd-xhci.c >> +++ b/hw/usb/hcd-xhci.c >> @@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci) >> int level = 0; >> >> if (xhci->iman & IMAN_IP && xhci->iman & IMAN_IE && >> - xhci->usbcmd && USBCMD_INTE) { >> + xhci->usbcmd & USBCMD_INTE) { >> level = 1; >> } >> >
On 04/02/12 08:35, Lai Jiangshan wrote:
> use & instead of the wrong &&
Fixed $subject and added to usb patch queue.
thanks,
Gerd
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 73b0c7f..89c2406 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci) int level = 0; if (xhci->iman & IMAN_IP && xhci->iman & IMAN_IE && - xhci->usbcmd && USBCMD_INTE) { + xhci->usbcmd & USBCMD_INTE) { level = 1; }
use & instead of the wrong && Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> ---