Patchwork klog: Add EC transaction failure detection

login
register
mail settings
Submitter Colin King
Date April 2, 2012, 6:22 a.m.
Message ID <1333347737-8345-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/150075/
State Accepted
Headers show

Comments

Colin King - April 2, 2012, 6:22 a.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
Alex Hung - April 2, 2012, 6:30 a.m.
On 04/02/2012 02:22 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   data/klog.json |    7 +++++++
>   1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index 4598754..e1a9143 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -70,6 +70,13 @@
>     {
>      "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
> +   "pattern": "ACPI:.*EC.*input buffer is not empty, aborting transaction",
> +   "advice": "The ACPI Embedded Controller (EC) driver attempted to perform a read or write transaction but had to abort because the EC was still busy and the input buffer was not emptied within 500ms.  Normally this indicates an EC firmware fault.  One can try increasing the delay using the acpi.ec_delay kernel parameter or writing to /sys/module/acpi/parameters/ec_delay - however this generally does not help much of the EC firmware is buggy."
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_BIOS",
>      "pattern": "ENERGY_PERF_BIAS.*Set to 'normal'.* was 'performance'",
>      "advice": "The MSR_IA32_ENERGY_PERF_BIAS was initialized incorrectly and was defaulted to a high performance bias setting.  The kernel has detected this and changed it down to a 'normal' bias setting.  The BIOS vendor should be informed that the MSR is not defaulted to the normal bias setting."
Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - April 3, 2012, 2:44 a.m.
On Mon, Apr 2, 2012 at 2:30 PM, Alex Hung <alex.hung@canonical.com> wrote:
> On 04/02/2012 02:22 PM, Colin King wrote:
>>
>> From: Colin Ian King<colin.king@canonical.com>
>>
>> Signed-off-by: Colin Ian King<colin.king@canonical.com>
>> ---
>>  data/klog.json |    7 +++++++
>>  1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/data/klog.json b/data/klog.json
>> index 4598754..e1a9143 100644
>> --- a/data/klog.json
>> +++ b/data/klog.json
>> @@ -70,6 +70,13 @@
>>    {
>>     "compare_mode": "regex",
>>     "log_level": "LOG_LEVEL_HIGH",
>> +   "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
>> +   "pattern": "ACPI:.*EC.*input buffer is not empty, aborting
>> transaction",
>> +   "advice": "The ACPI Embedded Controller (EC) driver attempted to
>> perform a read or write transaction but had to abort because the EC was
>> still busy and the input buffer was not emptied within 500ms.  Normally this
>> indicates an EC firmware fault.  One can try increasing the delay using the
>> acpi.ec_delay kernel parameter or writing to
>> /sys/module/acpi/parameters/ec_delay - however this generally does not help
>> much of the EC firmware is buggy."
>> +  },
>> +  {
>> +   "compare_mode": "regex",
>> +   "log_level": "LOG_LEVEL_HIGH",
>>     "tag": "FWTS_TAG_BIOS",
>>     "pattern": "ENERGY_PERF_BIAS.*Set to 'normal'.* was 'performance'",
>>     "advice": "The MSR_IA32_ENERGY_PERF_BIAS was initialized incorrectly
>> and was defaulted to a high performance bias setting.  The kernel has
>> detected this and changed it down to a 'normal' bias setting.  The BIOS
>> vendor should be informed that the MSR is not defaulted to the normal bias
>> setting."
>
> Acked-by: Alex Hung <alex.hung@canonical.com>
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 4598754..e1a9143 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -70,6 +70,13 @@ 
   {
    "compare_mode": "regex",
    "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
+   "pattern": "ACPI:.*EC.*input buffer is not empty, aborting transaction",
+   "advice": "The ACPI Embedded Controller (EC) driver attempted to perform a read or write transaction but had to abort because the EC was still busy and the input buffer was not emptied within 500ms.  Normally this indicates an EC firmware fault.  One can try increasing the delay using the acpi.ec_delay kernel parameter or writing to /sys/module/acpi/parameters/ec_delay - however this generally does not help much of the EC firmware is buggy."
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_BIOS",
    "pattern": "ENERGY_PERF_BIAS.*Set to 'normal'.* was 'performance'",
    "advice": "The MSR_IA32_ENERGY_PERF_BIAS was initialized incorrectly and was defaulted to a high performance bias setting.  The kernel has detected this and changed it down to a 'normal' bias setting.  The BIOS vendor should be informed that the MSR is not defaulted to the normal bias setting."