Patchwork rtc/pl031: enable clock on all ST variants

login
register
mail settings
Submitter Linus Walleij
Date April 1, 2012, 10:27 a.m.
Message ID <1333276048-26275-1-git-send-email-linus.walleij@linaro.org>
Download mbox | patch
Permalink /patch/149910/
State New
Headers show

Comments

Linus Walleij - April 1, 2012, 10:27 a.m.
The ST variants of the PL031 all require bit 26 in the control
register to be set before they work properly. Discovered this when
testing on the Nomadik board where it would suprisingly just stand
still.

Cc: stable@kernel.org
Cc: Mian Yousaf Kaukab <mian.yousaf.kaukab@stericsson.com>
Cc: Alessandro Rubini <rubini@unipv.it>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/rtc/rtc-pl031.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

Patch

diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c
index 692de73..684ef4b 100644
--- a/drivers/rtc/rtc-pl031.c
+++ b/drivers/rtc/rtc-pl031.c
@@ -339,8 +339,7 @@  static int pl031_probe(struct amba_device *adev, const struct amba_id *id)
 	dev_dbg(&adev->dev, "revision = 0x%01x\n", ldata->hw_revision);
 
 	/* Enable the clockwatch on ST Variants */
-	if ((ldata->hw_designer == AMBA_VENDOR_ST) &&
-	    (ldata->hw_revision > 1))
+	if (ldata->hw_designer == AMBA_VENDOR_ST)
 		writel(readl(ldata->base + RTC_CR) | RTC_CR_CWEN,
 		       ldata->base + RTC_CR);