From patchwork Sun Apr 1 02:48:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brad Smith X-Patchwork-Id: 149897 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 07707B6FE8 for ; Sun, 1 Apr 2012 12:48:39 +1000 (EST) Received: from localhost ([::1]:41513 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEAqK-0003WJ-GO for incoming@patchwork.ozlabs.org; Sat, 31 Mar 2012 22:48:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEAqD-0003P1-IE for qemu-devel@nongnu.org; Sat, 31 Mar 2012 22:48:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEAqB-00077b-3i for qemu-devel@nongnu.org; Sat, 31 Mar 2012 22:48:29 -0400 Received: from speedy.comstyle.com ([206.51.28.2]:5521 helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEAqA-00076Y-VV for qemu-devel@nongnu.org; Sat, 31 Mar 2012 22:48:27 -0400 Received: from rox.home.comstyle.com (unknown [IPv6:2001:470:b01e:3::577]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: brad) by mail.comstyle.com (Postfix) with ESMTPSA id C29EBB943E for ; Sat, 31 Mar 2012 22:48:19 -0400 (EDT) Date: Sat, 31 Mar 2012 22:48:18 -0400 From: Brad Smith To: qemu-devel@nongnu.org Message-ID: <20120401024817.GA14275@rox.home.comstyle.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-comstyle-MailScanner-Information: Please contact the ISP for more information X-comstyle-MailScanner-ID: C29EBB943E.A786D X-comstyle-MailScanner: Found to be clean X-comstyle-MailScanner-SpamCheck: not spam (whitelisted), SpamAssassin (not cached, score=-2.9, required 6, autolearn=not spam, ALL_TRUSTED -1.00, BAYES_00 -1.90) X-comstyle-MailScanner-From: brad@comstyle.com X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.51.28.2 Subject: [Qemu-devel] More build breakage: signrom.sh vs kvmvapic.bin X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Here is another source of build breakage that popped up over a month ago. The patch below fixes the build but I'm wondering why the file in question is being built on anything but Linux. It seems to be used for KVM support and thus has no relevance on any other OS. AS optionrom/kvmvapic.o Building optionrom/kvmvapic.img Building optionrom/kvmvapic.raw Signing optionrom/kvmvapic.bin /buildbot-qemu/default_openbsd_current/build/scripts/signrom.sh[31]: 018 * 512 - 1 : bad number `018' gmake[1]: *** [kvmvapic.bin] Error 1 diff --git a/scripts/signrom.sh b/scripts/signrom.sh index 9dc5c63..2d421e9 100755 --- a/scripts/signrom.sh +++ b/scripts/signrom.sh @@ -27,8 +27,8 @@ sum=0 # find out the file size x=`dd if="$1" bs=1 count=1 skip=2 2>/dev/null | od -t u1 -A n` -#size=`expr $x \* 512 - 1` -size=$(( $x * 512 - 1 )) +size=`expr $x \* 512 - 1` +#size=$(( $x * 512 - 1 )) # now get the checksum nums=`od -A n -t u1 -v -N $size "$1"`