| Message ID | 1333216039-21507-10-git-send-email-marex@denx.de |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi Marek, On Sat, 31 Mar 2012 19:47:15 +0200 Marek Vasut <marex@denx.de> wrote: > Signed-off-by: Marek Vasut <marex@denx.de> > --- > README | 7 ------- > 1 files changed, 0 insertions(+), 7 deletions(-) > > diff --git a/README b/README > index c98afa7..0ebe877 100644 > --- a/README > +++ b/README > @@ -3379,10 +3379,6 @@ Low Level (hardware related) configuration options: > and crc32 is the correct crc32 which the > area should have. > > -- CONFIG_LOOPW > - Add the "loopw" memory command. This only takes effect if > - the memory commands are activated globally (CONFIG_CMD_MEM). Please, no. CONFIG_LOOPW is used if CONFIG_CMD_MEMORY is defined. This text should be fixed instead: s/CONFIG_CMD_MEM/CONFIG_CMD_MEMORY/ Also it probably makes sense to change CONFIG_LOOPW to CONFIG_CMD_LOOPW since this configures an U-Boot command. Same for CONFIG_MX_CYCLIC. ... > @@ -3394,9 +3390,6 @@ Low Level (hardware related) configuration options: > => mwc.l 100 12345678 10 > This command will write 12345678 to address 100 all 10 ms. > > - This only takes effect if the memory commands are activated > - globally (CONFIG_CMD_MEM). > - Same applies here. Thanks, Anatolij
Dear Anatolij Gustschin, > Hi Marek, > > On Sat, 31 Mar 2012 19:47:15 +0200 > > Marek Vasut <marex@denx.de> wrote: > > Signed-off-by: Marek Vasut <marex@denx.de> > > --- > > > > README | 7 ------- > > 1 files changed, 0 insertions(+), 7 deletions(-) > > > > diff --git a/README b/README > > index c98afa7..0ebe877 100644 > > --- a/README > > +++ b/README > > > > @@ -3379,10 +3379,6 @@ Low Level (hardware related) configuration options: > > and crc32 is the correct crc32 which the > > area should have. > > > > -- CONFIG_LOOPW > > - Add the "loopw" memory command. This only takes effect if > > - the memory commands are activated globally (CONFIG_CMD_MEM). > > Please, no. CONFIG_LOOPW is used if CONFIG_CMD_MEMORY is defined. This > text should be fixed instead: s/CONFIG_CMD_MEM/CONFIG_CMD_MEMORY/ DAMN, it's not CONFIG_CMD ... scrap this patch, good catch! > > Also it probably makes sense to change CONFIG_LOOPW to CONFIG_CMD_LOOPW > since this configures an U-Boot command. Agreed! > > Same for CONFIG_MX_CYCLIC. Yes. > > ... > > > @@ -3394,9 +3390,6 @@ Low Level (hardware related) configuration options: > > => mwc.l 100 12345678 10 > > This command will write 12345678 to address 100 all 10 ms. > > > > - This only takes effect if the memory commands are activated > > - globally (CONFIG_CMD_MEM). > > - > > Same applies here. > > Thanks, > Anatolij Best regards, Marek Vasut
diff --git a/README b/README index c98afa7..0ebe877 100644 --- a/README +++ b/README @@ -3379,10 +3379,6 @@ Low Level (hardware related) configuration options: and crc32 is the correct crc32 which the area should have. -- CONFIG_LOOPW - Add the "loopw" memory command. This only takes effect if - the memory commands are activated globally (CONFIG_CMD_MEM). - - CONFIG_MX_CYCLIC Add the "mdc" and "mwc" memory commands. These are cyclic "md/mw" commands. @@ -3394,9 +3390,6 @@ Low Level (hardware related) configuration options: => mwc.l 100 12345678 10 This command will write 12345678 to address 100 all 10 ms. - This only takes effect if the memory commands are activated - globally (CONFIG_CMD_MEM). - - CONFIG_SKIP_LOWLEVEL_INIT [ARM, NDS32, MIPS only] If this variable is defined, then certain low level initializations (like setting up the memory
Signed-off-by: Marek Vasut <marex@denx.de> --- README | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-)