Patchwork tests: remove .SECONDARY special target

login
register
mail settings
Submitter Paolo Bonzini
Date March 31, 2012, 10:50 a.m.
Message ID <1333191021-2189-1-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/149818/
State New
Headers show

Comments

Paolo Bonzini - March 31, 2012, 10:50 a.m.
The special target should not be needed anymore, and caused (perhaps
due to a Make bug) a failure with "make -j2".  In any case, the
main makefile is a better place for such special targets rather
than an included makefile.

Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
	Anthony, this was taken from your patches, do you remember
        why it's needed?  I changed the rules to use the GNU Make
        "LIST: TARGET-PATTERN: SOURCE-PATTERN" syntax so there
        should be no implicit rules anymore and .SECONDARY should
        not be needed.

 tests/Makefile |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Luiz Capitulino - April 2, 2012, 1:50 a.m.
On Sat, 31 Mar 2012 12:50:21 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> The special target should not be needed anymore, and caused (perhaps
> due to a Make bug) a failure with "make -j2".  In any case, the
> main makefile is a better place for such special targets rather
> than an included makefile.
> 
> Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Tested-by: Luiz Capitulino <lcapitulino@redhat.com>

Nice to see it building again.

> ---
> 	Anthony, this was taken from your patches, do you remember
>         why it's needed?  I changed the rules to use the GNU Make
>         "LIST: TARGET-PATTERN: SOURCE-PATTERN" syntax so there
>         should be no implicit rules anymore and .SECONDARY should
>         not be needed.
> 
>  tests/Makefile |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index 17f6ece..25a972a 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -74,8 +74,6 @@ check-help:
>  	@echo "Default options are -k and (for make V=1) --verbose; they can be"
>  	@echo "changed with variable GTESTER_OPTIONS."
>  
> -.SECONDARY:
> -
>  SPEED = quick
>  GTESTER_OPTIONS = -k $(if $(V),--verbose,-q)
>
Luiz Capitulino - April 11, 2012, 4:22 p.m.
On Sun, 1 Apr 2012 22:50:57 -0300
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> On Sat, 31 Mar 2012 12:50:21 +0200
> Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
> > The special target should not be needed anymore, and caused (perhaps
> > due to a Make bug) a failure with "make -j2".  In any case, the
> > main makefile is a better place for such special targets rather
> > than an included makefile.
> > 
> > Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Tested-by: Luiz Capitulino <lcapitulino@redhat.com>
> 
> Nice to see it building again.

Ping?
Blue Swirl - April 14, 2012, 4:21 p.m.
On Sat, Mar 31, 2012 at 10:50, Paolo Bonzini <pbonzini@redhat.com> wrote:
> The special target should not be needed anymore, and caused (perhaps
> due to a Make bug) a failure with "make -j2".  In any case, the
> main makefile is a better place for such special targets rather
> than an included makefile.
>
> Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks, applied.

> ---
>        Anthony, this was taken from your patches, do you remember
>        why it's needed?  I changed the rules to use the GNU Make
>        "LIST: TARGET-PATTERN: SOURCE-PATTERN" syntax so there
>        should be no implicit rules anymore and .SECONDARY should
>        not be needed.
>
>  tests/Makefile |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 17f6ece..25a972a 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -74,8 +74,6 @@ check-help:
>        @echo "Default options are -k and (for make V=1) --verbose; they can be"
>        @echo "changed with variable GTESTER_OPTIONS."
>
> -.SECONDARY:
> -
>  SPEED = quick
>  GTESTER_OPTIONS = -k $(if $(V),--verbose,-q)
>
> --
> 1.7.9.1
>
>

Patch

diff --git a/tests/Makefile b/tests/Makefile
index 17f6ece..25a972a 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -74,8 +74,6 @@  check-help:
 	@echo "Default options are -k and (for make V=1) --verbose; they can be"
 	@echo "changed with variable GTESTER_OPTIONS."
 
-.SECONDARY:
-
 SPEED = quick
 GTESTER_OPTIONS = -k $(if $(V),--verbose,-q)