From patchwork Fri Mar 30 20:05:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [v2, 13/15] media/video/s5p-tv: mark const init data with __initconst instead of __initdata From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 149743 Message-Id: <1333137905-13809-13-git-send-email-u.kleine-koenig@pengutronix.de> To: linux-kernel@vger.kernel.org, Andrew Morton Cc: Tomasz Stanislawski , Mauro Carvalho Chehab , Kyungmin Park , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Date: Fri, 30 Mar 2012 22:05:03 +0200 As long as there is no other non-const variable marked __initdata in the same compilation unit it doesn't hurt. If there were one however compilation would fail with error: $variablename causes a section type conflict because a section containing const variables is marked read only and so cannot contain non-const variables. Signed-off-by: Uwe Kleine-König Cc: Kyungmin Park Cc: Tomasz Stanislawski Cc: Mauro Carvalho Chehab Cc: linux-arm-kernel@lists.infradead.org Cc: linux-media@vger.kernel.org --- no changes since (implicit) v1 drivers/media/video/s5p-tv/mixer_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/video/s5p-tv/mixer_drv.c b/drivers/media/video/s5p-tv/mixer_drv.c index a2c0c25..edca065 100644 --- a/drivers/media/video/s5p-tv/mixer_drv.c +++ b/drivers/media/video/s5p-tv/mixer_drv.c @@ -461,7 +461,7 @@ static struct platform_driver mxr_driver __refdata = { static int __init mxr_init(void) { int i, ret; - static const char banner[] __initdata = KERN_INFO + static const char banner[] __initconst = KERN_INFO "Samsung TV Mixer driver, " "(c) 2010-2011 Samsung Electronics Co., Ltd.\n"; printk(banner);