Patchwork sparc: fix compile failure in kgdb_64.c

login
register
mail settings
Submitter Paul Gortmaker
Date March 30, 2012, 7:31 p.m.
Message ID <1333135884-12815-1-git-send-email-paul.gortmaker@windriver.com>
Download mbox | patch
Permalink /patch/149737/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Paul Gortmaker - March 30, 2012, 7:31 p.m.
To fix:

  CC      arch/sparc/kernel/kgdb_64.o
 arch/sparc/kernel/kgdb_64.c: In function 'smp_kgdb_capture_client':
 arch/sparc/kernel/kgdb_64.c:121: error: implicit declaration of function 'flushw_all'
 make[2]: *** [arch/sparc/kernel/kgdb_64.o] Error 1

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---

[tested on linux-next; presumably caused by the asm/system.h split]
Sam Ravnborg - March 30, 2012, 8:16 p.m.
On Fri, Mar 30, 2012 at 03:31:24PM -0400, Paul Gortmaker wrote:
> To fix:
> 
>   CC      arch/sparc/kernel/kgdb_64.o
>  arch/sparc/kernel/kgdb_64.c: In function 'smp_kgdb_capture_client':
>  arch/sparc/kernel/kgdb_64.c:121: error: implicit declaration of function 'flushw_all'
>  make[2]: *** [arch/sparc/kernel/kgdb_64.o] Error 1
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> 
> [tested on linux-next; presumably caused by the asm/system.h split]
> 
> diff --git a/arch/sparc/kernel/kgdb_64.c b/arch/sparc/kernel/kgdb_64.c
> index 768290a..e916169 100644
> --- a/arch/sparc/kernel/kgdb_64.c
> +++ b/arch/sparc/kernel/kgdb_64.c
> @@ -8,6 +8,7 @@
>  #include <linux/ftrace.h>
>  
>  #include <asm/kdebug.h>
> +#include <asm/cacheflush.h>
>  #include <asm/ptrace.h>
>  #include <asm/irq.h>

David already fixed this in the sparc tree and sent a pull request to Linus.
You can see his patch here:
https://git.kernel.org/?p=linux/kernel/git/davem/sparc.git;a=commitdiff;h=8befc9f23c695395de011ced289c611fada22f35

Please note a small difference...
The include is placed in the top to maintain the "inverse christmas tree" order.
Longest includes first - and these with equal length are sorted alphabetically.

This is used for all new sparc code.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sam Ravnborg - March 30, 2012, 8:18 p.m.
> 
> David already fixed this in the sparc tree and sent a pull request to Linus.

Which is already upstream - so sparc64 should build now.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - March 30, 2012, 8:47 p.m.
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Fri, 30 Mar 2012 15:31:24 -0400

> To fix:
> 
>   CC      arch/sparc/kernel/kgdb_64.o
>  arch/sparc/kernel/kgdb_64.c: In function 'smp_kgdb_capture_client':
>  arch/sparc/kernel/kgdb_64.c:121: error: implicit declaration of function 'flushw_all'
>  make[2]: *** [arch/sparc/kernel/kgdb_64.o] Error 1
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

I already pushed this fix to Linus last night.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paul Gortmaker - March 30, 2012, 9:56 p.m.
On 12-03-30 04:47 PM, David Miller wrote:
> From: Paul Gortmaker <paul.gortmaker@windriver.com>
> Date: Fri, 30 Mar 2012 15:31:24 -0400
> 
>> To fix:
>>
>>   CC      arch/sparc/kernel/kgdb_64.o
>>  arch/sparc/kernel/kgdb_64.c: In function 'smp_kgdb_capture_client':
>>  arch/sparc/kernel/kgdb_64.c:121: error: implicit declaration of function 'flushw_all'
>>  make[2]: *** [arch/sparc/kernel/kgdb_64.o] Error 1
>>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> 
> I already pushed this fix to Linus last night.

Sorry for the noise.  One of those moment where you hit enter
and *then* realize that you forgot to check if it was already
reported/fixed.

P.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/sparc/kernel/kgdb_64.c b/arch/sparc/kernel/kgdb_64.c
index 768290a..e916169 100644
--- a/arch/sparc/kernel/kgdb_64.c
+++ b/arch/sparc/kernel/kgdb_64.c
@@ -8,6 +8,7 @@ 
 #include <linux/ftrace.h>
 
 #include <asm/kdebug.h>
+#include <asm/cacheflush.h>
 #include <asm/ptrace.h>
 #include <asm/irq.h>