| Submitter | Amit Virdi |
|---|---|
| Date | March 30, 2012, 6:55 a.m. |
| Message ID | <720dfbd6855ccd9337d50dc566914d94e24ab726.1333090212.git.amit.virdi@st.com> |
| Download | mbox | patch |
| Permalink | /patch/149563/ |
| State | Superseded |
| Delegated to: | Stefan Roese |
| Headers | show |
Comments
Dear Amit Virdi, > From: Vipin KUMAR <vipin.kumar@st.com> Cc me with usb related stuff please. Does USBTTY work for you? Tom complained about it. > > This patch enables the support for usb high speed device for spear platform > SOCs > > Signed-off-by: Vipin Kumar <vipin.kumar@st.com> > Signed-off-by: Amit Virdi <amit.virdi@st.com> > --- > include/configs/spear-common.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/configs/spear-common.h > b/include/configs/spear-common.h index df8bec5..ce01026 100644 > --- a/include/configs/spear-common.h > +++ b/include/configs/spear-common.h > @@ -41,6 +41,7 @@ > /* USBD driver configuration */ > #define CONFIG_DW_UDC > #define CONFIG_USB_DEVICE > +#define CONFIG_USBD_HS > #define CONFIG_USB_TTY > > #define CONFIG_USBD_PRODUCT_NAME "SPEAr SoC" Best regards, Marek Vasut
Dear Marek, On 3/31/2012 11:58 PM, Marek Vasut wrote: > Dear Amit Virdi, > >> From: Vipin KUMAR<vipin.kumar@st.com> > > Cc me with usb related stuff please. > Ok, I'll take care in future. > Does USBTTY work for you? Tom complained about it. > Yes it works and we haven't found any issue till date. Infact, Vipin has developed a tool for flashing using usbtty and we have been using it for quite long. What kind of problems did Tom faced? Best Regards Amit Virdi >> >> This patch enables the support for usb high speed device for spear platform >> SOCs >> >> Signed-off-by: Vipin Kumar<vipin.kumar@st.com> >> Signed-off-by: Amit Virdi<amit.virdi@st.com> >> --- >> include/configs/spear-common.h | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/include/configs/spear-common.h >> b/include/configs/spear-common.h index df8bec5..ce01026 100644 >> --- a/include/configs/spear-common.h >> +++ b/include/configs/spear-common.h >> @@ -41,6 +41,7 @@ >> /* USBD driver configuration */ >> #define CONFIG_DW_UDC >> #define CONFIG_USB_DEVICE >> +#define CONFIG_USBD_HS >> #define CONFIG_USB_TTY >> >> #define CONFIG_USBD_PRODUCT_NAME "SPEAr SoC" > > Best regards, > Marek Vasut >
On 04/01/2012 11:50 PM, Amit Virdi wrote: > Dear Marek, > > On 3/31/2012 11:58 PM, Marek Vasut wrote: >> Dear Amit Virdi, >> >>> From: Vipin KUMAR<vipin.kumar@st.com> >> >> Cc me with usb related stuff please. >> > > Ok, I'll take care in future. > >> Does USBTTY work for you? Tom complained about it. >> > > Yes it works and we haven't found any issue till date. Infact, Vipin has > developed a tool for flashing using usbtty and we have been using it for > quite long. > > What kind of problems did Tom faced? On a beagleboard it's acting like the buffer isn't being flushed at first. If I type 'help' after switching from UART I have to hit space a few times to see all the output.
Patch
diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h index df8bec5..ce01026 100644 --- a/include/configs/spear-common.h +++ b/include/configs/spear-common.h @@ -41,6 +41,7 @@ /* USBD driver configuration */ #define CONFIG_DW_UDC #define CONFIG_USB_DEVICE +#define CONFIG_USBD_HS #define CONFIG_USB_TTY #define CONFIG_USBD_PRODUCT_NAME "SPEAr SoC"