| Message ID | 1333058705-31512-8-git-send-email-jmoyer@redhat.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
diff --git a/mm/filemap.c b/mm/filemap.c index 79c4b2b..ef81dfb 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2614,7 +2614,7 @@ ssize_t generic_file_aio_write(struct kiocb *iocb, const struct iovec *iov, ret = __generic_file_aio_write(iocb, iov, nr_segs, &iocb->ki_pos); mutex_unlock(&inode->i_mutex); - if (ret > 0 || ret == -EIOCBQUEUED) { + if (ret > 0) { ssize_t err; err = generic_write_sync(file, pos, ret);
Hi, As it stands, generic_file_aio_write will call into generic_write_sync when -EIOCBQUEUED is returned from __generic_file_aio_write. EIOCBQUEUED indicates that an I/O was submitted but NOT completed. Thus, we will flush the disk cache, potentially before the write(s) even make it to the disk! Up until now, this has been the best we could do, as file systems didn't bother to flush the disk cache after an O_SYNC AIO+DIO write. After applying the prior two patches to xfs and ext4, at least the major two file systems do the right thing. So, let's go ahead and fix this backwards logic. Signed-off-by: Jeff Moyer <jmoyer@redhat.com> --- mm/filemap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)