Patchwork UBUNTU: SAUCE (no-up) Quirk for enabling backlight hotkeys on Samsung N510P

login
register
mail settings
Submitter Brad Figg
Date March 29, 2012, 7:02 p.m.
Message ID <1333047724-10543-2-git-send-email-brad.figg@canonical.com>
Download mbox | patch
Permalink /patch/149462/
State New
Headers show

Comments

Brad Figg - March 29, 2012, 7:02 p.m.
BugLink: http://bugs.launchpad.net/bugs/875893

Signed-off-by: Brad Figg <brad.figg@canonical.com>
---
 drivers/platform/x86/samsung-laptop.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)
Seth Forshee - March 29, 2012, 7:19 p.m.
On Thu, Mar 29, 2012 at 12:02:04PM -0700, Brad Figg wrote:
> BugLink: http://bugs.launchpad.net/bugs/875893
> 
> Signed-off-by: Brad Figg <brad.figg@canonical.com>
> ---
>  drivers/platform/x86/samsung-laptop.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
> index 09e26bf..7f208fd 100644
> --- a/drivers/platform/x86/samsung-laptop.c
> +++ b/drivers/platform/x86/samsung-laptop.c
> @@ -579,6 +579,16 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
>  		.callback = dmi_check_cb,
>  	},
>  	{
> +		.ident = "N510P",

I think you transposed some numbers. In the bug it's "N150P".

> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR,
> +					"SAMSUNG ELECTRONICS CO., LTD."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "N510P"),
> +			DMI_MATCH(DMI_BOARD_NAME, "N510P"),
> +		},
> +		.callback = dmi_check_cb,
> +	},
> +	{
>  		.ident = "X125",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR,
> -- 
> 1.7.9.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Brad Figg - March 29, 2012, 7:52 p.m.
On 03/29/2012 12:19 PM, Seth Forshee wrote:
> On Thu, Mar 29, 2012 at 12:02:04PM -0700, Brad Figg wrote:
>> BugLink: http://bugs.launchpad.net/bugs/875893
>>
>> Signed-off-by: Brad Figg <brad.figg@canonical.com>
>> ---
>>  drivers/platform/x86/samsung-laptop.c |   10 ++++++++++
>>  1 files changed, 10 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
>> index 09e26bf..7f208fd 100644
>> --- a/drivers/platform/x86/samsung-laptop.c
>> +++ b/drivers/platform/x86/samsung-laptop.c
>> @@ -579,6 +579,16 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
>>  		.callback = dmi_check_cb,
>>  	},
>>  	{
>> +		.ident = "N510P",
> 
> I think you transposed some numbers. In the bug it's "N150P".
> 
>> +		.matches = {
>> +			DMI_MATCH(DMI_SYS_VENDOR,
>> +					"SAMSUNG ELECTRONICS CO., LTD."),
>> +			DMI_MATCH(DMI_PRODUCT_NAME, "N510P"),
>> +			DMI_MATCH(DMI_BOARD_NAME, "N510P"),
>> +		},
>> +		.callback = dmi_check_cb,
>> +	},
>> +	{
>>  		.ident = "X125",
>>  		.matches = {
>>  			DMI_MATCH(DMI_SYS_VENDOR,
>> -- 
>> 1.7.9.1
>>
>>
>> -- 
>> kernel-team mailing list
>> kernel-team@lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Thanks for catching that. I looked at it several times to make sure it was correct
and I still screwed it up.

Brad

Patch

diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index 09e26bf..7f208fd 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -579,6 +579,16 @@  static struct dmi_system_id __initdata samsung_dmi_table[] = {
 		.callback = dmi_check_cb,
 	},
 	{
+		.ident = "N510P",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR,
+					"SAMSUNG ELECTRONICS CO., LTD."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "N510P"),
+			DMI_MATCH(DMI_BOARD_NAME, "N510P"),
+		},
+		.callback = dmi_check_cb,
+	},
+	{
 		.ident = "X125",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR,