From patchwork Thu Mar 29 16:33:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 149430 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 504F1B6EEF for ; Fri, 30 Mar 2012 03:35:08 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SDIHn-0002Jn-Q8; Thu, 29 Mar 2012 16:33:19 +0000 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SDIHi-0002I2-P8 for linux-arm-kernel@lists.infradead.org; Thu, 29 Mar 2012 16:33:15 +0000 Received: from c-98-234-237-12.hsd1.ca.comcast.net ([98.234.237.12] helo=localhost.localdomain) by mho-02-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1SDIHg-00034A-V1; Thu, 29 Mar 2012 16:33:13 +0000 Received: from Mutt by mutt-smtp-wrapper.pl 1.2 (www.zdo.com/articles/mutt-smtp-wrapper.shtml) X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 98.234.237.12 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18ztaW2578KnkGREvFbXaZt Date: Thu, 29 Mar 2012 09:33:10 -0700 From: Tony Lindgren To: "Govindraj.R" Subject: Re: [PATCH] omap2+: pm: fix compilation break. Message-ID: <20120329163309.GW9859@atomide.com> References: <1333015762-476-1-git-send-email-govindraj.raja@ti.com> <20120329151128.GT9859@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120329151128.GT9859@atomide.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [204.13.248.72 listed in list.dnswl.org] 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Kevin Hilman , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org * Tony Lindgren [120329 08:14]: > * Govindraj.R [120329 03:12]: > > From: "Govindraj.R" > > > > Fix the compilation break observed on latest mainline. > > > > Fixes below compilation break: > > > > arch/arm/mach-omap2/pm.c: In function 'omap_pm_begin': > > arch/arm/mach-omap2/pm.c:239: error: implicit declaration of function 'disable_hlt' > > arch/arm/mach-omap2/pm.c: In function 'omap_pm_end': > > arch/arm/mach-omap2/pm.c:247: error: implicit declaration of function 'enable_hlt' > > Care to mention which commit broke the compile? Seems like it was 9f97da78 (Disintegrate asm/system.h for ARM), and also needs to be fixed for omap1 too. Using the updated patch below. Tony From: Govindraj.R Date: Thu, 29 Mar 2012 09:30:28 -0700 Subject: [PATCH] ARM: OMAP: pm: fix compilation break MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix the compilation break observed on latest mainline caused by 9f97da78 (Disintegrate asm/system.h for ARM): arch/arm/mach-omap1/pm.c: In function ‘omap_pm_prepare’: arch/arm/mach-omap1/pm.c:587: error: implicit declaration of function ‘disable_hlt’ arch/arm/mach-omap1/pm.c: In function ‘omap_pm_finish’: arch/arm/mach-omap1/pm.c:624: error: implicit declaration of function ‘enable_hlt’ arch/arm/mach-omap1/pm.c: In function ‘omap_pm_init’: arch/arm/mach-omap1/pm.c:681: error: ‘arm_pm_idle’ undeclared (first use in this function) ... arch/arm/mach-omap2/pm.c: In function 'omap_pm_begin': arch/arm/mach-omap2/pm.c:239: error: implicit declaration of function 'disable_hlt' arch/arm/mach-omap2/pm.c: In function 'omap_pm_end': arch/arm/mach-omap2/pm.c:247: error: implicit declaration of function 'enable_hlt' Cc: Kevin Hilman Signed-off-by: Govindraj.R [tony@atomide.com: updated to fix omap1 too] Signed-off-by: Tony Lindgren Acked-by: Kevin Hilman diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c index 306beac..f66c329 100644 --- a/arch/arm/mach-omap1/pm.c +++ b/arch/arm/mach-omap1/pm.c @@ -44,6 +44,7 @@ #include #include +#include #include #include #include diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c index a7bdec6..d0c1c96 100644 --- a/arch/arm/mach-omap2/pm.c +++ b/arch/arm/mach-omap2/pm.c @@ -17,6 +17,8 @@ #include #include +#include + #include #include #include "common.h"