Patchwork [(mtd-utils)] Makefile: fixup previous 'make clean' fix

login
register
mail settings
Submitter Brian Norris
Date March 28, 2012, 11:59 p.m.
Message ID <1332979146-8866-1-git-send-email-computersforpeace@gmail.com>
Download mbox | patch
Permalink /patch/149333/
State Accepted
Commit d970b4850204553b8cc3bcba6d7219945b15d67c
Headers show

Comments

Brian Norris - March 28, 2012, 11:59 p.m.
Apparently, Makefile comments need to be made without indentation. Otherwise,
they are printed out as shell commands. This fix prevents seeing this in your
shell during 'make clean':

  $ make clean
  ...
  # findutils v4.1.x (RHEL 4) do not have '+' syntax
  ...

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---

Artem, can you please just merge this into my last Makefile fix?

 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Mike Frysinger - March 29, 2012, 3:30 a.m.
On Wed, Mar 28, 2012 at 19:59, Brian Norris <computersforpeace@gmail.com> wrote:
> Apparently, Makefile comments need to be made without indentation. Otherwise,
> they are printed out as shell commands. This fix prevents seeing this in your
> shell during 'make clean':

Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
Artem Bityutskiy - April 2, 2012, 8:10 a.m.
On Wed, 2012-03-28 at 16:59 -0700, Brian Norris wrote:
> Apparently, Makefile comments need to be made without indentation. Otherwise,
> they are printed out as shell commands. This fix prevents seeing this in your
> shell during 'make clean':

Pushed to mtd-utils.git, thanks!

Patch

diff --git a/Makefile b/Makefile
index 7506ed4..40cb676 100644
--- a/Makefile
+++ b/Makefile
@@ -52,7 +52,7 @@  ifneq ($(BUILDDIR),$(CURDIR))
 endif
 endif
 endif
-	# findutils v4.1.x (RHEL 4) do not have '+' syntax
+# findutils v4.1.x (RHEL 4) do not have '+' syntax
 	@if test -d "$(BUILDDIR)/"; then \
 		$(CLEAN_FIND) -exec rm -f {} + 2> /dev/null || \
 		$(CLEAN_FIND) -exec rm -f {} \; ; \