Patchwork [1/2] powerpc/eeh: remove eeh_event_handler()->daemonize()

login
register
mail settings
Submitter Andrew Morton
Date March 28, 2012, 10:20 p.m.
Message ID <20120328222057.B749EA0363@akpm.mtv.corp.google.com>
Download mbox | patch
Permalink /patch/149319/
State Accepted, archived
Headers show

Comments

Andrew Morton - March 28, 2012, 10:20 p.m.
From: Oleg Nesterov <oleg@redhat.com>
Subject: powerpc/eeh: remove eeh_event_handler()->daemonize()

daemonize() is only needed when a user-space task does kernel_thread().

eeh_event_handler() thread is created by the worker kthread, and thus it
doesn't need the soon-to-be-deprecated daemonize().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Linas Vepstas <linasvepstas@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: Matt Fleming <matt.fleming@intel.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 arch/powerpc/platforms/pseries/eeh_event.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Benjamin Herrenschmidt - March 28, 2012, 11:22 p.m.
On Wed, 2012-03-28 at 15:20 -0700, akpm@linux-foundation.org wrote:
> From: Oleg Nesterov <oleg@redhat.com>
> Subject: powerpc/eeh: remove eeh_event_handler()->daemonize()
> 
> daemonize() is only needed when a user-space task does kernel_thread().
> 
> eeh_event_handler() thread is created by the worker kthread, and thus it
> doesn't need the soon-to-be-deprecated daemonize().

For some reason I thought you were sending that directly to Linus, but
looking at your CC list that's obviously not the case :-) I'll send
them myself.

Cheers,
Ben.

> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> Acked-by: Linas Vepstas <linasvepstas@gmail.com>
> Acked-by: Tejun Heo <tj@kernel.org>
> Acked-by: Matt Fleming <matt.fleming@intel.com>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  arch/powerpc/platforms/pseries/eeh_event.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN arch/powerpc/platforms/pseries/eeh_event.c~powerpc-eeh-remove-eeh_event_handler-daemonize arch/powerpc/platforms/pseries/eeh_event.c
> --- a/arch/powerpc/platforms/pseries/eeh_event.c~powerpc-eeh-remove-eeh_event_handler-daemonize
> +++ a/arch/powerpc/platforms/pseries/eeh_event.c
> @@ -59,7 +59,7 @@ static int eeh_event_handler(void * dumm
>  	struct eeh_event *event;
>  	struct eeh_dev *edev;
>  
> -	daemonize("eehd");
> +	set_task_comm(current, "eehd");
>  	set_current_state(TASK_INTERRUPTIBLE);
>  
>  	spin_lock_irqsave(&eeh_eventlist_lock, flags);
> _

Patch

diff -puN arch/powerpc/platforms/pseries/eeh_event.c~powerpc-eeh-remove-eeh_event_handler-daemonize arch/powerpc/platforms/pseries/eeh_event.c
--- a/arch/powerpc/platforms/pseries/eeh_event.c~powerpc-eeh-remove-eeh_event_handler-daemonize
+++ a/arch/powerpc/platforms/pseries/eeh_event.c
@@ -59,7 +59,7 @@  static int eeh_event_handler(void * dumm
 	struct eeh_event *event;
 	struct eeh_dev *edev;
 
-	daemonize("eehd");
+	set_task_comm(current, "eehd");
 	set_current_state(TASK_INTERRUPTIBLE);
 
 	spin_lock_irqsave(&eeh_eventlist_lock, flags);