diff mbox

[U-Boot] mx6qsabrelite: Fix the serial console port

Message ID 1332963926-31554-1-git-send-email-fabio.estevam@freescale.com
State Awaiting Upstream
Headers show

Commit Message

Fabio Estevam March 28, 2012, 7:45 p.m. UTC
On mx6qsabrelite the console is ttymxc1.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 include/configs/mx6qsabrelite.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Fabio Estevam March 30, 2012, 4:07 p.m. UTC | #1
Hi Stefano,

On Wed, Mar 28, 2012 at 4:45 PM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> On mx6qsabrelite the console is ttymxc1.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Along with the mx28 README patches, this one would be nice to get into
12.03 as well.

Thanks,

Fabio Estevam
Stefano Babic April 1, 2012, 1:35 p.m. UTC | #2
On 28/03/2012 21:45, Fabio Estevam wrote:
> On mx6qsabrelite the console is ttymxc1.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to u-boot-imx after fixing the checkpatch warning:

WARNING: please, no spaces at the start of a line
#30: FILE: include/configs/mx6qsabrelite.h:119:
+       "console=ttymxc1\0" \$

total: 0 errors, 1 warnings, 8 lines checked

Best regards,
Stefano Babic
Marek Vasut April 1, 2012, 4:27 p.m. UTC | #3
Dear Stefano Babic,

> On 28/03/2012 21:45, Fabio Estevam wrote:
> > On mx6qsabrelite the console is ttymxc1.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> 
> Applied to u-boot-imx after fixing the checkpatch warning:

Stefano, do you run this checkpatch stuff by hand on every file or do you have 
some kind of git hook?

> WARNING: please, no spaces at the start of a line
> #30: FILE: include/configs/mx6qsabrelite.h:119:
> +       "console=ttymxc1\0" \$
> 
> total: 0 errors, 1 warnings, 8 lines checked
> 
> Best regards,
> Stefano Babic

Best regards,
Marek Vasut
Stefano Babic April 1, 2012, 4:36 p.m. UTC | #4
On 01/04/2012 18:27, Marek Vasut wrote:
> Dear Stefano Babic,
> 
>> On 28/03/2012 21:45, Fabio Estevam wrote:
>>> On mx6qsabrelite the console is ttymxc1.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>> ---
>>
>> Applied to u-boot-imx after fixing the checkpatch warning:
> 
> Stefano, do you run this checkpatch stuff by hand on every file or do you have 
> some kind of git hook?

I have only a simple script calling checkpatch before git am. It calls
git am and pwclient to change patchwork if everything is ok, to avoid
forgetting to update patch's status. I have not a git hook.

Stefano
diff mbox

Patch

diff --git a/include/configs/mx6qsabrelite.h b/include/configs/mx6qsabrelite.h
index 8bc8a83..2643817 100644
--- a/include/configs/mx6qsabrelite.h
+++ b/include/configs/mx6qsabrelite.h
@@ -116,7 +116,7 @@ 
 #define CONFIG_EXTRA_ENV_SETTINGS \
        "script=boot.scr\0" \
        "uimage=uImage\0" \
-       "console=ttymxc3\0" \
+       "console=ttymxc1\0" \
 	"fdt_high=0xffffffff\0"	  \
 	"initrd_high=0xffffffff\0" \
        "mmcdev=0\0" \