From patchwork Wed Mar 28 12:52:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 149259 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A300DB6F6E for ; Thu, 29 Mar 2012 01:59:08 +1100 (EST) Received: from localhost ([::1]:42831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCsOQ-0008Ig-S9 for incoming@patchwork.ozlabs.org; Wed, 28 Mar 2012 08:54:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCsMx-0005MD-Kk for qemu-devel@nongnu.org; Wed, 28 Mar 2012 08:53:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCsMq-0007q6-SY for qemu-devel@nongnu.org; Wed, 28 Mar 2012 08:52:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39586 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCsMq-0007oP-MG; Wed, 28 Mar 2012 08:52:48 -0400 Received: from relay1.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 83528910A1; Wed, 28 Mar 2012 14:52:46 +0200 (CEST) From: =?UTF-8?q?Andreas=20F=C3=A4rber?= To: qemu-devel@nongnu.org Date: Wed, 28 Mar 2012 14:52:11 +0200 Message-Id: <1332939159-16434-9-git-send-email-afaerber@suse.de> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1332939159-16434-1-git-send-email-afaerber@suse.de> References: <1332939159-16434-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-Received-From: 195.135.220.15 Cc: Stefan Hajnoczi , kvm@suse.de, qemu-stable@nongnu.org, Pavel Borzenkov , Bruce Rogers , =?UTF-8?q?Andreas=20F=C3=A4rber?= Subject: [Qemu-devel] [PATCH stable-0.15 08/36] vmdk: vmdk_read_cid returns garbage if p_name is NULL X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Pavel Borzenkov Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov Signed-off-by: Stefan Hajnoczi (cherry picked from commit 8379e46d1fd681b8aa4714382e2cdab05e5d0575) Signed-off-by: Bruce Rogers Signed-off-by: Andreas Färber --- block/vmdk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 37478d2..b5caa40 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -177,7 +177,7 @@ static void vmdk_free_extents(BlockDriverState *bs) static uint32_t vmdk_read_cid(BlockDriverState *bs, int parent) { char desc[DESC_SIZE]; - uint32_t cid; + uint32_t cid = 0xffffffff; const char *p_name, *cid_str; size_t cid_str_size; BDRVVmdkState *s = bs->opaque;