diff mbox

[U-Boot] drivers/mmc/tegra2_mmc.c: fix GCC 4.6 warning

Message ID 1332942000-4992-1-git-send-email-agust@denx.de
State Accepted
Commit 60e242ed245642f73fc59a3ec39c676910513bbd
Headers show

Commit Message

Anatolij Gustschin March 28, 2012, 1:40 p.m. UTC
Fix:
tegra2_mmc.c: In function 'mmc_send_cmd':
tegra2_mmc.c:230:3: warning: 'mask' may be used uninitialized in this
function [-Wuninitialized]

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Doug Anderson <dianders@chromium.org>
Cc: Tom Warren <twarren@nvidia.com>
---
gcc is wrong here, I think. But I'd like to have a clean
build log.

Anatolij

 drivers/mmc/tegra2_mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Wolfgang Denk March 30, 2012, 8:11 p.m. UTC | #1
Dear Anatolij Gustschin,

In message <1332942000-4992-1-git-send-email-agust@denx.de> you wrote:
> Fix:
> tegra2_mmc.c: In function 'mmc_send_cmd':
> tegra2_mmc.c:230:3: warning: 'mask' may be used uninitialized in this
> function [-Wuninitialized]
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Doug Anderson <dianders@chromium.org>
> Cc: Tom Warren <twarren@nvidia.com>
> ---
> gcc is wrong here, I think. But I'd like to have a clean
> build log.
> 
> Anatolij
> 
>  drivers/mmc/tegra2_mmc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Tom, Albert: hope this is OK with you; it fixes some real issues, and
I want to get clear for -rc1.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/drivers/mmc/tegra2_mmc.c b/drivers/mmc/tegra2_mmc.c
index 33cc8fb..fb8a57d 100644
--- a/drivers/mmc/tegra2_mmc.c
+++ b/drivers/mmc/tegra2_mmc.c
@@ -162,7 +162,7 @@  static int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
 	struct mmc_host *host = (struct mmc_host *)mmc->priv;
 	int flags, i;
 	int result;
-	unsigned int mask;
+	unsigned int mask = 0;
 	unsigned int retry = 0x100000;
 	debug(" mmc_send_cmd called\n");