Patchwork ext3: update documentation with barrier=1 default

login
register
mail settings
Submitter Stefan Hajnoczi
Date March 28, 2012, 8:32 a.m.
Message ID <1332923552-9854-1-git-send-email-stefanha@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/149172/
State Not Applicable
Headers show

Comments

Stefan Hajnoczi - March 28, 2012, 8:32 a.m.
Commit 00eacd6 ("ext3: make ext3 mount default to barrier=1") changed
the default barrier mount option for ext3.  The documentation needs to
be updated, so this patch does that.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 Documentation/filesystems/ext3.txt |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Christoph Hellwig - March 28, 2012, 12:49 p.m.
On Wed, Mar 28, 2012 at 09:32:32AM +0100, Stefan Hajnoczi wrote:
> Commit 00eacd6 ("ext3: make ext3 mount default to barrier=1") changed
> the default barrier mount option for ext3.  The documentation needs to
> be updated, so this patch does that.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Kara - March 29, 2012, 3:29 p.m.
On Wed 28-03-12 14:49:32, Christoph Hellwig wrote:
> On Wed, Mar 28, 2012 at 09:32:32AM +0100, Stefan Hajnoczi wrote:
> > Commit 00eacd6 ("ext3: make ext3 mount default to barrier=1") changed
> > the default barrier mount option for ext3.  The documentation needs to
> > be updated, so this patch does that.
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
  Thanks. I've added the patch to my tree.

								Honza

Patch

diff --git a/Documentation/filesystems/ext3.txt b/Documentation/filesystems/ext3.txt
index b100adc..293855e 100644
--- a/Documentation/filesystems/ext3.txt
+++ b/Documentation/filesystems/ext3.txt
@@ -59,9 +59,9 @@  commit=nrsec	(*)	Ext3 can be told to sync all its data and metadata
 			Setting it to very large values will improve
 			performance.
 
-barrier=<0(*)|1>	This enables/disables the use of write barriers in
-barrier			the jbd code.  barrier=0 disables, barrier=1 enables.
-nobarrier	(*)	This also requires an IO stack which can support
+barrier=<0|1(*)>	This enables/disables the use of write barriers in
+barrier	(*)		the jbd code.  barrier=0 disables, barrier=1 enables.
+nobarrier		This also requires an IO stack which can support
 			barriers, and if jbd gets an error on a barrier
 			write, it will disable again with a warning.
 			Write barriers enforce proper on-disk ordering