Patchwork [ARM] NEON DImode not

login
register
mail settings
Submitter Andrew Stubbs
Date March 27, 2012, 8:23 p.m.
Message ID <4F7221C5.1030607@codesourcery.com>
Download mbox | patch
Permalink /patch/149027/
State New
Headers show

Comments

Andrew Stubbs - March 27, 2012, 8:23 p.m.
On 08/03/12 18:03, Richard Henderson wrote:
> On 03/08/12 08:19, Andrew Stubbs wrote:
>> +   (set_attr "arch" "nota8,*,*,onlya8")
>> +   (set_attr_alternative "insn_enabled"
>> +	[(if_then_else (match_test "TARGET_NEON")
>> +		       (const_string "yes") (const_string "no"))
>> +	 (const_string "yes")
>> +	 (const_string "yes")
>> +	 (if_then_else (match_test "TARGET_NEON")
>> +		       (const_string "yes") (const_string "no"))])]
>>   )
>
> While this works, it might be better to add neon/neon_na8/neon_oa8
> alternatives to the arch attribute, and adjust arch_enabled to match.
>
> Obviously this opinion is non-binding; Richard E might have other plans...

No reply from Richard so far ... so here's an update.

OK now?

Andrew
Richard Henderson - March 27, 2012, 8:43 p.m.
On 03/27/12 13:23, Andrew Stubbs wrote:
> 	gcc/
> 	* config/arm/arm.md (arch): Add neon_onlya8 and neon_nota8.
> 	(arch_enabled): Handle new arch types.
> 	(one_cmpldi2): Add NEON support.

Looks good to me.


r~
Ramana Radhakrishnan - March 28, 2012, 1:37 p.m.
On 27 March 2012 21:23, Andrew Stubbs <ams@codesourcery.com> wrote:
> On 08/03/12 18:03, Richard Henderson wrote:
>>
>> On 03/08/12 08:19, Andrew Stubbs wrote:
>>>
>>> +   (set_attr "arch" "nota8,*,*,onlya8")
>>> +   (set_attr_alternative "insn_enabled"
>>> +       [(if_then_else (match_test "TARGET_NEON")
>>> +                      (const_string "yes") (const_string "no"))
>>> +        (const_string "yes")
>>> +        (const_string "yes")
>>> +        (if_then_else (match_test "TARGET_NEON")
>>> +                      (const_string "yes") (const_string "no"))])]
>>>  )
>>
>>
>> While this works, it might be better to add neon/neon_na8/neon_oa8
>> alternatives to the arch attribute, and adjust arch_enabled to match.
>>
>> Obviously this opinion is non-binding; Richard E might have other plans...
>
>
> No reply from Richard so far ... so here's an update.
>
> OK now?

OK if no regressions.

Ramana

>
> Andrew

Patch

2012-03-27  Andrew Stubbs  <ams@codesourcery.com>

	gcc/
	* config/arm/arm.md (arch): Add neon_onlya8 and neon_nota8.
	(arch_enabled): Handle new arch types.
	(one_cmpldi2): Add NEON support.

diff --git a/gcc/config/arm/arm.md b/gcc/config/arm/arm.md
index 751997f..6669329 100644
--- a/gcc/config/arm/arm.md
+++ b/gcc/config/arm/arm.md
@@ -207,7 +207,7 @@ 
 ; for ARM or Thumb-2 with arm_arch6, and nov6 for ARM without
 ; arm_arch6.  This attribute is used to compute attribute "enabled",
 ; use type "any" to enable an alternative in all cases.
-(define_attr "arch" "any,a,t,32,t1,t2,v6,nov6,onlya8,nota8"
+(define_attr "arch" "any,a,t,32,t1,t2,v6,nov6,onlya8,neon_onlya8,nota8,neon_nota8"
   (const_string "any"))
 
 (define_attr "arch_enabled" "no,yes"
@@ -246,8 +246,18 @@ 
 	      (eq_attr "tune" "cortexa8"))
 	 (const_string "yes")
 
+	 (and (eq_attr "arch" "neon_onlya8")
+	      (eq_attr "tune" "cortexa8")
+	      (match_test "TARGET_NEON"))
+	 (const_string "yes")
+
 	 (and (eq_attr "arch" "nota8")
 	      (not (eq_attr "tune" "cortexa8")))
+	 (const_string "yes")
+
+	 (and (eq_attr "arch" "neon_nota8")
+	      (not (eq_attr "tune" "cortexa8"))
+	      (match_test "TARGET_NEON"))
 	 (const_string "yes")]
 	(const_string "no")))
 
@@ -4207,11 +4217,16 @@ 
   "")
 
 (define_insn_and_split "one_cmpldi2"
-  [(set (match_operand:DI 0 "s_register_operand" "=&r,&r")
-	(not:DI (match_operand:DI 1 "s_register_operand" "0,r")))]
+  [(set (match_operand:DI 0 "s_register_operand"	 "=w,&r,&r,?w")
+	(not:DI (match_operand:DI 1 "s_register_operand" " w, 0, r, w")))]
   "TARGET_32BIT"
-  "#"
-  "TARGET_32BIT && reload_completed"
+  "@
+   vmvn\t%P0, %P1
+   #
+   #
+   vmvn\t%P0, %P1"
+  "TARGET_32BIT && reload_completed
+   && arm_general_register_operand (operands[0], DImode)"
   [(set (match_dup 0) (not:SI (match_dup 1)))
    (set (match_dup 2) (not:SI (match_dup 3)))]
   "
@@ -4221,8 +4236,10 @@ 
     operands[3] = gen_highpart (SImode, operands[1]);
     operands[1] = gen_lowpart (SImode, operands[1]);
   }"
-  [(set_attr "length" "8")
-   (set_attr "predicable" "yes")]
+  [(set_attr "length" "*,8,8,*")
+   (set_attr "predicable" "yes")
+   (set_attr "neon_type" "neon_int_1,*,*,neon_int_1")
+   (set_attr "arch" "neon_nota8,*,*,neon_onlya8")]
 )
 
 (define_expand "one_cmplsi2"