Patchwork configure: fix mingw32 libs_qga typo

login
register
mail settings
Submitter Stefan Hajnoczi
Date March 27, 2012, 7:26 a.m.
Message ID <1332833178-18521-1-git-send-email-stefanha@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/148919/
State New
Headers show

Comments

Stefan Hajnoczi - March 27, 2012, 7:26 a.m.
It's typical to prepend or append parameters to an argument string so
that other places in ./configure can add parameters without clobbering
the string.  In the mingw32 libs_qga case there is a typo "$lib_qga"
instead of "$libs_qga".

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Andreas Färber - March 27, 2012, 2:19 p.m.
Am 27.03.2012 09:26, schrieb Stefan Hajnoczi:
> It's typical to prepend or append parameters to an argument string so
> that other places in ./configure can add parameters without clobbering
> the string.  In the mingw32 libs_qga case there is a typo "$lib_qga"
> instead of "$libs_qga".
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Reviewed-by: Andreas Färber <afaerber@suse.de>

Andreas

> ---
>  configure |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/configure b/configure
> index 14ef738..d63c011 100755
> --- a/configure
> +++ b/configure
> @@ -526,7 +526,7 @@ EOF
>    bindir="\${prefix}"
>    sysconfdir="\${prefix}"
>    confsuffix=""
> -  libs_qga="-lws2_32 -lwinmm -lpowrprof $lib_qga"
> +  libs_qga="-lws2_32 -lwinmm -lpowrprof $libs_qga"
>  fi
>  
>  werror=""
Stefan Hajnoczi - March 27, 2012, 2:49 p.m.
On Tue, Mar 27, 2012 at 08:26:18AM +0100, Stefan Hajnoczi wrote:
> It's typical to prepend or append parameters to an argument string so
> that other places in ./configure can add parameters without clobbering
> the string.  In the mingw32 libs_qga case there is a typo "$lib_qga"
> instead of "$libs_qga".
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
>  configure |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/configure b/configure
index 14ef738..d63c011 100755
--- a/configure
+++ b/configure
@@ -526,7 +526,7 @@  EOF
   bindir="\${prefix}"
   sysconfdir="\${prefix}"
   confsuffix=""
-  libs_qga="-lws2_32 -lwinmm -lpowrprof $lib_qga"
+  libs_qga="-lws2_32 -lwinmm -lpowrprof $libs_qga"
 fi
 
 werror=""