Patchwork [U-Boot,RESEND] ARM: Exynos4: ADC: Universal_C210: Enable LDO4 power line for ADC measurement

login
register
mail settings
Submitter Łukasz Majewski
Date March 27, 2012, 7:53 a.m.
Message ID <1332834828-21740-1-git-send-email-l.majewski@samsung.com>
Download mbox | patch
Permalink /patch/148877/
State Accepted
Commit 4d86bf086009a4edfe747341e7cb83bf46e6f022
Delegated to: Minkyu Kang
Headers show

Comments

Łukasz Majewski - March 27, 2012, 7:53 a.m.
This patch enables LDO4 power line for preparing proper voltages to be
measured by ADC converter.
This measurement is used for determination of target board HW revision.

Test HW:
Universal_C210 (Exynos4210) rev. 0.0

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Minkyu Kang <mk7.kang@samsung.com>
---
 board/samsung/universal_c210/universal.c |   25 ++++++++++++++++++++++---
 include/max8998_pmic.h                   |    1 +
 2 files changed, 23 insertions(+), 3 deletions(-)
Minkyu Kang - April 2, 2012, 2:07 a.m.
Dear Lukasz Majewski,

On 27 March 2012 16:53, Lukasz Majewski <l.majewski@samsung.com> wrote:
> This patch enables LDO4 power line for preparing proper voltages to be
> measured by ADC converter.
> This measurement is used for determination of target board HW revision.
>
> Test HW:
> Universal_C210 (Exynos4210) rev. 0.0
>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> ---
>  board/samsung/universal_c210/universal.c |   25 ++++++++++++++++++++++---
>  include/max8998_pmic.h                   |    1 +
>  2 files changed, 23 insertions(+), 3 deletions(-)
>

applied to u-boot-samsung

Patch

diff --git a/board/samsung/universal_c210/universal.c b/board/samsung/universal_c210/universal.c
index 334a346..70f03e9 100644
--- a/board/samsung/universal_c210/universal.c
+++ b/board/samsung/universal_c210/universal.c
@@ -59,13 +59,13 @@  int board_init(void)
 	gd->bd->bi_arch_number = MACH_TYPE_UNIVERSAL_C210;
 	gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
 
-	check_hw_revision();
-	printf("HW Revision:\t0x%x\n", board_rev);
-
 #if defined(CONFIG_PMIC)
 	pmic_init();
 #endif
 
+	check_hw_revision();
+	printf("HW Revision:\t0x%x\n", board_rev);
+
 	return 0;
 }
 
@@ -110,10 +110,27 @@  static unsigned short get_adc_value(int channel)
 	return ret;
 }
 
+static int adc_power_control(int on)
+{
+	int ret;
+	struct pmic *p = get_pmic();
+
+	if (pmic_probe(p))
+		return -1;
+
+	ret = pmic_set_output(p,
+			      MAX8998_REG_ONOFF1,
+			      MAX8998_LDO4, !!on);
+
+	return ret;
+}
+
 static unsigned int get_hw_revision(void)
 {
 	int hwrev, mode0, mode1;
 
+	adc_power_control(1);
+
 	mode0 = get_adc_value(1);		/* HWREV_MODE0 */
 	mode1 = get_adc_value(2);		/* HWREV_MODE1 */
 
@@ -136,6 +153,8 @@  static unsigned int get_hw_revision(void)
 
 	debug("mode0: %d, mode1: %d, hwrev 0x%x\n", mode0, mode1, hwrev);
 
+	adc_power_control(0);
+
 	return hwrev;
 }
 
diff --git a/include/max8998_pmic.h b/include/max8998_pmic.h
index 10c892a..ca21f88 100644
--- a/include/max8998_pmic.h
+++ b/include/max8998_pmic.h
@@ -75,6 +75,7 @@  enum {
 };
 
 #define MAX8998_LDO3		(1 << 2)
+#define MAX8998_LDO4		(1 << 1)
 #define MAX8998_LDO8		(1 << 5)
 #define MAX8998_SAFEOUT1	(1 << 4)