Patchwork [v2,3/3] Add ofono package.

login
register
mail settings
Submitter Marek Belisko
Date March 26, 2012, 8:12 p.m.
Message ID <1332792756-3381-4-git-send-email-marek.belisko@open-nandra.com>
Download mbox | patch
Permalink /patch/148829/
State Superseded
Headers show

Comments

Marek Belisko - March 26, 2012, 8:12 p.m.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
 package/Config.in       |    1 +
 package/ofono/Config.in |   20 ++++++++++++++++++++
 package/ofono/ofono.mk  |   25 +++++++++++++++++++++++++
 3 files changed, 46 insertions(+), 0 deletions(-)
 create mode 100644 package/ofono/Config.in
 create mode 100644 package/ofono/ofono.mk
Arnout Vandecappelle - March 28, 2012, 9:48 p.m.
On Monday 26 March 2012 22:12:36 Marek Belisko wrote:
[snip]
> diff --git a/package/ofono/Config.in b/package/ofono/Config.in
> new file mode 100644
> index 0000000..b10e42d
> --- /dev/null
> +++ b/package/ofono/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_OFONO
> +	bool "ofono"
> +	select BR2_PACKAGE_LIBCAP_NG
> +	select BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_PACKAGE_MOBILE_BROADBAND_PROVIDER_INFO

 Missing
	depends on BR2_USE_WCHAR # gettext/libglib2

 which also means you need a comment in case we don't have WCHAR.

> +	helpimplies
> +	  oFono.org is a place to bring developers together around designing an
> +	  infrastructure for building mobile telephony (GSM/UMTS) applications.

 This doesn't really explain what the package does.  Also, a link to a
website is convenient.

> +
> +if BR2_PACKAGE_OFONO
> +
> +config BR2_PACKAGE_OFONO_BLUETOOTH
> +        bool "ofono with bluetooth support"
> +	select BR2_PACKAGE_BLUEZ_UTILS
> +        help
> +	  Enable bluetooh support.
> +endif

 There's some funky whitespace here.  Also a type: bluetooh -> bluetooth

> +
> +

 No empty lines at the end of the file please.

> diff --git a/package/ofono/ofono.mk b/package/ofono/ofono.mk
> new file mode 100644
> index 0000000..e408a61
> --- /dev/null
> +++ b/package/ofono/ofono.mk
> @@ -0,0 +1,25 @@
> +#############################################################
> +#
> +# ofono
> +#
> +#############################################################
> +OFONO_VERSION = 1.5
> +OFONO_SITE = git://git.kernel.org/pub/scm/network/ofono/ofono.git

 Why not use the tar from $(BR2_KERNEL_MIRROR)/linux/network/ofono ?

> +
> +OFONO_DEPENDENCIES = host-pkg-config libglib2 dbus libcap-ng mobile-broadband-provider-info
> +
> +OFONO_CONF_OPT = --disable-test --disable-bluetooth

 The --disable-bluetooth should be in the else of the OFONO_BLUETOOTH
option.

> +
> +OFONO_AUTORECONF = YES

 Not needed if you use the tar.

> +
> +ifneq ($(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV),y)
> +	OFONO_CONF_OPT += --disable-udev
> +endif

 It's better to use --enable-udev explicitly in the positive case, and
you probably need to add udev to DEPENDENCIES anyway.

 Also it's more logical to check for BR2_PACKAGE_UDEV.


 Regards,
 Arnout

> +
> +ifeq ($(BR2_PACKAGE_OFONO_BLUETOOTH),y)
> +	OFONO_CONF_OPT += --enable-bluetooth
> +	OFONO_DEPENDENCIES += bluez_utils
> +endif
> +
> +$(eval $(call AUTOTARGETS))
> +
>
Belisko Marek - March 31, 2012, 1:24 p.m.
On Wed, Mar 28, 2012 at 11:48 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> On Monday 26 March 2012 22:12:36 Marek Belisko wrote:
> [snip]
>> diff --git a/package/ofono/Config.in b/package/ofono/Config.in
>> new file mode 100644
>> index 0000000..b10e42d
>> --- /dev/null
>> +++ b/package/ofono/Config.in
>> @@ -0,0 +1,20 @@
>> +config BR2_PACKAGE_OFONO
>> +     bool "ofono"
>> +     select BR2_PACKAGE_LIBCAP_NG
>> +     select BR2_PACKAGE_DBUS
>> +     select BR2_PACKAGE_LIBGLIB2
>> +     select BR2_PACKAGE_MOBILE_BROADBAND_PROVIDER_INFO
>
>  Missing
>        depends on BR2_USE_WCHAR # gettext/libglib2
>
>  which also means you need a comment in case we don't have WCHAR.
>
>> +     helpimplies
>> +       oFono.org is a place to bring developers together around designing an
>> +       infrastructure for building mobile telephony (GSM/UMTS) applications.
>
>  This doesn't really explain what the package does.  Also, a link to a
> website is convenient.
>
>> +
>> +if BR2_PACKAGE_OFONO
>> +
>> +config BR2_PACKAGE_OFONO_BLUETOOTH
>> +        bool "ofono with bluetooth support"
>> +     select BR2_PACKAGE_BLUEZ_UTILS
>> +        help
>> +       Enable bluetooh support.
>> +endif
>
>  There's some funky whitespace here.  Also a type: bluetooh -> bluetooth
>
>> +
>> +
>
>  No empty lines at the end of the file please.
>
>> diff --git a/package/ofono/ofono.mk b/package/ofono/ofono.mk
>> new file mode 100644
>> index 0000000..e408a61
>> --- /dev/null
>> +++ b/package/ofono/ofono.mk
>> @@ -0,0 +1,25 @@
>> +#############################################################
>> +#
>> +# ofono
>> +#
>> +#############################################################
>> +OFONO_VERSION = 1.5
>> +OFONO_SITE = git://git.kernel.org/pub/scm/network/ofono/ofono.git
>
>  Why not use the tar from $(BR2_KERNEL_MIRROR)/linux/network/ofono ?
Ok will do.
>
>> +
>> +OFONO_DEPENDENCIES = host-pkg-config libglib2 dbus libcap-ng mobile-broadband-provider-info
>> +
>> +OFONO_CONF_OPT = --disable-test --disable-bluetooth
>
>  The --disable-bluetooth should be in the else of the OFONO_BLUETOOTH
> option.
>
>> +
>> +OFONO_AUTORECONF = YES
When switch to tar version without this line it can' t configure because
./configure doesn't exist (just bootstrap)
>
>  Not needed if you use the tar.
>
>> +
>> +ifneq ($(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV),y)
>> +     OFONO_CONF_OPT += --disable-udev
>> +endif
>
>  It's better to use --enable-udev explicitly in the positive case, and
> you probably need to add udev to DEPENDENCIES anyway.
ofono have by default udev enabled. For systems where udev isn't available
could be also used (just need to created /dev entry for modem by hand).
What about something like that:
+ifeq ($(BR2_PACKAGE_UDEV),y)
+	OFONO_CONF_OPT += --enable-udev
+	OFONO_DEPENDENCIES += udev
+else
+	OFONO_CONF_OPT += --disable-udev
+endif

For target with udev it will be used otherwise not.
>
>  Also it's more logical to check for BR2_PACKAGE_UDEV.
>
>
>  Regards,
>  Arnout
>
>> +
>> +ifeq ($(BR2_PACKAGE_OFONO_BLUETOOTH),y)
>> +     OFONO_CONF_OPT += --enable-bluetooth
>> +     OFONO_DEPENDENCIES += bluez_utils
>> +endif
>> +
>> +$(eval $(call AUTOTARGETS))
>> +
>>
>
> --
> Arnout Vandecappelle                               arnout at mind be
> Senior Embedded Software Architect                 +32-16-286540
> Essensium/Mind                                     http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

regards,

marek

Patch

diff --git a/package/Config.in b/package/Config.in
index cd41eb9..4dfbce4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -201,6 +201,7 @@  source "package/memtester/Config.in"
 source "package/minicom/Config.in"
 source "package/mtd/Config.in"
 source "package/ntfs-3g/Config.in"
+source "package/ofono/Config.in"
 source "package/open2300/Config.in"
 source "package/openocd/Config.in"
 source "package/parted/Config.in"
diff --git a/package/ofono/Config.in b/package/ofono/Config.in
new file mode 100644
index 0000000..b10e42d
--- /dev/null
+++ b/package/ofono/Config.in
@@ -0,0 +1,20 @@ 
+config BR2_PACKAGE_OFONO
+	bool "ofono"
+	select BR2_PACKAGE_LIBCAP_NG
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_MOBILE_BROADBAND_PROVIDER_INFO
+	help
+	  oFono.org is a place to bring developers together around designing an
+	  infrastructure for building mobile telephony (GSM/UMTS) applications.
+
+if BR2_PACKAGE_OFONO
+
+config BR2_PACKAGE_OFONO_BLUETOOTH
+        bool "ofono with bluetooth support"
+	select BR2_PACKAGE_BLUEZ_UTILS
+        help
+	  Enable bluetooh support.
+endif
+
+
diff --git a/package/ofono/ofono.mk b/package/ofono/ofono.mk
new file mode 100644
index 0000000..e408a61
--- /dev/null
+++ b/package/ofono/ofono.mk
@@ -0,0 +1,25 @@ 
+#############################################################
+#
+# ofono
+#
+#############################################################
+OFONO_VERSION = 1.5
+OFONO_SITE = git://git.kernel.org/pub/scm/network/ofono/ofono.git
+
+OFONO_DEPENDENCIES = host-pkg-config libglib2 dbus libcap-ng mobile-broadband-provider-info
+
+OFONO_CONF_OPT = --disable-test --disable-bluetooth
+
+OFONO_AUTORECONF = YES
+
+ifneq ($(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV),y)
+	OFONO_CONF_OPT += --disable-udev
+endif
+
+ifeq ($(BR2_PACKAGE_OFONO_BLUETOOTH),y)
+	OFONO_CONF_OPT += --enable-bluetooth
+	OFONO_DEPENDENCIES += bluez_utils
+endif
+
+$(eval $(call AUTOTARGETS))
+