Patchwork ARM: 3ds_debugboard: Fix smsc911x driver probe

login
register
mail settings
Submitter Fabio Estevam
Date March 26, 2012, 6:53 p.m.
Message ID <1332788037-31064-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/148812/
State New
Headers show

Comments

Fabio Estevam - March 26, 2012, 6:53 p.m.
Fix smsc911x id field in order to fix smsc911x driver probe error:

smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517
smsc911x smsc911x.0: (unregistered net_device): couldn't get regulators -517
platform smsc911x.0: Driver smsc911x requests probe deferral

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/plat-mxc/3ds_debugboard.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Sascha Hauer - March 27, 2012, 8:56 a.m.
On Mon, Mar 26, 2012 at 03:53:57PM -0300, Fabio Estevam wrote:
> Fix smsc911x id field in order to fix smsc911x driver probe error:
> 
> smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517
> smsc911x smsc911x.0: (unregistered net_device): couldn't get regulators -517
> platform smsc911x.0: Driver smsc911x requests probe deferral

Looks good. I couldn't test it on the 3ds board. Could you collect your
patches until the beginning of next week? I'm on holidays right now and
will be back next week.

Sascha

> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/plat-mxc/3ds_debugboard.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-mxc/3ds_debugboard.c b/arch/arm/plat-mxc/3ds_debugboard.c
> index d1e31fa..5cac2c5 100644
> --- a/arch/arm/plat-mxc/3ds_debugboard.c
> +++ b/arch/arm/plat-mxc/3ds_debugboard.c
> @@ -80,7 +80,7 @@ static struct smsc911x_platform_config smsc911x_config = {
>  
>  static struct platform_device smsc_lan9217_device = {
>  	.name = "smsc911x",
> -	.id = 0,
> +	.id = -1,
>  	.dev = {
>  		.platform_data = &smsc911x_config,
>  	},
> -- 
> 1.7.1
> 
> 
>
Sascha Hauer - April 2, 2012, 9:15 a.m.
On Mon, Mar 26, 2012 at 03:53:57PM -0300, Fabio Estevam wrote:
> Fix smsc911x id field in order to fix smsc911x driver probe error:
> 
> smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517
> smsc911x smsc911x.0: (unregistered net_device): couldn't get regulators -517
> platform smsc911x.0: Driver smsc911x requests probe deferral
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Applied, thanks

Sascha

> ---
>  arch/arm/plat-mxc/3ds_debugboard.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-mxc/3ds_debugboard.c b/arch/arm/plat-mxc/3ds_debugboard.c
> index d1e31fa..5cac2c5 100644
> --- a/arch/arm/plat-mxc/3ds_debugboard.c
> +++ b/arch/arm/plat-mxc/3ds_debugboard.c
> @@ -80,7 +80,7 @@ static struct smsc911x_platform_config smsc911x_config = {
>  
>  static struct platform_device smsc_lan9217_device = {
>  	.name = "smsc911x",
> -	.id = 0,
> +	.id = -1,
>  	.dev = {
>  		.platform_data = &smsc911x_config,
>  	},
> -- 
> 1.7.1
> 
> 
>

Patch

diff --git a/arch/arm/plat-mxc/3ds_debugboard.c b/arch/arm/plat-mxc/3ds_debugboard.c
index d1e31fa..5cac2c5 100644
--- a/arch/arm/plat-mxc/3ds_debugboard.c
+++ b/arch/arm/plat-mxc/3ds_debugboard.c
@@ -80,7 +80,7 @@  static struct smsc911x_platform_config smsc911x_config = {
 
 static struct platform_device smsc_lan9217_device = {
 	.name = "smsc911x",
-	.id = 0,
+	.id = -1,
 	.dev = {
 		.platform_data = &smsc911x_config,
 	},