Patchwork [Lucid,00/10] Backport killable request_module()

login
register
mail settings
Submitter Tim Gardner
Date March 26, 2012, 6:01 p.m.
Message ID <1332784903-75063-1-git-send-email-tim.gardner@canonical.com>
Download mbox
Permalink /patch/148795/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/rtg/ubuntu-lucid.git lp963685-usermode-helper

Comments

Tim Gardner - March 26, 2012, 6:01 p.m.
The following changes since commit a21c77713c589069b93a82f44c29e282f36aea05:

  UBUNTU: Bump ABI (2012-03-26 11:55:19 -0600)

are available in the git repository at:

  git://kernel.ubuntu.com/rtg/ubuntu-lucid.git lp963685-usermode-helper

for you to fetch changes up to c610bda0b22a8774f22d8cc0d0575d3783d3306f:

  UBUNTU: SAUCE: ubuntu drivers: use UMH_WAIT_PROC consistently (2012-03-26 11:55:38 -0600)

----------------------------------------------------------------
Masami Hiramatsu (1):
      kmod: fix resource leak in call_usermodehelper_pipe()

Neil Horman (1):
      kmod: add init function to usermodehelper

Oleg Nesterov (7):
      usermodehelper: use UMH_WAIT_PROC consistently
      usermodehelper: introduce umh_complete(sub_info)
      usermodehelper: implement UMH_KILLABLE
      usermodehelper: kill umh_wait, renumber UMH_* constants
      usermodehelper: ____call_usermodehelper() doesn't need do_exit()
      kmod: introduce call_modprobe() helper
      kmod: make __request_module() killable

Tim Gardner (1):
      UBUNTU: SAUCE: ubuntu drivers: use UMH_WAIT_PROC consistently

 drivers/staging/rtl8187se/r8180_core.c |    2 +-
 drivers/video/uvesafb.c                |    2 +-
 include/linux/kmod.h                   |   54 ++++++++++---
 kernel/kmod.c                          |  141 +++++++++++++++++++++++---------
 kernel/sys.c                           |    6 +-
 net/bridge/br_stp_if.c                 |    2 +-
 security/tomoyo/common.c               |    2 +-
 ubuntu/fsam7400/fsam7400.c             |    4 +-
 ubuntu/ndiswrapper/loader.c            |    6 +-
 ubuntu/rtl8192se/rtl_dm.c              |    6 +-
 10 files changed, 159 insertions(+), 66 deletions(-)
Stefan Bader - March 27, 2012, 8:59 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 26.03.2012 20:01, Tim Gardner wrote:
> The following changes since commit
> a21c77713c589069b93a82f44c29e282f36aea05:
> 
> UBUNTU: Bump ABI (2012-03-26 11:55:19 -0600)
> 
> are available in the git repository at:
> 
> git://kernel.ubuntu.com/rtg/ubuntu-lucid.git lp963685-usermode-helper
> 
> for you to fetch changes up to c610bda0b22a8774f22d8cc0d0575d3783d3306f:
> 
> UBUNTU: SAUCE: ubuntu drivers: use UMH_WAIT_PROC consistently (2012-03-26
> 11:55:38 -0600)
> 
> ---------------------------------------------------------------- Masami
> Hiramatsu (1): kmod: fix resource leak in call_usermodehelper_pipe()
> 
> Neil Horman (1): kmod: add init function to usermodehelper
> 
> Oleg Nesterov (7): usermodehelper: use UMH_WAIT_PROC consistently 
> usermodehelper: introduce umh_complete(sub_info) usermodehelper: implement
> UMH_KILLABLE usermodehelper: kill umh_wait, renumber UMH_* constants 
> usermodehelper: ____call_usermodehelper() doesn't need do_exit() kmod:
> introduce call_modprobe() helper kmod: make __request_module() killable
> 
> Tim Gardner (1): UBUNTU: SAUCE: ubuntu drivers: use UMH_WAIT_PROC
> consistently
> 
> drivers/staging/rtl8187se/r8180_core.c |    2 +- drivers/video/uvesafb.c
> |    2 +- include/linux/kmod.h                   |   54 ++++++++++--- 
> kernel/kmod.c                          |  141
> +++++++++++++++++++++++--------- kernel/sys.c                           |
> 6 +- net/bridge/br_stp_if.c                 |    2 +- 
> security/tomoyo/common.c               |    2 +- ubuntu/fsam7400/fsam7400.c
> |    4 +- ubuntu/ndiswrapper/loader.c            |    6 +- 
> ubuntu/rtl8192se/rtl_dm.c              |    6 +- 10 files changed, 159
> insertions(+), 66 deletions(-)
> 
AFAICS the two additional patches are required and do not look like they could
have introduced the issue in the first place. The remainder patches look like
the set for other releases.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCgAGBQJPcYGGAAoJEOhnXe7L7s6j1CwP/1cwQ80xRRU2qPpWe5arMNvg
MyxHbomj1VOB/nozKR/KHvippTkbbkQYCn8M3lQ0hXT7Moh0kem+X/aI6qBS8Zhc
CYxTbyDpakZq5AU7VaN9VolzrcacYd0QrkSa2K7ziP1T+6IgilAFZfCwnL1754UU
x51UQhar3LGvgsY0i7kBKSyLwhhg43qmTRXwQdzfJX99S7DfCBSsuMJXCOwvoqA3
POibj75RX3ph9/pG46+aWIP56cPzU6m2TWsMYtHbSrqx39HoQgq4hcCB6vSoX+0s
OKyJggO1cIMfruiuuuhdwNLWfPeCrw0GaAXkHDLwPmfkBmx5/XmSARxs6LzTuW1P
YePiPAqZhS7ZLve61HKYvjhEywU4ovfuCMlj1Acb2/H3A31OOgM580IXHhc0mAHe
begeA/DD+JzWpjAQmQ6W7GQZqYEPCPMNTBZi8DXZ3JhKuFQXQFiuzJ/x3bMvASAf
QK1fKXN91WRkNsD1BDSukRXXm8+kVdi9vG7rpA4IkOphP2doX9VfryBxVe78SagA
d7Nhd01Kjj2T6GtCthBiaE5LvAp4f3jpLodSoQNpiueFT1XrKcZ/MypPV7KOFhtX
ppppI8cdCXFRpIW0+Hm1k/ljRqAnJdimukDIyOuhDHuU9q6FATO3KgJU4CD900J9
AOrBaSsWtxsqTOxD6RwJ
=H9iK
-----END PGP SIGNATURE-----
Andy Whitcroft - March 27, 2012, 1:01 p.m.
This is a heafty pile of patches, but many are pretty small overall.
The upstream references look ok.  It should be easy to test, systems
should stop booting right if this is wrong.  As this is a user
triggerable DOS and assuming some testing:

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw
Tim Gardner - March 27, 2012, 1:19 p.m.