Patchwork [2/2] smsc911x: fix platform resource call during module unload

login
register
mail settings
Submitter Steve Glendinning
Date Dec. 19, 2008, 6:05 p.m.
Message ID <1229709930-19925-2-git-send-email-steve.glendinning@smsc.com>
Download mbox | patch
Permalink /patch/14870/
State Accepted
Delegated to: David Miller
Headers show

Comments

Steve Glendinning - Dec. 19, 2008, 6:05 p.m.
This patch fixes a typo, the platform_get_resource calls in
smsc911x_drv_remove are supposed to look the same as those in
smsc911x_drv_probe.

Reported and fixed by dfoley@telus.net.

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
---
 drivers/net/smsc911x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - Dec. 26, 2008, 12:44 a.m.
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Fri, 19 Dec 2008 18:05:30 +0000

> This patch fixes a typo, the platform_get_resource calls in
> smsc911x_drv_remove are supposed to look the same as those in
> smsc911x_drv_probe.
> 
> Reported and fixed by dfoley@telus.net.
> 
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>

Also applied, thanks Steve.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
index cd925de..a33c5fc 100644
--- a/drivers/net/smsc911x.c
+++ b/drivers/net/smsc911x.c
@@ -1871,7 +1871,7 @@  static int __devexit smsc911x_drv_remove(struct platform_device *pdev)
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
 					   "smsc911x-memory");
 	if (!res)
-		platform_get_resource(pdev, IORESOURCE_MEM, 0);
+		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 
 	release_mem_region(res->start, res->end - res->start);