Patchwork [1/2] smsc911x: don't clobber driver_data

login
register
mail settings
Submitter Steve Glendinning
Date Dec. 19, 2008, 6:05 p.m.
Message ID <1229709930-19925-1-git-send-email-steve.glendinning@smsc.com>
Download mbox | patch
Permalink /patch/14869/
State Accepted
Delegated to: David Miller
Headers show

Comments

Steve Glendinning - Dec. 19, 2008, 6:05 p.m.
smsc911x uses driver_data to store our net_device, don't overwrite this
with the mii_bus.

Reported and fixed by dfoley@telus.net.

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
---
 drivers/net/smsc911x.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
David Miller - Dec. 26, 2008, 12:43 a.m.
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Fri, 19 Dec 2008 18:05:29 +0000

> smsc911x uses driver_data to store our net_device, don't overwrite this
> with the mii_bus.
> 
> Reported and fixed by dfoley@telus.net.
> 
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
index fa28542..cd925de 100644
--- a/drivers/net/smsc911x.c
+++ b/drivers/net/smsc911x.c
@@ -822,7 +822,6 @@  static int __devinit smsc911x_mii_init(struct platform_device *pdev,
 		pdata->mii_bus->irq[i] = PHY_POLL;
 
 	pdata->mii_bus->parent = &pdev->dev;
-	dev_set_drvdata(&pdev->dev, &pdata->mii_bus);
 
 	pdata->using_extphy = 0;