Patchwork [Oneiric,5/8] usermodehelper: ____call_usermodehelper() doesn't need do_exit()

login
register
mail settings
Submitter Tim Gardner
Date March 26, 2012, 1:28 a.m.
Message ID <1332725337-58475-5-git-send-email-tim.gardner@canonical.com>
Download mbox | patch
Permalink /patch/148617/
State New
Headers show

Comments

Tim Gardner - March 26, 2012, 1:28 a.m.
From: Oleg Nesterov <oleg@redhat.com>

BugLink: http://bugs.launchpad.net/bugs/963685

Minor cleanup.  ____call_usermodehelper() can simply return, no need to
call do_exit() explicitely.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Tejun Heo <tj@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
(cherry picked from commit 5b9bd473e3b8a8c6c4ae99be475e6e9b27568555)

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 kernel/kmod.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/kernel/kmod.c b/kernel/kmod.c
index 8a65e78..2cca9ee 100644
--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -186,7 +186,7 @@  static int ____call_usermodehelper(void *data)
 	/* Exec failed? */
 fail:
 	sub_info->retval = retval;
-	do_exit(0);
+	return 0;
 }
 
 void call_usermodehelper_freeinfo(struct subprocess_info *info)