diff mbox

[U-Boot,v5] kirkwood: add NAS62x0 board support

Message ID 20120325193143.GA15450@w500.iskon.local
State Superseded
Delegated to: Prafulla Wadaskar
Headers show

Commit Message

Luka Perkov March 25, 2012, 7:31 p.m. UTC
Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220.

Only difference between boards is number of SATA ports.

More information about the boards can be found here:

http://www.raidsonic.de/en/products/nas-systems.php?we_objectID=7036
http://www.raidsonic.de/en/products/nas-systems.php?we_objectID=7515

Signed-off-by: Luka Perkov <uboot@lukaperkov.net>
Signed-off-by: Gerald Kerma <dreagle@doukki.net>
Signed-off-by: Simon Baatz <gmbnomis@gmail.com>
---

Changes from version v1:

 * use tools/checkpatch.pl to locate patch errors and fix them
 * add two entries in boards.cfg, one for each board
 * fixed CONFIG_RESET_PHY_R
 * don't define values for macros that enable features only
 * remove static RAM configuration
 * fix comments
 * use only CONFIG_ENV_OFFSET and remove CONFIG_ENV_ADDR
 * clean coding style
 * add entry in MAINTAINERS file

Changes from version v2:

 * use defined() in macros for board selection for robustness

Changes from version v3:

 * don't use utf8 for Geralds name
 * don't mix upper/lower case in kwbimage.cfg
 * fix prompt

Changes from version v4:
 * fix board Makefile (clean and distclean)
 * use generic way to handle arch number of the board
 * fix MAINTAINERS file
 * move code from Marvell to raidsonic folder
 * use CONFIG_MACH_TYPE 
 * set only necessary GPIOs 
 * use link instead of address for license
 * add few links about board being supported for quick reference
 * add previous change logs
 * multiple updates to kwbimage.cfg, thank you Simon

About kwbimage.cfg - first version was taken from sheevaplug with change only
regarding memory. Now it's rewriten so it uses settings like manufacturer.

 MAINTAINERS                         |    5 +
 board/raidsonic/ib62x0/Makefile     |   43 +++++++++
 board/raidsonic/ib62x0/ib62x0.c     |   79 ++++++++++++++++
 board/raidsonic/ib62x0/ib62x0.h     |   40 ++++++++
 board/raidsonic/ib62x0/kwbimage.cfg |  172 +++++++++++++++++++++++++++++++++++
 boards.cfg                          |    2 +
 include/configs/ib62x0.h            |  172 +++++++++++++++++++++++++++++++++++
 7 files changed, 513 insertions(+)

Comments

Prafulla Wadaskar March 26, 2012, 8:03 a.m. UTC | #1
> -----Original Message-----
> From: u-boot-bounces@lists.denx.de [mailto:u-boot-
> bounces@lists.denx.de] On Behalf Of Luka Perkov
> Sent: 26 March 2012 01:02
> To: u-boot@lists.denx.de
> Cc: dreagle@doukki.net; gmbnomis@gmail.com
> Subject: [U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support
> 
> Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220.
> 
> Only difference between boards is number of SATA ports.
> 
> More information about the boards can be found here:
> 
> http://www.raidsonic.de/en/products/nas-systems.php?we_objectID=7036
> http://www.raidsonic.de/en/products/nas-systems.php?we_objectID=7515
> 
> Signed-off-by: Luka Perkov <uboot@lukaperkov.net>
> Signed-off-by: Gerald Kerma <dreagle@doukki.net>
> Signed-off-by: Simon Baatz <gmbnomis@gmail.com>
> ---
> 
> Changes from version v1:
> 
>  * use tools/checkpatch.pl to locate patch errors and fix them
>  * add two entries in boards.cfg, one for each board
>  * fixed CONFIG_RESET_PHY_R
>  * don't define values for macros that enable features only
>  * remove static RAM configuration
>  * fix comments
>  * use only CONFIG_ENV_OFFSET and remove CONFIG_ENV_ADDR
>  * clean coding style
>  * add entry in MAINTAINERS file
> 
> Changes from version v2:
> 
>  * use defined() in macros for board selection for robustness
> 
> Changes from version v3:
> 
>  * don't use utf8 for Geralds name
>  * don't mix upper/lower case in kwbimage.cfg
>  * fix prompt
> 
> Changes from version v4:
>  * fix board Makefile (clean and distclean)
>  * use generic way to handle arch number of the board
>  * fix MAINTAINERS file
>  * move code from Marvell to raidsonic folder
>  * use CONFIG_MACH_TYPE
>  * set only necessary GPIOs
>  * use link instead of address for license
>  * add few links about board being supported for quick reference
>  * add previous change logs
>  * multiple updates to kwbimage.cfg, thank you Simon
> 
> About kwbimage.cfg - first version was taken from sheevaplug with
> change only
> regarding memory. Now it's rewriten so it uses settings like
> manufacturer.
> 
>  MAINTAINERS                         |    5 +
>  board/raidsonic/ib62x0/Makefile     |   43 +++++++++
>  board/raidsonic/ib62x0/ib62x0.c     |   79 ++++++++++++++++
>  board/raidsonic/ib62x0/ib62x0.h     |   40 ++++++++
>  board/raidsonic/ib62x0/kwbimage.cfg |  172
> +++++++++++++++++++++++++++++++++++
>  boards.cfg                          |    2 +
>  include/configs/ib62x0.h            |  172
> +++++++++++++++++++++++++++++++++++
>  7 files changed, 513 insertions(+)
> 

Hi Luka

This patch looks okay to me.

Just one concern, how you are taking care of machine-id?
Just curious to know:
Have you already registered for machine-ID for this board?
Is Linux kernel support for this board is done, is it being mainlined?

Regards..
Prafulla . . .
u-boot@lakedaemon.net March 26, 2012, 1:23 p.m. UTC | #2
On Sun, Mar 25, 2012 at 09:31:43PM +0200, Luka Perkov wrote:
> Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220.
> 
> Only difference between boards is number of SATA ports.
> 
> More information about the boards can be found here:
> 
> http://www.raidsonic.de/en/products/nas-systems.php?we_objectID=7036
> http://www.raidsonic.de/en/products/nas-systems.php?we_objectID=7515

Luka,

Sorry I didn't see this before now.  You may want to have a look at the
patch series going into v3.4 here [1].  Basically, All of mine and
Andrew Lunn's.

If you base your kernel patches off of this, CC: me and I'll pull them
in.

...
> diff --git a/include/configs/ib62x0.h b/include/configs/ib62x0.h
> new file mode 100644
> index 0000000..2dc698e
> --- /dev/null
> +++ b/include/configs/ib62x0.h
> @@ -0,0 +1,172 @@
> +/*
> + * Copyright (C) 2011-2012
> + * Gerald Kerma <dreagle@doukki.net>
> + * Luka Perkov <uboot@lukaperkov.net>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef _CONFIG_IB62x0_H
> +#define _CONFIG_IB62x0_H
> +
> +/*
> + * Version number information
> + */
> +#if defined(CONFIG_BOARD_IS_IB_NAS6210)
> +# define CONFIG_IDENT_STRING	" RaidSonic ICY BOX IB-NAS6210"
> +#elif defined(CONFIG_BOARD_IS_IB_NAS6220)
> +# define CONFIG_IDENT_STRING	" RaidSonic ICY BOX IB-NAS6220"
> +#else
> +# error Unknown RaidSonic ICY BOX board specified
> +#endif
> +
> +/*
> + * High level configuration options
> + */
> +#define CONFIG_FEROCEON_88FR131		/* CPU Core subversion */
> +#define CONFIG_KIRKWOOD			/* SOC Family Name */
> +#define CONFIG_KW88F6281		/* SOC Name */
> +#define CONFIG_SKIP_LOWLEVEL_INIT	/* disable board lowlevel_init */
> +
> +/*
> + * Machine type
> + */
> +#define CONFIG_MACH_TYPE	MACH_TYPE_NAS6210


#define CONFIG_OF_LIBFDT

If you add this here, the mach-type won't be needed once you add a
devicetree file to Linux.  It shouldn't be too hard to follow what we
have going on for dreamplug and Buffalo DNS-xxx (patches are still wip
for Buffalo stuff).

hth,

Jason.

[1] git://git.infradead.org/users/jcooper/linux-kirkwood.git kirkwood_dt_for_3.4_v3
Luka Perkov March 26, 2012, 5:26 p.m. UTC | #3
Hi Prafulla,

On Mon, Mar 26, 2012 at 01:03:49AM -0700, Prafulla Wadaskar wrote:
> This patch looks okay to me.

Great! Who is in charge of commiting this? You?

> Just one concern, how you are taking care of machine-id?

In file include/configs/ib62x0.h this line takes care of that:

#define CONFIG_MACH_TYPE	MACH_TYPE_NAS6210

It was one of your comments for v4.

> Just curious to know:
> Have you already registered for machine-ID for this board?

MACH_TYPE_NAS6210 is already inside kernel but the board is not added
yet.

> Is Linux kernel support for this board is done, is it being mainlined?

Not yet. This is next on my TODO. Here is a patch I submitted to
OpenWrt:

https://lists.openwrt.org/pipermail/openwrt-devel/2012-March/014444.html

Simon is the author of the kernel mach file.

Regarding u-boot I have other things on my TODO list, one of them is to
clean up other kirkwood targets. I'll fix stuff that were pointed for
this board. But first I would like this to be commited.

Thank you for the review.

Regards,
Luka
Luka Perkov March 26, 2012, 5:57 p.m. UTC | #4
Hi Jason,

please keep me in CC because I'm not subscribed to the list... Thanks!

> Sorry I didn't see this before now. You may want to have a look at the
> patch series going into v3.4 here [1]. Basically, All of mine and
> Andrew Lunn's.

Cool! Thanks for pointing this out.

I have looked at this:

http://git.infradead.org/users/jcooper/linux-kirkwood.git/blob/refs/heads/kirkwood_dt_for_3.4_v3:/arch/arm/mach-kirkwood/board-dreamplug.c
 
40 struct mtd_partition dreamplug_partitions[] = {
41         {
42                 .name   = "u-boot",
43                 .size   = SZ_512K,
44                 .offset = 0,
45         },
46         {
47                 .name   = "u-boot env",
48                 .size   = SZ_64K,
49                 .offset = SZ_512K + SZ_512K,
50         },
51         {
52                 .name   = "dtb",
53                 .size   = SZ_64K,
54                 .offset = SZ_512K + SZ_512K + SZ_512K,
55         },
56 };

Can you explain why line 49 is not:

".offset = MTDPART_OFS_NXTBLK," or ".offset = SZ_512K"

and line 54:

".offset = MTDPART_OFS_NXTBLK," or ".offset = SZ_512K + SZ_64K"

Am I missing something here?

> If you base your kernel patches off of this, CC: me and I'll pull them
> in.

Is there a list where we can talk about this? I dont think we should use
u-boot list for this...

> ...
> > +#define CONFIG_MACH_TYPE	MACH_TYPE_NAS6210
> 
> #define CONFIG_OF_LIBFDT
> 
> If you add this here, the mach-type won't be needed once you add a
> devicetree file to Linux.

I do not want to add this now because I did not test that. And there is
no support for this in kernel yet. When we have this we can post a patch
to u-boot list to fix this. I think that is the best way.

> It shouldn't be too hard to follow what we have going on for dreamplug
> and Buffalo DNS-xxx (patches are still wip for Buffalo stuff).

I will test this patch with your kernel branch:

https://lists.openwrt.org/pipermail/openwrt-devel/2012-March/014444.html

I'll let you know how it went and bug you if I have problems...

> [1] git://git.infradead.org/users/jcooper/linux-kirkwood.git kirkwood_dt_for_3.4_v3

Thanks again for this.

Regards,
Luka
u-boot@lakedaemon.net March 26, 2012, 7:34 p.m. UTC | #5
On Mon, Mar 26, 2012 at 07:57:38PM +0200, Luka Perkov wrote:
> Hi Jason,
> 
> please keep me in CC because I'm not subscribed to the list... Thanks!
> 
> > Sorry I didn't see this before now. You may want to have a look at the
> > patch series going into v3.4 here [1]. Basically, All of mine and
> > Andrew Lunn's.
> 
> Cool! Thanks for pointing this out.
> 
> I have looked at this:
> 
> http://git.infradead.org/users/jcooper/linux-kirkwood.git/blob/refs/heads/kirkwood_dt_for_3.4_v3:/arch/arm/mach-kirkwood/board-dreamplug.c
>  
> 40 struct mtd_partition dreamplug_partitions[] = {
> 41         {
> 42                 .name   = "u-boot",
> 43                 .size   = SZ_512K,
> 44                 .offset = 0,
> 45         },
> 46         {
> 47                 .name   = "u-boot env",
> 48                 .size   = SZ_64K,
> 49                 .offset = SZ_512K + SZ_512K,
> 50         },
> 51         {
> 52                 .name   = "dtb",
> 53                 .size   = SZ_64K,
> 54                 .offset = SZ_512K + SZ_512K + SZ_512K,
> 55         },
> 56 };
> 
> Can you explain why line 49 is not:
> 
> ".offset = MTDPART_OFS_NXTBLK," or ".offset = SZ_512K"
> 
> and line 54:
> 
> ".offset = MTDPART_OFS_NXTBLK," or ".offset = SZ_512K + SZ_64K"
> 
> Am I missing something here?

Nope, I copied the style from arch/arm/mach-kirkwood/t5325-setup.c:37.
Thankfully, that will be going away once spi/flash is converted to
devicetree.  If your board uses nand, you can look at Jamie Lentin's
patch series for the Buffalo DNS-32x boards.  He's converted orion_nand
to devicetree.  Hopefully, I'll be able to pull those soon.

> > If you base your kernel patches off of this, CC: me and I'll pull them
> > in.
> 
> Is there a list where we can talk about this? I dont think we should use
> u-boot list for this...

linux-arm-kernel@vger.kernel.org, CC'd.

> > ...
> > > +#define CONFIG_MACH_TYPE	MACH_TYPE_NAS6210
> > 
> > #define CONFIG_OF_LIBFDT
> > 
> > If you add this here, the mach-type won't be needed once you add a
> > devicetree file to Linux.
> 
> I do not want to add this now because I did not test that. And there is
> no support for this in kernel yet. When we have this we can post a patch
> to u-boot list to fix this. I think that is the best way.

I use this with dreamplug currently.  It boots non-fdt and fdt kernels
without problem.  It basically has bootm command read an extra argument
(address of dt blob), if provided.  So, args would be:

bootm <kernel addr> [<initrd addr>] [<dtb addr>]

If you're not comfortable with it, that's fine.  I just remember having
to go back and add it and then wait another release cycle to see it in
mainline.  I wish I had it in there the first time around.

> > It shouldn't be too hard to follow what we have going on for dreamplug
> > and Buffalo DNS-xxx (patches are still wip for Buffalo stuff).
> 
> I will test this patch with your kernel branch:
> 
> https://lists.openwrt.org/pipermail/openwrt-devel/2012-March/014444.html
> 
> I'll let you know how it went and bug you if I have problems...
> 
> > [1] git://git.infradead.org/users/jcooper/linux-kirkwood.git kirkwood_dt_for_3.4_v3
> 
> Thanks again for this.
> 

No problem.

thx,

Jason.
u-boot@lakedaemon.net March 26, 2012, 8:58 p.m. UTC | #6
On Mon, Mar 26, 2012 at 03:34:37PM -0400, Jason Cooper wrote:
> On Mon, Mar 26, 2012 at 07:57:38PM +0200, Luka Perkov wrote:
...
> > Is there a list where we can talk about this? I dont think we should use
> > u-boot list for this...
> 
> linux-arm-kernel@vger.kernel.org, CC'd.

oops, that's the old address, current is
linux-arm-kernel@lists.infradead.org

thx,

Jason.
Prafulla Wadaskar March 27, 2012, 6:37 a.m. UTC | #7
> -----Original Message-----
> From: Luka Perkov [mailto:uboot@lukaperkov.net]
> Sent: 26 March 2012 22:56
> To: Prafulla Wadaskar
> Cc: u-boot@lists.denx.de; dreagle@doukki.net; gmbnomis@gmail.com
> Subject: Re: [U-Boot] [PATCH v5] kirkwood: add NAS62x0 board support
> 
> Hi Prafulla,
> 
> On Mon, Mar 26, 2012 at 01:03:49AM -0700, Prafulla Wadaskar wrote:
> > This patch looks okay to me.
> 
> Great! Who is in charge of commiting this? You?

Thant's me, I will pick it up :-)

Regards..
Prafulla . . .
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 46f63a0..deb093e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -782,6 +782,11 @@  Linus Walleij <linus.walleij@linaro.org>
 	integratorap	various
 	integratorcp	various
 
+Luka Perkov <uboot@lukaperkov.net>
+
+	ib6210		ARM926EJS
+	ib6220		ARM926EJS
+
 Dave Peverley <dpeverley@mpc-data.co.uk>
 
 	omap730p2	ARM926EJS
diff --git a/board/raidsonic/ib62x0/Makefile b/board/raidsonic/ib62x0/Makefile
new file mode 100644
index 0000000..d450f8d
--- /dev/null
+++ b/board/raidsonic/ib62x0/Makefile
@@ -0,0 +1,43 @@ 
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <prafulla@marvell.com>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).o
+
+COBJS	:= ib62x0.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
+	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
diff --git a/board/raidsonic/ib62x0/ib62x0.c b/board/raidsonic/ib62x0/ib62x0.c
new file mode 100644
index 0000000..65f2c2e
--- /dev/null
+++ b/board/raidsonic/ib62x0/ib62x0.c
@@ -0,0 +1,79 @@ 
+/*
+ * Copyright (C) 2011-2012
+ * Gerald Kerma <dreagle@doukki.net>
+ * Luka Perkov <uboot@lukaperkov.net>
+ * Simon Baatz <gmbnomis@gmail.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <common.h>
+#include <miiphy.h>
+#include <asm/arch/cpu.h>
+#include <asm/arch/kirkwood.h>
+#include <asm/arch/mpp.h>
+#include "ib62x0.h"
+
+DECLARE_GLOBAL_DATA_PTR;
+
+int board_early_init_f(void)
+{
+	/*
+	 * default gpio configuration
+	 * There are maximum 64 gpios controlled through 2 sets of registers
+	 * the below configuration configures mainly initial LED status
+	 */
+	kw_config_gpio(IB62x0_OE_VAL_LOW,
+			IB62x0_OE_VAL_HIGH,
+			IB62x0_OE_LOW, IB62x0_OE_HIGH);
+
+	/* Multi-Purpose Pins Functionality configuration */
+	u32 kwmpp_config[] = {
+		MPP0_NF_IO2,
+		MPP1_NF_IO3,
+		MPP2_NF_IO4,
+		MPP3_NF_IO5,
+		MPP4_NF_IO6,
+		MPP5_NF_IO7,
+		MPP6_SYSRST_OUTn,
+		MPP8_TW_SDA,
+		MPP9_TW_SCK,
+		MPP10_UART0_TXD,
+		MPP11_UART0_RXD,
+		MPP18_NF_IO0,
+		MPP19_NF_IO1,
+		MPP20_SATA1_ACTn,
+		MPP21_SATA0_ACTn,
+		MPP22_GPIO,     /* Power LED red */
+		MPP24_GPIO,     /* Power off device */
+		MPP25_GPIO,     /* Power LED green */
+		MPP27_GPIO,     /* USB transfer LED */
+		MPP28_GPIO,     /* Reset button */
+		MPP29_GPIO,     /* USB Copy button */
+		0
+	};
+	kirkwood_mpp_conf(kwmpp_config);
+	return 0;
+}
+
+int board_init(void)
+{
+	/* adress of boot parameters */
+	gd->bd->bi_boot_params = kw_sdram_bar(0) + 0x100;
+
+	return 0;
+}
diff --git a/board/raidsonic/ib62x0/ib62x0.h b/board/raidsonic/ib62x0/ib62x0.h
new file mode 100644
index 0000000..0c30690
--- /dev/null
+++ b/board/raidsonic/ib62x0/ib62x0.h
@@ -0,0 +1,40 @@ 
+/*
+ * Copyright (C) 2011-2012
+ * Gerald Kerma <dreagle@doukki.net>
+ * Simon Baatz <gmbnomis@gmail.com>
+ * Luka Perkov <uboot@lukaperkov.net>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef __IB62x0_H
+#define __IB62x0_H
+
+#define IB62x0_OE_LOW		(~(1 << 22 | 1 << 24 | 1 << 25 | 1 << 27))
+#define IB62x0_OE_HIGH		(~(0))
+#define IB62x0_OE_VAL_LOW	0
+#define IB62x0_OE_VAL_HIGH	0
+
+/* PHY related */
+#define MV88E1116_LED_FCTRL_REG		10
+#define MV88E1116_CPRSP_CR3_REG		21
+#define MV88E1116_MAC_CTRL_REG		21
+#define MV88E1116_PGADR_REG		22
+#define MV88E1116_RGMII_TXTM_CTRL	(1 << 4)
+#define MV88E1116_RGMII_RXTM_CTRL	(1 << 5)
+
+#endif /* __IB62x0_H */
diff --git a/board/raidsonic/ib62x0/kwbimage.cfg b/board/raidsonic/ib62x0/kwbimage.cfg
new file mode 100644
index 0000000..bc5a355
--- /dev/null
+++ b/board/raidsonic/ib62x0/kwbimage.cfg
@@ -0,0 +1,172 @@ 
+#
+# Copyright (C) 2011-2012
+# Gerald Kerma <dreagle@doukki.net>
+# Simon Baatz <gmbnomis@gmail.com>
+# Luka Perkov <uboot@lukaperkov.net>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+# Refer docs/README.kwimage for more details about how-to configure
+# and create kirkwood boot image
+#
+
+# Boot Media configurations
+BOOT_FROM	nand	# change from nand to uart if building UART image
+NAND_ECC_MODE	default
+NAND_PAGE_SIZE	0x0800
+
+# SOC registers configuration using bootrom header extension
+# Maximum KWBIMAGE_MAX_CONFIG configurations allowed
+
+# Configure RGMII-0 interface pad voltage to 1.8V
+DATA 0xffd100e0 0x1b1b1b9b
+
+#Dram initalization for SINGLE x16 CL=5 @ 400MHz
+DATA 0xffd01400 0x43000c30	# DDR Configuration register
+# bit13-0:  0xc30 (3120 DDR2 clks refresh rate)
+# bit23-14: zero
+# bit24: 1= enable exit self refresh mode on DDR access
+# bit25: 1 required
+# bit29-26: zero
+# bit31-30: 01
+
+DATA 0xffd01404 0x37543000	# DDR Controller Control Low
+# bit 4:    0=addr/cmd in smame cycle
+# bit 5:    0=clk is driven during self refresh, we don't care for APX
+# bit 6:    0=use recommended falling edge of clk for addr/cmd
+# bit14:    0=input buffer always powered up
+# bit18:    1=cpu lock transaction enabled
+# bit23-20: 5=recommended value for CL=5 and STARTBURST_DEL disabled bit31=0
+# bit27-24: 7= CL+2, STARTBURST sample stages, for freqs 400MHz, unbuffered DIMM
+# bit30-28: 3 required
+# bit31:    0=no additional STARTBURST delay
+
+DATA 0xffd01408 0x22125451	# DDR Timing (Low) (active cycles value +1)
+# bit3-0:   TRAS lsbs
+# bit7-4:   TRCD
+# bit11- 8: TRP
+# bit15-12: TWR
+# bit19-16: TWTR
+# bit20:    TRAS msb
+# bit23-21: 0x0
+# bit27-24: TRRD
+# bit31-28: TRTP
+
+DATA 0xffd0140c 0x00000a33	# DDR Timing (High)
+# bit6-0:   TRFC
+# bit8-7:   TR2R
+# bit10-9:  TR2W
+# bit12-11: TW2W
+# bit31-13: zero required
+
+DATA 0xffd01410 0x0000000c	# DDR Address Control
+# bit1-0:   00, Cs0width=x8
+# bit3-2:   11, Cs0size=1Gb
+# bit5-4:   00, Cs1width=x8
+# bit7-6:   11, Cs1size=1Gb
+# bit9-8:   00, Cs2width=nonexistent
+# bit11-10: 00, Cs2size =nonexistent
+# bit13-12: 00, Cs3width=nonexistent
+# bit15-14: 00, Cs3size =nonexistent
+# bit16:    0,  Cs0AddrSel
+# bit17:    0,  Cs1AddrSel
+# bit18:    0,  Cs2AddrSel
+# bit19:    0,  Cs3AddrSel
+# bit31-20: 0 required
+
+DATA 0xffd01414 0x00000000	# DDR Open Pages Control
+# bit0:    0,  OpenPage enabled
+# bit31-1: 0 required
+
+DATA 0xffd01418 0x00000000	# DDR Operation
+# bit3-0:   0x0, DDR cmd
+# bit31-4:  0 required
+
+DATA 0xffd0141c 0x00000c52	# DDR Mode
+# bit2-0:   2, BurstLen=2 required
+# bit3:     0, BurstType=0 required
+# bit6-4:   4, CL=5
+# bit7:     0, TestMode=0 normal
+# bit8:     0, DLL reset=0 normal
+# bit11-9:  6, auto-precharge write recovery ????????????
+# bit12:    0, PD must be zero
+# bit31-13: 0 required
+
+DATA 0xffd01420 0x00000040	# DDR Extended Mode
+# bit0:    0,  DDR DLL enabled
+# bit1:    0,  DDR drive strenght normal
+# bit2:    1,  DDR ODT control lsd (disabled)
+# bit5-3:  000, required
+# bit6:    0,  DDR ODT control msb, (disabled)
+# bit9-7:  000, required
+# bit10:   0,  differential DQS enabled
+# bit11:   0, required
+# bit12:   0, DDR output buffer enabled
+# bit31-13: 0 required
+
+DATA 0xffd01424 0x0000f17f	# DDR Controller Control High
+# bit2-0:  111, required
+# bit3  :  1  , MBUS Burst Chop disabled
+# bit6-4:  111, required
+# bit7  :  0
+# bit8  :  1  , add writepath sample stage, must be 1 for DDR freq >= 300MHz
+# bit9  :  0  , no half clock cycle addition to dataout
+# bit10 :  0  , 1/4 clock cycle skew enabled for addr/ctl signals
+# bit11 :  0  , 1/4 clock cycle skew disabled for write mesh
+# bit15-12: 1111 required
+# bit31-16: 0    required
+
+DATA 0xffd01428 0x00085520	# DDR2 ODT Read Timing (default values)
+DATA 0xffd0147c 0x00008552	# DDR2 ODT Write Timing (default values)
+
+DATA 0xffd01500 0x00000000	# CS[0]n Base address to 0x0
+DATA 0xffd01504 0x0ffffff1	# CS[0]n Size
+# bit0:    1,  Window enabled
+# bit1:    0,  Write Protect disabled
+# bit3-2:  00, CS0 hit selected
+# bit23-4: ones, required
+# bit31-24: 0x0f, Size (i.e. 256MB)
+
+DATA 0xffd01508 0x10000000	# CS[1]n Base address to 256Mb
+DATA 0xffd0150c 0x00000000	# CS[1]n Size, window disabled
+
+DATA 0xffd01514 0x00000000	# CS[2]n Size, window disabled
+DATA 0xffd0151c 0x00000000	# CS[3]n Size, window disabled
+
+DATA 0xffd01494 0x00030000	# DDR ODT Control (Low)
+# bit3-0:  2, ODT0Rd, MODT[0] asserted during read from DRAM CS1
+# bit7-4:  1, ODT0Rd, MODT[0] asserted during read from DRAM CS0
+# bit19-16:2, ODT0Wr, MODT[0] asserted during write to DRAM CS1
+# bit23-20:1, ODT0Wr, MODT[0] asserted during write to DRAM CS0
+
+DATA 0xffd01498 0x00000000	# DDR ODT Control (High)
+# bit1-0:  00, ODT0 controlled by ODT Control (low) register above
+# bit3-2:  01, ODT1 active NEVER!
+# bit31-4: zero, required
+
+DATA 0xffd0149c 0x0000e803	# CPU ODT Control
+DATA 0xffd01480 0x00000001	# DDR Initialization Control
+#bit0=1, enable DDR init upon this register write
+
+DATA 0xffd01480 0x00000001      # DDR Initialization Control
+#bit0=1, enable DDR init upon this register write
+
+DATA 0xFFD20134 0x66666666      # L2 RAM Timing 0 Register
+DATA 0xFFD20138 0x66666666      # L2 RAM Timing 1 Register
+
+# End of Header extension
+DATA 0x0 0x0
diff --git a/boards.cfg b/boards.cfg
index 28cc345..fe1c489 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -153,6 +153,8 @@  openrd_client                arm         arm926ejs   openrd              Marvell
 openrd_ultimate              arm         arm926ejs   openrd              Marvell        kirkwood        openrd:BOARD_IS_OPENRD_ULTIMATE
 rd6281a                      arm         arm926ejs   -                   Marvell        kirkwood
 sheevaplug                   arm         arm926ejs   -                   Marvell        kirkwood
+ib_nas6210                   arm         arm926ejs   ib62x0              raidsonic      kirkwood        ib62x0:BOARD_IS_IB_NAS6210
+ib_nas6220                   arm         arm926ejs   ib62x0              raidsonic      kirkwood        ib62x0:BOARD_IS_IB_NAS6220
 dockstar                     arm         arm926ejs   -                   Seagate        kirkwood
 jadecpu                      arm         arm926ejs   jadecpu             syteco         mb86r0x
 mx25pdk                      arm         arm926ejs   mx25pdk             freescale      mx25		mx25pdk:IMX_CONFIG=board/freescale/mx25pdk/imximage.cfg
diff --git a/include/configs/ib62x0.h b/include/configs/ib62x0.h
new file mode 100644
index 0000000..2dc698e
--- /dev/null
+++ b/include/configs/ib62x0.h
@@ -0,0 +1,172 @@ 
+/*
+ * Copyright (C) 2011-2012
+ * Gerald Kerma <dreagle@doukki.net>
+ * Luka Perkov <uboot@lukaperkov.net>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef _CONFIG_IB62x0_H
+#define _CONFIG_IB62x0_H
+
+/*
+ * Version number information
+ */
+#if defined(CONFIG_BOARD_IS_IB_NAS6210)
+# define CONFIG_IDENT_STRING	" RaidSonic ICY BOX IB-NAS6210"
+#elif defined(CONFIG_BOARD_IS_IB_NAS6220)
+# define CONFIG_IDENT_STRING	" RaidSonic ICY BOX IB-NAS6220"
+#else
+# error Unknown RaidSonic ICY BOX board specified
+#endif
+
+/*
+ * High level configuration options
+ */
+#define CONFIG_FEROCEON_88FR131		/* CPU Core subversion */
+#define CONFIG_KIRKWOOD			/* SOC Family Name */
+#define CONFIG_KW88F6281		/* SOC Name */
+#define CONFIG_SKIP_LOWLEVEL_INIT	/* disable board lowlevel_init */
+
+/*
+ * Machine type
+ */
+#define CONFIG_MACH_TYPE	MACH_TYPE_NAS6210
+
+/*
+ * Compression configuration
+ */
+#define CONFIG_BZIP2
+#define CONFIG_LZMA
+#define CONFIG_LZO
+
+/*
+ * Commands configuration
+ */
+#define CONFIG_SYS_NO_FLASH		/* declare no flash (NOR/SPI) */
+#define CONFIG_SYS_MVFS
+#include <config_cmd_default.h>
+#define CONFIG_CMD_ENV
+#define CONFIG_CMD_IDE
+#define CONFIG_CMD_MII
+#define CONFIG_CMD_NAND
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_USB
+/*
+ * mv-common.h should be defined after CMD configs since it used them
+ * to enable certain macros
+ */
+#include "mv-common.h"
+
+#undef CONFIG_SYS_PROMPT
+#if defined(CONFIG_BOARD_IS_IB_NAS6210)
+# define CONFIG_SYS_PROMPT	"IB-NAS6210 => "
+#elif defined(CONFIG_BOARD_IS_IB_NAS6220)
+# define CONFIG_SYS_PROMPT	"IB-NAS6220 => "
+#else
+# error Unknown RaidSonic ICY BOX board specified
+#endif
+
+/*
+ * Environment variables configuration
+ */
+#ifdef CONFIG_CMD_NAND
+#define CONFIG_ENV_IS_IN_NAND
+#define CONFIG_ENV_SECT_SIZE	0x20000
+#else
+#define CONFIG_ENV_IS_NOWHERE
+#endif
+#define CONFIG_ENV_SIZE		0x20000
+#define CONFIG_ENV_OFFSET	0x80000
+
+/*
+ * Default environment variables
+ */
+#define CONFIG_BOOTCOMMAND \
+	"setenv bootargs ${console} ${mtdparts} ${bootargs_root}; "	\
+	"ubi part root; "						\
+	"ubifsmount root; "						\
+	"ubifsload 0x800000 ${kernel}; "				\
+	"ubifsload 0x1100000 ${initrd}; "				\
+	"bootm 0x800000 0x1100000"
+
+#define CONFIG_MTDPARTS				\
+	"mtdparts=orion_nand:"			\
+	"0x80000@0x0(uboot),"			\
+	"0x20000@0x80000(uboot_env),"		\
+	"-@0xa0000(root)\0"
+
+#define CONFIG_EXTRA_ENV_SETTINGS					\
+	"console=console=ttyS0,115200\0"				\
+	"mtdids=nand0=orion_nand\0"					\
+	"mtdparts="CONFIG_MTDPARTS					\
+	"kernel=/boot/uImage\0"						\
+	"initrd=/boot/uInitrd\0"					\
+	"bootargs_root=ubi.mtd=2 root=ubi0:root rootfstype=ubifs\0"
+
+/*
+ * Ethernet driver configuration
+ */
+#ifdef CONFIG_CMD_NET
+#define CONFIG_MVGBE_PORTS	{1, 0}	/* enable port 0 only */
+#define CONFIG_PHY_BASE_ADR	0
+#undef CONFIG_RESET_PHY_R
+#endif /* CONFIG_CMD_NET */
+
+/*
+ * SATA driver configuration
+ */
+#ifdef CONFIG_CMD_IDE
+#define __io
+#define CONFIG_IDE_PREINIT
+#define CONFIG_DOS_PARTITION
+#define CONFIG_MVSATA_IDE_USE_PORT0
+# if defined(CONFIG_BOARD_IS_IB_NAS6210)
+#  undef CONFIG_SYS_IDE_MAXBUS
+#  define CONFIG_SYS_IDE_MAXBUS		1
+#  undef CONFIG_SYS_IDE_MAXDEVICE
+#  define CONFIG_SYS_IDE_MAXDEVICE	1
+# elif defined(CONFIG_BOARD_IS_IB_NAS6220)
+#  define CONFIG_MVSATA_IDE_USE_PORT1
+# endif
+#define CONFIG_SYS_ATA_IDE0_OFFSET	KW_SATA_PORT0_OFFSET
+# if defined(CONFIG_BOARD_IS_IB_NAS6220)
+#  define CONFIG_SYS_ATA_IDE1_OFFSET	KW_SATA_PORT1_OFFSET
+# endif
+#endif /* CONFIG_CMD_IDE */
+
+/*
+ * RTC driver configuration
+ */
+#ifdef CONFIG_CMD_DATE
+#define CONFIG_RTC_MV
+#endif /* CONFIG_CMD_DATE */
+
+/*
+ * File system
+ */
+#define CONFIG_CMD_EXT2
+#define CONFIG_CMD_FAT
+#define CONFIG_CMD_JFFS2
+#define CONFIG_CMD_UBI
+#define CONFIG_CMD_UBIFS
+#define CONFIG_RBTREE
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+
+#endif /* _CONFIG_IB62x0_H */