Patchwork [1/2] New package: socketcand

login
register
mail settings
Submitter Yegor Yefremov
Date March 22, 2012, 3 p.m.
Message ID <1332428460-28459-1-git-send-email-yegorslists@googlemail.com>
Download mbox | patch
Permalink /patch/148262/
State Not Applicable
Headers show

Comments

Yegor Yefremov - March 22, 2012, 3 p.m.
From: Yegor Yefremov <yegorslists@googlemail.com>

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/Config.in                |    1 +
 package/socketcand/Config.in     |    9 +++++++++
 package/socketcand/socketcand.mk |   12 ++++++++++++
 3 files changed, 22 insertions(+), 0 deletions(-)
 create mode 100644 package/socketcand/Config.in
 create mode 100644 package/socketcand/socketcand.mk
Peter Korsgaard - March 22, 2012, 10:54 p.m.
>>>>> "yegorslists" == yegorslists  <yegorslists@googlemail.com> writes:

 yegorslists> From: Yegor Yefremov <yegorslists@googlemail.com>
 yegorslists> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Committed, thanks.
Thomas Petazzoni - March 23, 2012, 8:55 a.m.
Le Thu, 22 Mar 2012 23:54:34 +0100,
Peter Korsgaard <jacmet@uclibc.org> a écrit :

> >>>>> "yegorslists" == yegorslists  <yegorslists@googlemail.com>
> >>>>> writes:
> 
>  yegorslists> From: Yegor Yefremov <yegorslists@googlemail.com>
>  yegorslists> Signed-off-by: Yegor Yefremov
>  yegorslists> <yegorslists@googlemail.com>
> 
> Committed, thanks.

There are apparently build problems with this package:
http://autobuild.buildroot.org/results/d6a79808eae008611a3ed12a0b7d9901a7fc159f/build-end.log

The host system I use is an old Debian Sarge, so the coreutils
(including cp) might be quite old. But I think it's a good test to see
if we can correctly build on old enterprise distros such as RHEL that
some people are forced to use in companies (and I feel sorry for them).

Thomas
Yegor Yefremov - March 23, 2012, 9:06 a.m.
Am 23.03.2012 09:55, schrieb Thomas Petazzoni:
> Le Thu, 22 Mar 2012 23:54:34 +0100,
> Peter Korsgaard <jacmet@uclibc.org> a écrit :
> 
>>>>>>> "yegorslists" == yegorslists  <yegorslists@googlemail.com>
>>>>>>> writes:
>>
>>  yegorslists> From: Yegor Yefremov <yegorslists@googlemail.com>
>>  yegorslists> Signed-off-by: Yegor Yefremov
>>  yegorslists> <yegorslists@googlemail.com>
>>
>> Committed, thanks.
> 
> There are apparently build problems with this package:
> http://autobuild.buildroot.org/results/d6a79808eae008611a3ed12a0b7d9901a7fc159f/build-end.log
> 
> The host system I use is an old Debian Sarge, so the coreutils
> (including cp) might be quite old. But I think it's a good test to see
> if we can correctly build on old enterprise distros such as RHEL that
> some people are forced to use in companies (and I feel sorry for them).

What do you suggest?
I found following solution here:

http://superuser.com/questions/140708/ubuntu-equivalent-of-unix-command-cp-n

if [ ! -e dest ]; then
    cp -f src dest
fi

Yegor
Thomas Petazzoni - March 23, 2012, 9:16 a.m.
Le Fri, 23 Mar 2012 10:06:40 +0100,
Yegor Yefremov <yegor_sub1@visionsystems.de> a écrit :

> What do you suggest?

Fixup the Makefile.in to use install instead of cp. That will remove
all the useless mkdir and such. You can even contribute this change to
the upstream project I think.

No 'make install' ever cares about overwriting existing files, I don't
see why the one of socketcand should.

What do you think about this option?

Thomas
Yegor Yefremov - March 23, 2012, 9:19 a.m.
On Fri, Mar 23, 2012 at 10:16 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Le Fri, 23 Mar 2012 10:06:40 +0100,
> Yegor Yefremov <yegor_sub1@visionsystems.de> a écrit :
>
>> What do you suggest?
>
> Fixup the Makefile.in to use install instead of cp. That will remove
> all the useless mkdir and such. You can even contribute this change to
> the upstream project I think.
>
> No 'make install' ever cares about overwriting existing files, I don't
> see why the one of socketcand should.
>
> What do you think about this option?

I agree with you. I'll make a patch and contact the maintainer.

Yegor
Thomas Petazzoni - March 27, 2012, 9:39 a.m.
Hello,

Le Fri, 23 Mar 2012 10:19:55 +0100,
Yegor Yefremov <yegorslists@googlemail.com> a écrit :

> > No 'make install' ever cares about overwriting existing files, I don't
> > see why the one of socketcand should.
> >
> > What do you think about this option?
> 
> I agree with you. I'll make a patch and contact the maintainer.

Any news from this?

Thomas
Yegor Yefremov - March 27, 2012, 9:45 a.m.
Am 27.03.2012 11:39, schrieb Thomas Petazzoni:
> Hello,
> 
> Le Fri, 23 Mar 2012 10:19:55 +0100,
> Yegor Yefremov <yegorslists@googlemail.com> a écrit :
> 
>>> No 'make install' ever cares about overwriting existing files, I don't
>>> see why the one of socketcand should.
>>>
>>> What do you think about this option?
>>
>> I agree with you. I'll make a patch and contact the maintainer.
> 
> Any news from this?

I've contacted Jan-Niklas and he wanted to fix the stuff himself next week. He has also integrated a patch to make libconfig optional. I hope to clean up the issues next week.

Yegor
Thomas Petazzoni - March 27, 2012, 9:54 a.m.
Le Tue, 27 Mar 2012 11:45:43 +0200,
Yegor Yefremov <yegor_sub1@visionsystems.de> a écrit :

> I've contacted Jan-Niklas and he wanted to fix the stuff himself next
> week. He has also integrated a patch to make libconfig optional. I
> hope to clean up the issues next week.

Excellent, thanks!

Thomas

Patch

diff --git a/package/Config.in b/package/Config.in
index 85583c6..b394f18 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -504,6 +504,7 @@  source "package/rsync/Config.in"
 source "package/samba/Config.in"
 source "package/ser2net/Config.in"
 source "package/socat/Config.in"
+source "package/socketcand/Config.in"
 source "package/spawn-fcgi/Config.in"
 source "package/squid/Config.in"
 source "package/stunnel/Config.in"
diff --git a/package/socketcand/Config.in b/package/socketcand/Config.in
new file mode 100644
index 0000000..ed973b7
--- /dev/null
+++ b/package/socketcand/Config.in
@@ -0,0 +1,9 @@ 
+config BR2_PACKAGE_SOCKETCAND
+	bool "socketcand"
+	select BR2_PACKAGE_LIBCONFIG
+	help
+	  Socketcand is a daemon that provides access to CAN interfaces
+	  on a machine via a network interface.
+
+	  https://github.com/dschanoeh/socketcand
+
diff --git a/package/socketcand/socketcand.mk b/package/socketcand/socketcand.mk
new file mode 100644
index 0000000..8677520
--- /dev/null
+++ b/package/socketcand/socketcand.mk
@@ -0,0 +1,12 @@ 
+#############################################################
+#
+# socketcand
+#
+#############################################################
+SOCKETCAND_VERSION = 7d06986fa4b5fd2c210ec4e248dab41107be1ccd
+SOCKETCAND_SITE = git://github.com/dschanoeh/socketcand.git
+SOCKETCAND_AUTORECONF = YES
+SOCKETCAND_DEPENDENCIES = libconfig
+
+$(eval $(call AUTOTARGETS))
+