| Message ID | 20120322064409.GE7369@elgon.mountain |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 3/22/2012 1:44 AM, Dan Carpenter wrote: > We should be using the gfp flags the caller specified here, instead of > GFP_KERNEL. I think this might be a bugfix, depending on the value of > "sock->sk->sk_allocation" when we call rds_conn_create_outgoing() in > rds_sendmsg(). Otherwise, it's just a cleanup. > > Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com> Acked-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com> Date: Thu, 22 Mar 2012 10:19:50 -0500 > On 3/22/2012 1:44 AM, Dan Carpenter wrote: >> We should be using the gfp flags the caller specified here, instead of >> GFP_KERNEL. I think this might be a bugfix, depending on the value of >> "sock->sk->sk_allocation" when we call rds_conn_create_outgoing() in >> rds_sendmsg(). Otherwise, it's just a cleanup. >> >> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com> > Acked-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/rds/loop.c b/net/rds/loop.c index 87ff2a8..6b12b68 100644 --- a/net/rds/loop.c +++ b/net/rds/loop.c @@ -121,7 +121,7 @@ static int rds_loop_conn_alloc(struct rds_connection *conn, gfp_t gfp) struct rds_loop_connection *lc; unsigned long flags; - lc = kzalloc(sizeof(struct rds_loop_connection), GFP_KERNEL); + lc = kzalloc(sizeof(struct rds_loop_connection), gfp); if (!lc) return -ENOMEM; diff --git a/net/rds/iw_cm.c b/net/rds/iw_cm.c index 9556d28..a91e1db 100644 --- a/net/rds/iw_cm.c +++ b/net/rds/iw_cm.c @@ -694,7 +694,7 @@ int rds_iw_conn_alloc(struct rds_connection *conn, gfp_t gfp) unsigned long flags; /* XXX too lazy? */ - ic = kzalloc(sizeof(struct rds_iw_connection), GFP_KERNEL); + ic = kzalloc(sizeof(struct rds_iw_connection), gfp); if (!ic) return -ENOMEM; diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c index 51c8689..a1e1162 100644 --- a/net/rds/ib_cm.c +++ b/net/rds/ib_cm.c @@ -749,7 +749,7 @@ int rds_ib_conn_alloc(struct rds_connection *conn, gfp_t gfp) int ret; /* XXX too lazy? */ - ic = kzalloc(sizeof(struct rds_ib_connection), GFP_KERNEL); + ic = kzalloc(sizeof(struct rds_ib_connection), gfp); if (!ic) return -ENOMEM;
We should be using the gfp flags the caller specified here, instead of GFP_KERNEL. I think this might be a bugfix, depending on the value of "sock->sk->sk_allocation" when we call rds_conn_create_outgoing() in rds_sendmsg(). Otherwise, it's just a cleanup. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html