Patchwork [google,4.6] Bump param value of default function size limit for auto cloning

login
register
mail settings
Submitter Sriraman Tallam
Date March 21, 2012, 6:20 p.m.
Message ID <CAAs8HmzFsba+Q_z3TwBaW=Ft9KKq7Z9A6VHw8+k57uUL32wvVQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/148051/
State New
Headers show

Comments

Sriraman Tallam - March 21, 2012, 6:20 p.m.
Hi,

  I am bumping up the default param value of  function size limit for
auto cloning. Since auto cloning happens on inlined functions, the
original value does not catch some cases in one of our benchmarks.

  Automatic function versioning is only available in the
google/gcc-4_6 branch. I am working on porting this to trunk. Please
see: http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01230.html for
description.

Thanks,
-Sri.
Xinliang David Li - March 21, 2012, 6:38 p.m.
ok.

thanks,

David

On Wed, Mar 21, 2012 at 11:20 AM, Sriraman Tallam <tmsriram@google.com> wrote:
> Hi,
>
>  I am bumping up the default param value of  function size limit for
> auto cloning. Since auto cloning happens on inlined functions, the
> original value does not catch some cases in one of our benchmarks.
>
>  Automatic function versioning is only available in the
> google/gcc-4_6 branch. I am working on porting this to trunk. Please
> see: http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01230.html for
> description.
>
> Thanks,
> -Sri.
>
>
> Index: params.def
> ===================================================================
> --- params.def  (revision 185514)
> +++ params.def  (working copy)
> @@ -1040,7 +1040,7 @@ DEFPARAM (PARAM_PMU_PROFILE_N_ADDRESS,
>  DEFPARAM (PARAM_MAX_FUNCTION_SIZE_FOR_AUTO_CLONING,
>          "autoclone-function-size-limit",
>          "Do not auto clone functions beyond this size.",
> -         450, 0, 100000)
> +         5000, 0, 100000)
>
>  /*
>  Local variables:
Sriraman Tallam - March 22, 2012, 2:35 a.m.
Submitted to google/gcc-4_6.

Thanks,
-Sri.

On Wed, Mar 21, 2012 at 11:38 AM, Xinliang David Li <davidxl@google.com> wrote:
> ok.
>
> thanks,
>
> David
>
> On Wed, Mar 21, 2012 at 11:20 AM, Sriraman Tallam <tmsriram@google.com> wrote:
>> Hi,
>>
>>  I am bumping up the default param value of  function size limit for
>> auto cloning. Since auto cloning happens on inlined functions, the
>> original value does not catch some cases in one of our benchmarks.
>>
>>  Automatic function versioning is only available in the
>> google/gcc-4_6 branch. I am working on porting this to trunk. Please
>> see: http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01230.html for
>> description.
>>
>> Thanks,
>> -Sri.
>>
>>
>> Index: params.def
>> ===================================================================
>> --- params.def  (revision 185514)
>> +++ params.def  (working copy)
>> @@ -1040,7 +1040,7 @@ DEFPARAM (PARAM_PMU_PROFILE_N_ADDRESS,
>>  DEFPARAM (PARAM_MAX_FUNCTION_SIZE_FOR_AUTO_CLONING,
>>          "autoclone-function-size-limit",
>>          "Do not auto clone functions beyond this size.",
>> -         450, 0, 100000)
>> +         5000, 0, 100000)
>>
>>  /*
>>  Local variables:

Patch

Index: params.def
===================================================================
--- params.def	(revision 185514)
+++ params.def	(working copy)
@@ -1040,7 +1040,7 @@  DEFPARAM (PARAM_PMU_PROFILE_N_ADDRESS,
 DEFPARAM (PARAM_MAX_FUNCTION_SIZE_FOR_AUTO_CLONING,
 	  "autoclone-function-size-limit",
 	  "Do not auto clone functions beyond this size.",
-	  450, 0, 100000)
+	  5000, 0, 100000)

 /*
 Local variables: