| Message ID | 1332344980-8658-15-git-send-email-holger.brunck@keymile.com |
|---|---|
| State | Accepted |
| Commit | cc79697c963548f27bceece9c2e8c24f5703c50a |
| Delegated to: | Prafulla Wadaskar |
| Headers | show |
> -----Original Message----- > From: Holger Brunck [mailto:holger.brunck@keymile.com] > Sent: 21 March 2012 21:20 > To: u-boot@lists.denx.de > Cc: Stefan Bigler; Valentin Longchamp; Gerlando Falauto; Prafulla > Wadaskar; Holger Brunck > Subject: [PATCH 14/21] mvgbe: remove warning for unused methods > > From: Stefan Bigler <stefan.bigler@keymile.com> > > Some baords may use the GBE interface but they have no > phy connected to the interface and a direct MAC/MAC interface. > For them we need to get rid of compiler warnings. > > Signed-off-by: Stefan Bigler <stefan.bigler@keymile.com> > cc: Valentin Longchamp <valentin.longchamp@keymile.com> > cc: Gerlando Falauto <gerlando.falauto@keymile.com> > cc: Prafulla Wadaskar <prafulla@marvell.com> > cc: Holger Brunck <holger.brunck@keymile.com> > --- > drivers/net/mvgbe.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c > index 477bf5c..dcc1547 100644 > --- a/drivers/net/mvgbe.c > +++ b/drivers/net/mvgbe.c > @@ -52,6 +52,7 @@ DECLARE_GLOBAL_DATA_PTR; > #define MV_PHY_ADR_REQUEST 0xee > #define MVGBE_SMI_REG (((struct mvgbe_registers *)MVGBE0_BASE)->smi) > > +#if defined(CONFIG_MII) || defined(CONFIG_CMD_MII) > /* > * smi_reg_read - miiphy_read callback function. > * > @@ -181,6 +182,7 @@ static int smi_reg_write(const char *devname, u8 > phy_adr, u8 reg_ofs, u16 data) > > return 0; > } > +#endif > > /* Stop and checks all queues */ > static void stop_queue(u32 * qreg) > -- Pls post this as standalone patch, does not have any dependency. Regards.. Prafulla . . . > 1.7.1
Hi Prafulla, On 03/21/2012 05:30 PM, Prafulla Wadaskar wrote: >> Subject: [PATCH 14/21] mvgbe: remove warning for unused methods >> >> From: Stefan Bigler <stefan.bigler@keymile.com> >> >> Some baords may use the GBE interface but they have no >> phy connected to the interface and a direct MAC/MAC interface. >> For them we need to get rid of compiler warnings. >> >> Signed-off-by: Stefan Bigler <stefan.bigler@keymile.com> >> cc: Valentin Longchamp <valentin.longchamp@keymile.com> >> cc: Gerlando Falauto <gerlando.falauto@keymile.com> >> cc: Prafulla Wadaskar <prafulla@marvell.com> >> cc: Holger Brunck <holger.brunck@keymile.com> >> --- >> drivers/net/mvgbe.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> > > Pls post this as standalone patch, does not have any dependency. > it has a dependency. Without this patch our new boards submitted in this patch series will throw compiler warnings. But if you still insist, I can do this... Regards Holger
> -----Original Message----- > From: Holger Brunck [mailto:holger.brunck@keymile.com] > Sent: 22 March 2012 13:20 > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Stefan Bigler; Valentin Longchamp; Gerlando > Falauto > Subject: Re: [PATCH 14/21] mvgbe: remove warning for unused methods > > Hi Prafulla, > > On 03/21/2012 05:30 PM, Prafulla Wadaskar wrote: > >> Subject: [PATCH 14/21] mvgbe: remove warning for unused methods > >> > >> From: Stefan Bigler <stefan.bigler@keymile.com> > >> > >> Some baords may use the GBE interface but they have no > >> phy connected to the interface and a direct MAC/MAC interface. > >> For them we need to get rid of compiler warnings. > >> > >> Signed-off-by: Stefan Bigler <stefan.bigler@keymile.com> > >> cc: Valentin Longchamp <valentin.longchamp@keymile.com> > >> cc: Gerlando Falauto <gerlando.falauto@keymile.com> > >> cc: Prafulla Wadaskar <prafulla@marvell.com> > >> cc: Holger Brunck <holger.brunck@keymile.com> > >> --- > >> drivers/net/mvgbe.c | 2 ++ > >> 1 files changed, 2 insertions(+), 0 deletions(-) > >> > > > > Pls post this as standalone patch, does not have any dependency. > > > > it has a dependency. Without this patch our new boards submitted in > this patch > series will throw compiler warnings. But if you still insist, I can do > this... This should be okay, please post t separately Regards.. Prafulla . . . > > Regards > Holger
diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c index 477bf5c..dcc1547 100644 --- a/drivers/net/mvgbe.c +++ b/drivers/net/mvgbe.c @@ -52,6 +52,7 @@ DECLARE_GLOBAL_DATA_PTR; #define MV_PHY_ADR_REQUEST 0xee #define MVGBE_SMI_REG (((struct mvgbe_registers *)MVGBE0_BASE)->smi) +#if defined(CONFIG_MII) || defined(CONFIG_CMD_MII) /* * smi_reg_read - miiphy_read callback function. * @@ -181,6 +182,7 @@ static int smi_reg_write(const char *devname, u8 phy_adr, u8 reg_ofs, u16 data) return 0; } +#endif /* Stop and checks all queues */ static void stop_queue(u32 * qreg)