From patchwork Tue Mar 20 20:59:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Cr=C3=ADstian_Viana?= X-Patchwork-Id: 147841 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AAEACB6EF4 for ; Wed, 21 Mar 2012 08:00:52 +1100 (EST) Received: from localhost ([::1]:41884 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA6Ak-0008S3-Hk for incoming@patchwork.ozlabs.org; Tue, 20 Mar 2012 17:00:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA6AZ-0008KJ-2W for qemu-devel@nongnu.org; Tue, 20 Mar 2012 17:00:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA6AU-0005hs-CJ for qemu-devel@nongnu.org; Tue, 20 Mar 2012 17:00:38 -0400 Received: from e24smtp04.br.ibm.com ([32.104.18.25]:49676) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA6AU-0005hL-0n for qemu-devel@nongnu.org; Tue, 20 Mar 2012 17:00:34 -0400 Received: from /spool/local by e24smtp04.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 20 Mar 2012 18:00:25 -0300 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp04.br.ibm.com (10.172.0.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 20 Mar 2012 18:00:24 -0300 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 3D638352004F for ; Tue, 20 Mar 2012 18:00:23 -0300 (BRT) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay02.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2KL0Gkh35389764 for ; Tue, 20 Mar 2012 18:00:16 -0300 Received: from d24av04.br.ibm.com (loopback [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2KJ0BNt021651 for ; Tue, 20 Mar 2012 16:00:12 -0300 Received: from jellybean.br.ibm.com (jellybean.br.ibm.com [9.18.239.196]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q2KJ0AS2021616; Tue, 20 Mar 2012 16:00:11 -0300 From: =?UTF-8?q?Cr=C3=ADstian=20Viana?= To: qemu-devel@nongnu.org Date: Tue, 20 Mar 2012 17:59:50 -0300 Message-Id: <1332277190-14477-2-git-send-email-vianac@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8.5 In-Reply-To: <1332277190-14477-1-git-send-email-vianac@linux.vnet.ibm.com> References: <1332277190-14477-1-git-send-email-vianac@linux.vnet.ibm.com> MIME-Version: 1.0 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12032021-8936-0000-0000-0000063E6AD5 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 32.104.18.25 Cc: aliguori@us.ibm.com, =?UTF-8?q?Cr=C3=ADstian=20Viana?= Subject: [Qemu-devel] [PATCH v2 2/2] Change timedrift default value to slew X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as the time source. If time drift is not enabled, Windows is prone to blue screening. Signed-off-by: Crístian Viana --- hw/mc146818rtc.c | 2 +- vl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 2b59c36..2b31587 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @@ -726,7 +726,7 @@ ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq) static Property mc146818rtc_properties[] = { DEFINE_PROP_INT32("base_year", RTCState, base_year, 1980), DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState, - lost_tick_policy, LOST_TICK_DISCARD), + lost_tick_policy, LOST_TICK_SLEW), DEFINE_PROP_END_OF_LIST(), }; diff --git a/vl.c b/vl.c index 112b0e0..62dda67 100644 --- a/vl.c +++ b/vl.c @@ -550,7 +550,7 @@ static void configure_rtc(QemuOpts *opts) qdev_prop_register_global_list(slew_lost_ticks); } else if (!strcmp(value, "none")) { - /* discard is default */ + /* do nothing */ } else { fprintf(stderr, "qemu: invalid option value '%s'\n", value); exit(1);